From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B187DC77B7C for ; Mon, 17 Apr 2023 18:50:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229580AbjDQSuI (ORCPT ); Mon, 17 Apr 2023 14:50:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229575AbjDQSuH (ORCPT ); Mon, 17 Apr 2023 14:50:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D68438F; Mon, 17 Apr 2023 11:50:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 46BCA620BE; Mon, 17 Apr 2023 18:50:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9596C433EF; Mon, 17 Apr 2023 18:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681757405; bh=/SYyLnfM82MmE33YFZCDJXYlbvQSEgvgV14fp98uexE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oXrHVDg2ba3fKunDg88Fyb82QGklmMqoMwObeUyGwXoO78uAk+srLuf2KLzqZ6ZJm JBPV/Y2NYMQTNLEZcQc6bJHDCSqLDfKfrtyxk2ihTQLkvg4hFTOpU4gbJAIDh1UJxE IiRli5a/Q/hCmFRpE8ERVr45SZEPX5gmLI7XQDGNig7c7f2dkmJz62cEijFOiA01qy kPEvx7f6D6kNXjovR8vmKYvaMRojpp5rxn0848rZPzQHzVin+4N+lcWm3tl7PnIsAf HKLjvktaoQsne9EW3vECUV/W7qfPfBGEHfm8zXyMiOkvdpbV7z3QW2ScC8b7tCjM7G CNMJUt50vFSKw== Date: Mon, 17 Apr 2023 11:50:03 -0700 From: Jakub Kicinski To: "Zulkifli, Muhammad Husaini" Cc: "Song, Yoong Siang" , "Bezdeka, Florian" , "Brandeburg, Jesse" , "Nguyen, Anthony L" , "David S . Miller" , "Eric Dumazet" , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , "John Fastabend" , "Fijalkowski, Maciej" , Vedang Patel , "Joseph, Jithu" , Andre Guedes , "Brouer, Jesper" , "Stanislav Fomichev" , "Keller, Jacob E" , David Laight , "xdp-hints@xdp-project.net" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "bpf@vger.kernel.org" Subject: Re: [PATCH net v3 1/1] igc: read before write to SRRCTL register Message-ID: <20230417115003.0d2ac372@kernel.org> In-Reply-To: References: <20230414154902.2950535-1-yoong.siang.song@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, 17 Apr 2023 02:53:13 +0000 Zulkifli, Muhammad Husaini wrote: > Are you observing similar issue like below? > ptp4l: timed out while polling for tx timestamp > ptp4l: increasing tx_timestamp_timeout may correct this issue > > If yes, only TXSTAMPO register is used for both PTP and non-PTP packets in > the current driver code. There is a possibility that the time stamp > for a PTP packet will be lost when there is a lot of traffic when multiple > applications request for hardware transmission timestamps. > Few months back, I submitted a patch series to enable the DMA > Timestamp for non-ptp packet which can resolve the above issue. > https://lore.kernel.org/netdev/20221018010733.4765-1-muhammad.husaini.zulkifli@intel.com/T/ > Will continuing back the activity soon. FWIW the work on selecting the source of the timestamp is progressing slowly: https://lore.kernel.org/all/20230406173308.401924-1-kory.maincent@bootlin.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A99D6C77B76 for ; Mon, 17 Apr 2023 18:50:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 24DFA41526; Mon, 17 Apr 2023 18:50:12 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 24DFA41526 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1681757412; bh=LWorP6vq9E7zq4jryszJ2+Z9phEhE42ESNROLKq/JnA=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=TZ5MwsQ4DdKqx04QgOnOs9ck+wQNaBjwJHdV4awa+veh6W1X2muhcdwWn0i5CrdFw 3H/PUxSsOtv7kfOKeQlJ7GNLwu8WyLBoJP79DlpWLe5q54jzwLNCBW4FGe4XCsG0pt +h25u2onIhc5yPkroOG4u12xjlfXWYboRSsyd44n6kvhoV5Unr3sQhhV2u1vJQ8i1r hpt2krzPz7AbItDCoDiW7WUyx3lh3tKVrUDIoSt3SbAvG6VKbwM0AA1qkstrs4Imha Hdx0Ag6PfFwHzO/4iVfupXY0FWTXYxTahaw9ikHqb958lRbCfijLxwW1fOGASR7tUC QwL1TA8VcFTDw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fblSKTS2zRt9; Mon, 17 Apr 2023 18:50:11 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 051A241505; Mon, 17 Apr 2023 18:50:11 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 051A241505 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id A56431C41E0 for ; Mon, 17 Apr 2023 18:50:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 7D4A860BEA for ; Mon, 17 Apr 2023 18:50:08 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 7D4A860BEA X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z3XVY6wHdZnW for ; Mon, 17 Apr 2023 18:50:07 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6BDE660B51 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp3.osuosl.org (Postfix) with ESMTPS id 6BDE660B51 for ; Mon, 17 Apr 2023 18:50:07 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3513C60B8F; Mon, 17 Apr 2023 18:50:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9596C433EF; Mon, 17 Apr 2023 18:50:04 +0000 (UTC) Date: Mon, 17 Apr 2023 11:50:03 -0700 From: Jakub Kicinski To: "Zulkifli, Muhammad Husaini" Message-ID: <20230417115003.0d2ac372@kernel.org> In-Reply-To: References: <20230414154902.2950535-1-yoong.siang.song@intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681757405; bh=/SYyLnfM82MmE33YFZCDJXYlbvQSEgvgV14fp98uexE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oXrHVDg2ba3fKunDg88Fyb82QGklmMqoMwObeUyGwXoO78uAk+srLuf2KLzqZ6ZJm JBPV/Y2NYMQTNLEZcQc6bJHDCSqLDfKfrtyxk2ihTQLkvg4hFTOpU4gbJAIDh1UJxE IiRli5a/Q/hCmFRpE8ERVr45SZEPX5gmLI7XQDGNig7c7f2dkmJz62cEijFOiA01qy kPEvx7f6D6kNXjovR8vmKYvaMRojpp5rxn0848rZPzQHzVin+4N+lcWm3tl7PnIsAf HKLjvktaoQsne9EW3vECUV/W7qfPfBGEHfm8zXyMiOkvdpbV7z3QW2ScC8b7tCjM7G CNMJUt50vFSKw== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=oXrHVDg2 Subject: Re: [Intel-wired-lan] [PATCH net v3 1/1] igc: read before write to SRRCTL register X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Bezdeka, Florian" , Alexei Starovoitov , Eric Dumazet , "Nguyen, Anthony L" , Stanislav Fomichev , Andre Guedes , "xdp-hints@xdp-project.net" , Daniel Borkmann , John Fastabend , "Brandeburg, Jesse" , "intel-wired-lan@lists.osuosl.org" , "Brouer, Jesper" , Paolo Abeni , Jesper Dangaard Brouer , "Joseph, Jithu" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , David Laight , "Song, Yoong Siang" , "bpf@vger.kernel.org" , "David S . Miller" , Vedang Patel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, 17 Apr 2023 02:53:13 +0000 Zulkifli, Muhammad Husaini wrote: > Are you observing similar issue like below? > ptp4l: timed out while polling for tx timestamp > ptp4l: increasing tx_timestamp_timeout may correct this issue > > If yes, only TXSTAMPO register is used for both PTP and non-PTP packets in > the current driver code. There is a possibility that the time stamp > for a PTP packet will be lost when there is a lot of traffic when multiple > applications request for hardware transmission timestamps. > Few months back, I submitted a patch series to enable the DMA > Timestamp for non-ptp packet which can resolve the above issue. > https://lore.kernel.org/netdev/20221018010733.4765-1-muhammad.husaini.zulkifli@intel.com/T/ > Will continuing back the activity soon. FWIW the work on selecting the source of the timestamp is progressing slowly: https://lore.kernel.org/all/20230406173308.401924-1-kory.maincent@bootlin.com/ _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan