From: Jakub Kicinski <kuba@kernel.org>
To: Corinna Vinschen <vinschen@redhat.com>
Cc: netdev@vger.kernel.org,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
alexandre.torgue@foss.st.com, Jose Abreu <joabreu@synopsys.com>
Subject: Re: [PATCH net-next] net: stmmac: propagate feature flags to vlan
Date: Mon, 17 Apr 2023 12:11:46 -0700 [thread overview]
Message-ID: <20230417121146.654b980d@kernel.org> (raw)
In-Reply-To: <ZD2X8ALO3m7dmbOu@calimero.vinschen.de>
On Mon, 17 Apr 2023 21:03:12 +0200 Corinna Vinschen wrote:
> Yes, that was a good idea. Turns out, TSO doesn't really work well
> with VLANs. The speed is... suboptimal. Here are some results
> with iperf, showing only the summary lines.
Hah, good to find out before users did :)
IIRC there is something in the TCP stack which retries sending
as non-TSO if TSO keeps failing so "TSO is very slow" may in fact
mean TSO is completely broken but TCP is managing to deliver a little
bit with just retransmissions or super tiny cwnd or some such.
next prev parent reply other threads:[~2023-04-17 19:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 13:00 [PATCH net-next] net: stmmac: propagate feature flags to vlan Corinna Vinschen
2023-04-11 15:44 ` Simon Horman
2023-04-11 22:36 ` Jacob Keller
2023-04-12 13:11 ` Corinna Vinschen
2023-04-12 14:45 ` Jakub Kicinski
2023-04-12 14:50 ` Corinna Vinschen
2023-04-13 4:15 ` Jakub Kicinski
2023-04-13 15:25 ` Corinna Vinschen
2023-04-13 16:00 ` Jakub Kicinski
2023-04-17 19:03 ` Corinna Vinschen
2023-04-17 19:11 ` Jakub Kicinski [this message]
2023-04-17 19:28 ` [PATCH v2 " Corinna Vinschen
2023-04-19 4:50 ` patchwork-bot+netdevbpf
2023-06-22 8:20 ` [PATCH " Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230417121146.654b980d@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=joabreu@synopsys.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.