From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69382C77B70 for ; Mon, 17 Apr 2023 10:16:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CQaAtC6MYV4Cka2S0cYrLSjSJSU4CARIEs9KB8Xrvi8=; b=R8nwALd2pbTZut h/vWVkPpg2XxDqkmk6Z/+LSM9vDC1pwuNWM5tnEOfltFrl2m8l1Z1gh93AiLPqULRaE4XSoJXhpus OwxpTupNAsBzzIa1yKnp04kBixX/Wtulv4KVPOi+XdP9vAYKE/eDhm2vE38JzCarEs1CCiysihgBa 7AKzELkIEcT8oGvL9kgXOjGvs1x73KMyLVS7f0B8YN3vThqrDZUz8idnTq5AoTAE7wZipbUQZXfvI yxb3/PK2b9r9C3UfnJTjUwjQ7b5XdW8dh5jJcHVnibMJYkPo37FuhRSKWdRiEo/ZkW0XYUbn/s26d FzDczbbQWiNMORhiAjYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1poLug-00Fhlf-0B; Mon, 17 Apr 2023 10:16:46 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1poLub-00FhjQ-0Q for linux-phy@lists.infradead.org; Mon, 17 Apr 2023 10:16:45 +0000 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 6FD9AFF80F; Mon, 17 Apr 2023 10:16:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681726594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2kMksyFjGeVV2iklCwJ5cx3YfiDVM7A12HWZsN5LSlA=; b=eXWJEI1DzdLDX23p4dXUCZ4RaIC/UFBt5MrcdTcvrhcsRAOyTExzHAtfW8urPZaJFEB7hJ RsyCLtNmlGE3jnuQMOSa55Lk0j12FqIHJmSVpDgghi21phcwXhlvetfPjdo8mJEsuAq5LM zoVOAX9aMD+jaKguY4byqxzhJ6dqH8njWVl64fKA1565TdtZmO+Zyvhv6eYhVZ2sTcOfBu qEjIjzv6oC8SfSClmfYo4E4A+ik/tjHM7w50hrYn4cJ5qfl/Xlcu+EXXI0TvJvA1jhapoE vZuMbUR902z8esz0dmjsQE7hrktvJ6Ez9X1w/SrMqdz6yw51IYkW9GPrie8APw== Date: Mon, 17 Apr 2023 12:16:29 +0200 From: Herve Codina To: Andrew Lunn Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, Christophe Leroy , Thomas Petazzoni Subject: Re: [RFC PATCH 0/4] Add support for QMC HDLC and PHY Message-ID: <20230417121629.63e97b80@bootlin.com> In-Reply-To: References: <20230323103154.264546-1-herve.codina@bootlin.com> <885e4f20-614a-4b8e-827e-eb978480af87@lunn.ch> <20230414165504.7da4116f@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230417_031641_669133_E5EA0252 X-CRM114-Status: GOOD ( 50.87 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org SGkgQW5kcmV3CgpPbiBGcmksIDE0IEFwciAyMDIzIDE4OjE1OjMwICswMjAwCkFuZHJldyBMdW5u IDxhbmRyZXdAbHVubi5jaD4gd3JvdGU6Cgo+ID4gPiBXaGVuIGkgbG9vayBhdCB0aGUgJ3BoeScg ZHJpdmVyLCBpIGRvbid0IHNlZSBhbnl0aGluZyBhIHR5cGljYWwgUEhZCj4gPiA+IGRyaXZlciB1 c2VkIGZvciBuZXR3b3JraW5nIHdvdWxkIGhhdmUuIEEgbmV0d29ya2luZyBQSFkgZHJpdmVyIG9m dGVuCj4gPiA+IGhhcyB0aGUgYWJpbGl0eSB0byBjaGFuZ2UgYmV0d2VlbiBtb2RlcywgbGlrZSBT R01JSSwgUVNHTUlJLCAxMEdCQVNFUi4KPiA+ID4gVGhlIGVxdWl2YWxlbnQgaGVyZSB3b3VsZCBi ZSBjaGFuZ2luZyBiZXR3ZWVuIEUxLCBUMSBhbmQgSjEuIEl0IGhhcwo+ID4gPiB0aGUgYWJpbGl0 eSB0byBjaGFuZ2UgdGhlIHNwZWVkLCAxRywgMi41RywgMTBHIGV0Yy4gVGhpcyBjb3VsZCBiZQo+ ID4gPiBpbXBsaWVkIHZpYSB0aGUgbW9kZSwgRTEgaXMgMi4wNDhNYnBzLCBUMSAxLjU0NE1icHMs IGFuZCBpIGZvcmdldCB3aGF0Cj4gPiA+IEoxIGlzLiBUaGUgUEVGMjI1NiBhbHNvIHNlZW1zIHRv IHN1cHBvcnQgRTEvVDEvSjEuIEhvdyBpcyBpdHMgbW9kZXMKPiA+ID4gY29uZmlndXJlZD8gIAo+ ID4gCj4gPiBBbGwgb2YgdGhlc2UgYXJlIHNldCBieSB0aGUgTUZEIGRyaXZlciBkdXJpbmcgaXRz IHByb2JlKCkuCj4gPiBUaGUgZXhwZWN0ZWQgc2V0dGluZyBjb21lIGZyb20gc2V2ZXJhbCBwcm9w ZXJ0aWVzIHByZXNlbnQgaW4gdGhlIHBlZjIyNTYKPiA+IERUIG5vZGUuIFRoZSBiaW5kaW5nIGNh biBiZSBmb3VuZCBoZXJlOgo+ID4gICBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvMjAyMzAz MjgwOTI2NDUuNjM0Mzc1LTItaGVydmUuY29kaW5hQGJvb3RsaW4uY29tLyAgCj4gCj4gSSdtIHN1 cnByaXNlZCB0byBzZWUgc28gbXVjaCBpbiB0aGUgYmluZGluZy4gSSBhc3N1bWUgeW91IGFyZSBm YW1pbGlhcgo+IHdpdGggREFIREkuIEl0IGFsbG93cyBuZWFybHkgZXZlcnl0aGluZyB0byBiZSBj b25maWd1cmVkIGF0Cj4gcnVudGltZS4gVGhlIHN5c3RlbXMgaSd2ZSB1c2VkIGFsbG93IHlvdSB0 byBzZWxlY3QgdGhlIGNsb2NrCj4gY29uZmlndXJhdGlvbiwgbGluZSBidWlsZCBvdXQsIHVzZXIg c2lkZSB2cyBuZXR3b3JrcyBzaWRlIHNpZ25hbGxpbmcKPiBDUkM0IGVuYWJsZXMgb3Igbm90LCBl dGMuCgpXZWxsLCBJIGFtIG5vdCBmYW1pbGlhciB3aXRoIERBSERJIGF0IGFsbC4KSSBkaWRuJ3Qg ZXZlbiBrbm93IGFib3V0IHRoZSBEQUhESSBwcm9qZWN0LgpUaGUgcHJvamVjdCBzZWVtcyB0byB1 c2Ugc3BlY2lmaWMga2VybmVsIGRyaXZlciBhbmQgSSB3b3VsZCBsaWtlIHRvIGF2b2lkCnRoZXNl IGV4dGVybmFsIGRyaXZlcnMuCgo+IAo+ID4gRnVydGhlciBtb3JlLCB0aGUgUU1DIEhETEMgaXMg bm90IHRoZSBvbmx5IFBFRjIyNTYgY29uc3VtZXIuCj4gPiBUaGUgUEVGMjI1NiBpcyBhbHNvIHVz ZWQgZm9yIGF1ZGlvIHBhdGggKGllIGF1ZGlvIG92ZXIgRTEpIGFuZCBzbyB0aGUKPiA+IGNvbmZp Z3VyYXRpb24gaXMgc2hhcmVkIGJldHdlZW4gbmV0d29yayBhbmQgYXVkaW8uIFRoZSBzZXR0aW5n IGNhbm5vdCBiZQo+ID4gaGFuZGxlIGJ5IHRoZSBuZXR3b3JrIHBhcnQgYXMgdGhlIFBFRjIyNTYg bXVzdCBiZSBhdmFpbGFibGUgYW5kIGNvcnJlY3RseQo+ID4gY29uZmlndXJlZCBldmVuIGlmIHRo ZSBuZXR3b3JrIHBhcnQgaXMgbm90IHByZXNlbnQuICAKPiAKPiBCdXQgdGhlcmUgaXMgbm8gcmVh c29uIHdoeSB0aGUgTUZEIGNvdWxkIG5vdCBwcm92aWRlIGEgZ2VuZXJpYyBQSFkgdG8KPiBhY3R1 YWxseSBjb25maWd1cmUgdGhlICdQSFknLiBUaGUgSERMQyBkcml2ZXIgY2FuIHRoZW4gYWxzbyB1 c2UgdGhlCj4gZ2VuZXJpYyBQSFkuIEl0IHdvdWxkIG1ha2UgeW91ciBnZW5lcmljIFBIWSBsZXNz ICdwb2ludGxlc3MnLiBJJ20gbm90Cj4gc2F5aW5nIGl0IGhhcyB0byBiZSB0aGlzIHdheSwgYnV0 IGl0IGlzIGFuIG9wdGlvbi4KCklmIHRoZSBwZWYyMjU2IFBIWSBwcm92aWRlcyBhIGNvbmZpZ3Vy ZSBmdW5jdGlvbiwgd2hvIGlzIGdvaW5nIHRvIGNhbGwgdGhpcwpjb25maWd1cmUoKS4gSSBtZWFu IHRoZSBvbmUgY2FsbGluZyB0aGUgY29uZmlndXJlIHdpbGwgYmUgdGhlIGNvbmZpZ3VyYXRpb24K b3duZXIuIE5vbmUgb2YgdGhlIE1GRCBjaGlsZCBjYW4gb3duIHRoZSBjb25maWd1cmF0aW9uIGFz IHRoaXMgY29uZmlndXJhdGlvbgp3aWxsIGltcGFjdCBvdGhlciBjaGlsZHJlbi4gU28gdGhlIE1G RCAodG9wIGxldmVsIG5vZGUpIG93bnMgdGhlIGNvbmZpZ3VyYXRpb24uCgo+ICAKPiA+ID4gSW4g ZmFjdCwgdGhpcyBQSFkgZHJpdmVyIGRvZXMgbm90IHNlZW0gdG8gZG8gYW55IGNvbmZpZ3VyYXRp b24gb2YgYW55Cj4gPiA+IHNvcnQgb24gdGhlIGZyYW1lci4gQWxsIGl0IHNlZW1zIHRvIGJlIGRv aW5nIGlzIHRha2Ugbm90aWZpY2F0aW9uIGZyb20KPiA+ID4gb25lIGNoYWluIGFuZCBzZW5kIHRo ZW0gb3V0IGFub3RoZXIgY2hhaW4hICAKPiA+IAo+ID4gQ29uZmlndXJhdGlvbiBpcyBkb25lIGJ5 IHRoZSBwYXJlbnQgTUZEIGRyaXZlci4KPiA+IFRoZSBQSFkgZHJpdmVyIGhhcyBub3RoaW5nIG1v cmUgdG8gZG8uCj4gPiAgIAo+ID4gPiAKPiA+ID4gSSBhbHNvIHdvdW5kZXIgaWYgdGhpcyBnZXRf c3RhdHVzKCkgY2FsbCBpcyBzdWZmaWNpZW50LiBEb24ndCB5b3UgYWxzbwo+ID4gPiB3YW50IFJl ZCwgWWVsbG93IGFuZCBCbHVlIGFsYXJtcz8gSXQgaXMgbm90IGp1c3QgdGhlIGNhcnJpZXIgaXMg ZG93biwKPiA+ID4gYnV0IHdoeSBpdCBpcyBkb3duLiAgCj4gPiAKPiA+IEkgZG9uJ3QgbmVlZCB0 aGVtIGluIG15IHVzZSBjYXNlIGJ1dCBpZiBuZWVkZWQgY2FuJ3QgdGhleSBiZSBhZGRlZCBsYXRl cj8KPiA+IEFsc28sIGZyb20gdGhlIEhETEMgZGV2aWNlIHBvaW50IG9mIHZpZXcgd2hhdCBjYW4g YmUgZG9uZSB3aXRoIHRoZXNlIGFsYXJtcz8gIAo+IAo+IGh0dHBzOi8vZWxpeGlyLmJvb3RsaW4u Y29tL2xpbnV4L2xhdGVzdC9zb3VyY2UvRG9jdW1lbnRhdGlvbi9uZXR3b3JraW5nL2V0aHRvb2wt bmV0bGluay5yc3QjTDQ3MgoKVGhhbmtzIGZvciBwb2ludGluZyB0aGlzIGludGVyZmFjZS4KSXQg aXMgc3BlY2lmaWMgdG8gZXRodG9vbCBidXQgSSBjYW4gc2VlIHRoZSBpZGVhLgpUaGUgJ2dldF9z dGF0dXMnIEkgcHJvcG9zZWQgY291bGQgYmUgZXh0ZW5kZWQgbGF0ZXIgdG8gcHJvdmlkZSBtb3Jl CmluZm9ybWF0aW9uIHJlbGF0ZWQgdG8gdGhlIGNvbG91ciBvZiB0aGUgYWxhcm0gaWYgbmVlZGVk LgpldGh0b29sIGFuZCByZWxhdGVkIGludGVyZmFjZXMgYXJlIHZlcnkgd2VsbCBmaXR0ZWQgd2l0 aCBFdGhlcm5ldCBhbmQKcmVsYXRlZCBQSFlzLiBJIGFtIG5vdCBzdXJlIHRoYXQgZXRodG9vbCB3 aWxsIGJlIHVzYWJsZSBmb3IgdGhlIHBlZjIyNTYuCgo+IAo+ID4gUmVxdWVzdHMgbGluayBzdGF0 ZSBpbmZvcm1hdGlvbi4gTGluayB1cC9kb3duIGZsYWcgKGFzIHByb3ZpZGVkIGJ5Cj4gPiBgYEVU SFRPT0xfR0xJTktgYCBpb2N0bCBjb21tYW5kKSBpcyBwcm92aWRlZC4gT3B0aW9uYWxseSwgZXh0 ZW5kZWQKPiA+IHN0YXRlIG1pZ2h0IGJlIHByb3ZpZGVkIGFzIHdlbGwuIEluIGdlbmVyYWwsIGV4 dGVuZGVkIHN0YXRlCj4gPiBkZXNjcmliZXMgcmVhc29ucyBmb3Igd2h5IGEgcG9ydCBpcyBkb3du LCBvciB3aHkgaXQgb3BlcmF0ZXMgaW4gc29tZQo+ID4gbm9uLW9idmlvdXMgbW9kZS4gIAo+IAo+ IFRoZSBjb2xvdXIgb2YgdGhlIEFsYXJtIGdpdmVzIHlvdSBhbiBpZGVhIHdoaWNoIGVuZCBvZiB0 aGUgc3lzdGVtIGhhcwo+IHRoZSBwcm9ibGVtLgo+IAo+ID4gPiBPdmVyYWxsLCBpIGRvbid0IHNl ZSB3aHkgeW91IHdhbnQgYSBQSFkuIFdoYXQgdmFsdWUgZG9lcyBpdCBhZGQ/ICAKPiA+IAo+ID4g SSBuZWVkIHRvIGRldGVjdCBjYXJyaWVyIG9uL29mZiBhY2NvcmRpbmcgdG8gdGhlIEUxIGxpbmsg c3RhdGUuICAKPiAKPiBXaHkgbm90IGp1c3QgdXNlIHRoZSBNRkQgbm90aWZpZXI/IFdoYXQgaXMg dGhlIHZhbHVlIG9mIGEgUEhZIGRyaXZlcgo+IHRyYW5zbGF0aW5nIG9uZSBub3RpZmllciBpbnRv IGFub3RoZXI/CgpJIHRyYW5zbGF0ZWQgdG8gYW5vdGhlciBub3RpZmllciB0byBrZWVwIHRoZSBj b3JlIChNRkQpIHBlZjIyNTYgQVBJCmluZGVwZW5kZW50LgoKQnV0IGluZGVlZCB0aGlzIGNvdWxk IGJlIGNoYW5nZWQuCklmIGNoYW5nZWQsIHRoZSBNRkQgcGVmMjI1NiB3aWxsIGhhdmUgdG8gaGFu ZGxlIHRoZSBmdWxsIHN0cnVjdApwaHlfc3RhdHVzX2Jhc2ljIGFzIHRoZSB0cmFuc2xhdGlvbiB3 aWxsIG5vdCBiZSB0aGVyZSBhbnltb3JlLgpSaWdodCBub3csIHRoaXMgc3RydWN0dXJlIGlzIHBy ZXR0eSBzaW1wbGUgYW5kIGNvbnRhaW5zIG9ubHkgdGhlIGxpbmsgc3RhdGUKZmxhZy4gQnV0IGlu IHRoZSBmdXR1cmUsIHRoaXMgUEhZIHN0cnVjdHVyZSBjYW4gbW92ZSB0byBzb21ldGhpbmcgbW9y ZQpjb21wbGV4IGFuZCBJIGFtIG5vdCBzdXJlIHRoYXQgZmlsbGluZyB0aGlzIHN0cnVjdCBpcyB0 aGUgTUZEIHBlZjIyNTYKcmVzcG9uc2liaWxpdHkuIFRoZSBQSFkgcGVmMjI1NiBpcyByZXNwb25z aWJsZSBmb3IgdGhlIGNvcnJlY3Qgc3RydWN0dXJlCmNvbnRlbnRzIG5vdCBzdXJlIHRoYXQgdGhp cyBzaG91bGQgYmUgbW92ZWQgdG8gdGhlIE1GRCBwYXJ0LgoKPiAKPiBBbmQgd2h5IGlzIHRoZSBu b3RpZmllciBzcGVjaWZpYyB0byB0aGUgUEVGMjI1Nj8gV2hhdCB3b3VsZCBoYXBwZW4gaWYKPiBp IHVzZWQgYSBhbmFsb2cgZGV2aWNlcyBEUzIxNTUsIERTMjFRNTUsIGFuZCBEUzIxNTYsIG9yIHRo ZSBJRFQKPiA4MlAyMjgxPyBXb3VsZCBlYWNoIGhhdmUgaXRzIG93biBub3RpZmllcj8gQW5kIGhl bmNlIGVhY2ggd291bGQgbmVlZAo+IGl0cyBvd24gUEhZIHdoaWNoIHRyYW5zbGF0ZXMgb25lIG5v dGlmaWVyIGludG8gYW5vdGhlcj8KCkVhY2ggb2YgdGhlbSBzaG91bGQgaGF2ZSB0aGVpciBvd24g bm90aWZpZXIgaWYgdGhleSBjYW4gbm90aWZ5LgpBdCBsZWFzdCB0aGV5IHdpbGwgbmVlZCB0aGVp ciBvd24gbm90aWZpZXIgYXQgdGhleSBQSFkgZHJpdmVyIGxldmVsLgpIYXZpbmcgb3Igbm90IGEg dHJhbnNsYXRpb24gZnJvbSBzb21ldGhpbmcgZWxzZSB3b3VsZCBkZXBlbmQgb24gZWFjaCBkZXZp Y2UKUEhZIGRyaXZlciBpbXBsZW1lbnRhdGlvbi4KQWxzbywgbWF5YmUgc29tZSBQSFkgd2lsbCBu b3QgYmUgYWJsZSB0byBwcm92aWRlIG5vdGlmaWNhdGlvbnMgYnV0IG9ubHkKdGhlIGdldF9zdGF0 dXMoKS4gSW4gdGhpcyBjYXNlLCB0aGUgbm90aWZpZXIgaXMgbm90IG5lZWRlZC4KVGhlIHByb3Bv c2VkIFFNQyBIRExDIGRyaXZlciBoYW5kbGVzIHRoaXMgY2FzZSBzd2l0Y2hpbmcgdG8gcG9sbGlu ZyBtb2RlCmlmIHRoZSBQSFkgaXMgbm90IGFibGUgdG8gcHJvdmlkZSBub3RpZmljYXRpb24uCgo+ IAo+IFRoZXJlIGFyZSBlbm91Z2ggRTEvVDEvSjEgZnJhbWVycyB3ZSBzaG91bGQgaGF2ZSBhIGdl bmVyaWMgQVBJIGJldHdlZW4KPiB0aGUgZnJhbWVyIGFuZCB0aGUgSERMQyBkZXZpY2UuCj4gCgpJ IGFncmVlLgpJIHdvdWxkIGxpa2UgdGhpcyBmaXJzdCBpbXBsZW1lbnRhdGlvbiB3aXRob3V0IHRv byBtdWNoIEFQSSByZXN0cmljdGlvbgppbiBvcmRlciB0byBzZWUgaG93IGl0IGdvZXMuClRoZSBh Y3R1YWwgcHJvcG9zYWwgaW1wb3NlcyBub3RoaW5nIG9uIHRoZSBQSFkgaW50ZXJuYWwgaW1wbGVt ZW50YXRpb24uCnRoZSBwZWYyMjU2IGltcGxlbWVudGF0aW9uIGNob29zZXMgdG8gaGF2ZSB0d28g bm90aWZpZXJzIChvbmUgYXQgTUZECmxldmVsIGFuZCBvbmUgYXQgUEhZIGxldmVsKSBidXQgaXQg d2FzIG5vdCBpbXBvc2VkIGJ5IHRoZSBBUEkuCgpCZXN0IHJlZ2FyZHMsCkhlcnbDqQoKCi0tIAps aW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBz Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A880C77B76 for ; Mon, 17 Apr 2023 10:23:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230210AbjDQKXU (ORCPT ); Mon, 17 Apr 2023 06:23:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229575AbjDQKXR (ORCPT ); Mon, 17 Apr 2023 06:23:17 -0400 Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [IPv6:2001:4b98:dc4:8::240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F288D3A91; Mon, 17 Apr 2023 03:22:18 -0700 (PDT) Received: from relay9-d.mail.gandi.net (unknown [217.70.183.199]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 7FB4ACE256; Mon, 17 Apr 2023 10:17:54 +0000 (UTC) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 6FD9AFF80F; Mon, 17 Apr 2023 10:16:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1681726594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2kMksyFjGeVV2iklCwJ5cx3YfiDVM7A12HWZsN5LSlA=; b=eXWJEI1DzdLDX23p4dXUCZ4RaIC/UFBt5MrcdTcvrhcsRAOyTExzHAtfW8urPZaJFEB7hJ RsyCLtNmlGE3jnuQMOSa55Lk0j12FqIHJmSVpDgghi21phcwXhlvetfPjdo8mJEsuAq5LM zoVOAX9aMD+jaKguY4byqxzhJ6dqH8njWVl64fKA1565TdtZmO+Zyvhv6eYhVZ2sTcOfBu qEjIjzv6oC8SfSClmfYo4E4A+ik/tjHM7w50hrYn4cJ5qfl/Xlcu+EXXI0TvJvA1jhapoE vZuMbUR902z8esz0dmjsQE7hrktvJ6Ez9X1w/SrMqdz6yw51IYkW9GPrie8APw== Date: Mon, 17 Apr 2023 12:16:29 +0200 From: Herve Codina To: Andrew Lunn Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, Christophe Leroy , Thomas Petazzoni Subject: Re: [RFC PATCH 0/4] Add support for QMC HDLC and PHY Message-ID: <20230417121629.63e97b80@bootlin.com> In-Reply-To: References: <20230323103154.264546-1-herve.codina@bootlin.com> <885e4f20-614a-4b8e-827e-eb978480af87@lunn.ch> <20230414165504.7da4116f@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew On Fri, 14 Apr 2023 18:15:30 +0200 Andrew Lunn wrote: > > > When i look at the 'phy' driver, i don't see anything a typical PHY > > > driver used for networking would have. A networking PHY driver often > > > has the ability to change between modes, like SGMII, QSGMII, 10GBASER. > > > The equivalent here would be changing between E1, T1 and J1. It has > > > the ability to change the speed, 1G, 2.5G, 10G etc. This could be > > > implied via the mode, E1 is 2.048Mbps, T1 1.544Mbps, and i forget what > > > J1 is. The PEF2256 also seems to support E1/T1/J1. How is its modes > > > configured? > > > > All of these are set by the MFD driver during its probe(). > > The expected setting come from several properties present in the pef2256 > > DT node. The binding can be found here: > > https://lore.kernel.org/all/20230328092645.634375-2-herve.codina@bootlin.com/ > > I'm surprised to see so much in the binding. I assume you are familiar > with DAHDI. It allows nearly everything to be configured at > runtime. The systems i've used allow you to select the clock > configuration, line build out, user side vs networks side signalling > CRC4 enables or not, etc. Well, I am not familiar with DAHDI at all. I didn't even know about the DAHDI project. The project seems to use specific kernel driver and I would like to avoid these external drivers. > > > Further more, the QMC HDLC is not the only PEF2256 consumer. > > The PEF2256 is also used for audio path (ie audio over E1) and so the > > configuration is shared between network and audio. The setting cannot be > > handle by the network part as the PEF2256 must be available and correctly > > configured even if the network part is not present. > > But there is no reason why the MFD could not provide a generic PHY to > actually configure the 'PHY'. The HDLC driver can then also use the > generic PHY. It would make your generic PHY less 'pointless'. I'm not > saying it has to be this way, but it is an option. If the pef2256 PHY provides a configure function, who is going to call this configure(). I mean the one calling the configure will be the configuration owner. None of the MFD child can own the configuration as this configuration will impact other children. So the MFD (top level node) owns the configuration. > > > > In fact, this PHY driver does not seem to do any configuration of any > > > sort on the framer. All it seems to be doing is take notification from > > > one chain and send them out another chain! > > > > Configuration is done by the parent MFD driver. > > The PHY driver has nothing more to do. > > > > > > > > I also wounder if this get_status() call is sufficient. Don't you also > > > want Red, Yellow and Blue alarms? It is not just the carrier is down, > > > but why it is down. > > > > I don't need them in my use case but if needed can't they be added later? > > Also, from the HDLC device point of view what can be done with these alarms? > > https://elixir.bootlin.com/linux/latest/source/Documentation/networking/ethtool-netlink.rst#L472 Thanks for pointing this interface. It is specific to ethtool but I can see the idea. The 'get_status' I proposed could be extended later to provide more information related to the colour of the alarm if needed. ethtool and related interfaces are very well fitted with Ethernet and related PHYs. I am not sure that ethtool will be usable for the pef2256. > > > Requests link state information. Link up/down flag (as provided by > > ``ETHTOOL_GLINK`` ioctl command) is provided. Optionally, extended > > state might be provided as well. In general, extended state > > describes reasons for why a port is down, or why it operates in some > > non-obvious mode. > > The colour of the Alarm gives you an idea which end of the system has > the problem. > > > > Overall, i don't see why you want a PHY. What value does it add? > > > > I need to detect carrier on/off according to the E1 link state. > > Why not just use the MFD notifier? What is the value of a PHY driver > translating one notifier into another? I translated to another notifier to keep the core (MFD) pef2256 API independent. But indeed this could be changed. If changed, the MFD pef2256 will have to handle the full struct phy_status_basic as the translation will not be there anymore. Right now, this structure is pretty simple and contains only the link state flag. But in the future, this PHY structure can move to something more complex and I am not sure that filling this struct is the MFD pef2256 responsibility. The PHY pef2256 is responsible for the correct structure contents not sure that this should be moved to the MFD part. > > And why is the notifier specific to the PEF2256? What would happen if > i used a analog devices DS2155, DS21Q55, and DS2156, or the IDT > 82P2281? Would each have its own notifier? And hence each would need > its own PHY which translates one notifier into another? Each of them should have their own notifier if they can notify. At least they will need their own notifier at they PHY driver level. Having or not a translation from something else would depend on each device PHY driver implementation. Also, maybe some PHY will not be able to provide notifications but only the get_status(). In this case, the notifier is not needed. The proposed QMC HDLC driver handles this case switching to polling mode if the PHY is not able to provide notification. > > There are enough E1/T1/J1 framers we should have a generic API between > the framer and the HDLC device. > I agree. I would like this first implementation without too much API restriction in order to see how it goes. The actual proposal imposes nothing on the PHY internal implementation. the pef2256 implementation chooses to have two notifiers (one at MFD level and one at PHY level) but it was not imposed by the API. Best regards, Hervé