From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0CD4C77B72 for ; Mon, 17 Apr 2023 12:37:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9YMzEzFdhLFp2YkvPS1exdcHtrwvmKDdWS3mdUMwNSc=; b=dkWPafCfqLPLgj W7SMWFDo5kNDp2vAoR2fgX+hmsJmY5xSA6wILQPS/ZhZF3QqNk6nPRiMcNmPCov76b6azRsZmzOrH fydnlp//WuXvu4lJcQnii9Wi3NjP189zmA3fr9ExkfflcK7gcfUAeXO4f1kbe/C6ykJVriTzJsITh cFJUbc+BSFyq5zVqpuN0Sv9O+NNHrMfZBT9iKqe+uld4uSDhyp42GZeKXkIhVC4n9DCNTpb/nI2hn wIkfhu+e13kUEDiPaOK36SlWJDEatITFhS47TGminxu0QT8+h4mtaY4Ag4zuwvagDXpBLGvhkDlVX k2dKUapo6M7fdVyq3+UA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1poO6r-00GA2j-0R; Mon, 17 Apr 2023 12:37:29 +0000 Received: from vps.xff.cz ([195.181.215.36]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1poO6m-00GA1B-2B; Mon, 17 Apr 2023 12:37:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1681735036; bh=gJesLtiDnccwIC0RA7jikU/NZ0vOLBaI0EL8Y7OHrAI=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=SKQOE09xi6VRiW3rlypNrv35XlLjZcT1LxzPDOJaBEQcesmiGmOqr67+WxIoTRmZu NubFRUhbrg8yv0kIQWVlY5mn1HUL+NGM34mBpLBiH7bwGgbCaOr6VPJHtxKI6UQXxS U3rc5iLWiNyqO0OKKDbwpyQBbfDzFmcyNfiYcE6s= Date: Mon, 17 Apr 2023 14:37:16 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Heiko =?utf-8?Q?St=C3=BCbner?= Cc: Peter Robinson , Rob Herring , Krzysztof Kozlowski , Tom Fitzhenry , Martijn Braam , Caleb Connolly , Jarrah Gosbell , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] arm64: dts: rk3399-pinephone-pro: Add support for volume keys Message-ID: <20230417123716.c23izju4ezjrzytn@core> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Heiko =?utf-8?Q?St=C3=BCbner?= , Peter Robinson , Rob Herring , Krzysztof Kozlowski , Tom Fitzhenry , Martijn Braam , Caleb Connolly , Jarrah Gosbell , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20230405123813.2272919-1-pbrobinson@gmail.com> <20230405135339.bcdyjdbtynuwf5yz@core> <4152389.RUnXabflUD@diego> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4152389.RUnXabflUD@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230417_053725_199151_D025CB67 X-CRM114-Status: GOOD ( 19.95 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGVsbG8gSGVpa28sCgpPbiBNb24sIEFwciAxNywgMjAyMyBhdCAxMDozNDoyMEFNICswMjAwLCBI ZWlrbyBTdMO8Ym5lciB3cm90ZToKPiBIaSBQZXRlciwgT25kcmVqLAo+IAo+IEFtIE1pdHR3b2No LCA1LiBBcHJpbCAyMDIzLCAxNTo1MzozOSBDRVNUIHNjaHJpZWIgT25kxZllaiBKaXJtYW46Cj4g PiBbLi4uXQo+ID4KPiA+IChJIGhhdmUgdG8gcHJlc3MgcXVpdGUgaGFyZCB0byBnZXQgYmVsbG93 IDMwMCBhbmQgdG8gZ2V0IHJlbGlhYmxlIGRldGVjdGlvbgo+ID4gb2Ygdm9sdW1lIGRvd24ga2V5 IHByZXNzKQo+ID4gCj4gPiBPbiBkZXZlbG9wbWVudCB2ZXJzaW9uIG9mIHRoZSBwaG9uZSwgdGhl IHZhbHVlIHJldHVybmVkIGJ5IHNhcmRhYyBpcyBsZXNzCj4gPiB2YXJpYWJsZS4gQmFzaWNhbGx5 IGVpdGhlciAyOTguODI4MTI1IG9yIDMwMC41ODU5Mzc1IGJ1dCBpdCdzIGFsc28gb24KPiA+IHRo ZSBlZGdlLgo+ID4gCj4gPiBJIHN1Z2dlc3QgcmFpc2luZyB0aGUgdGhyZXNob2xkIHRvIHNvbWV0 aGluZyBsaWtlIDYwMCBhbmQgdG8gZG8geW91ciBvd24KPiA+IHRlc3RpbmcsIHRvIGdldCBtb3Jl IGRhdGEgcG9pbnRzLiBVbnByZXNzZWQgdmFsdWUgaXMgfjE3OTEuMjEwOTM3NSBvbiBib3RoCj4g PiBwaG9uZXMsIHNvIDQwMCBzdGlsbCBnZXRzIGEgbG90IG9mIGhlYWRyb29tLiBBbmQgdm9sdW1l IHVwIGlzIGFsd2F5cyA8IDE1Cj4gPiBpbiBteSB0ZXN0cy4KPiAKPiBkaWQgdGhpcyBnZXQgbW9y ZSBhdHRlbnRpb24gbWVhbndoaWxlPwo+IAo+IEkgZG9uJ3QgaGF2ZSBhIFBpbmVwaG9uZSBQcm8g bXlzZWxmLCBzbyB5b3UnbGwgbmVlZCB0byBkZWNpZGUgYmV0d2VlbiB5b3UKPiBhYm91dCB0aGUg dmFsdWUgYW5kIHRoZSBjb25jZXJuIE9uZHJlaiByYWlzZWQgaGVyZSBmb3IgdGhlIHZhbHVlLgoK SXQncyBzYWZlIGFuZCBuZWVkZWQgdG8gdXNlIGEgaGlnaGVyIHZhbHVlLgoKU0FSIEFEQyBpbnB1 dCBpcyBwdWxsZWQgaGlnaCB0byAxLjhWIHVubGVzcyBzb21lIGtleSBpcyBwcmVzc2VkLCBzbyB1 bnByZXNzZWQKdmFsdWUgd2lsbCBhbHdheXMgYmUgYXJvdW5kIDE4MDAgb24gYWxsIFBpbmVwaG9u ZXMsIGFuZCBwcmVzc2VkIHZhbHVlIHdpbGwKZGVwZW5kIG9uIGNvbnRhY3QgcXVhbGl0eSBhbmQg dG9sZXJhbmNlcy4gRm9yIHZvbHVtZSBkb3duLCBTQVIgQURDIGlucHV0IGlzIGZlZApmcm9tIGEg cmVzaXN0b3IgZGl2aWRlciBvZiAoMTBrT2htICsgMmtPaG0pIGZyb20gMS44ViBwb3dlciByYWls LiBTbyB0aGF0IGdpdmVzCjIvMTIqMS44ID0gMC4zVi4gV2UgY2FuJ3QgaGF2ZSB0aGUgcHJlc3Mg ZGV0ZWN0aW9uIHRocmVzaG9sZCByaWdodCBhdCB0aGlzCnZvbHRhZ2UsIGJlY2F1c2U6CgoxKSB0 aGVzZSByZXNpc3RvcnMgaGF2ZSB0b2xlcmFuY2VzIHRoYXQgd2lsbCByYW5kb21seSByZXN1bHQg aW4gbWVhc3VyZWQgdm9sdGFnZQogICBiZWluZyBhYm92ZSBvciBiZWxvdyB0aGUgMC4zViBvbiBy ZWFsIGRldmljZXMgKC0xJSBvbiAxMGsgYW5kICsxJSBvbiAyayA9CiAgIDIqMS4wMS8oMTAqMC45 OSsyKjEuMDEpKjEuOCA9IDMwNSBtViAtIGFscmVhZHkgdG9vIGhpZ2ggZXZlbiB3aXRob3V0CiAg IGNvbnNpZGVyaW5nIHN3aXRjaCBjb250YWN0IHF1YWxpdHkpLCBhbmQKCjIpIHRob3NlIHBpZGRs eSBtZW1icmFuZSBzd2l0Y2hlcyBhcHBhcmVudGx5IGhhdmUgdGhlaXIgb3duIHJhbmRvbSByZXNp c3RhbmNlCiAgIHRoYXQgaXMgYWRkZWQgdG8gdGhlIGJvdHRvbSBsZWcgb2YgdGhlIHJlc2lzdG9y IGRpdmlkZXIsIGFuZCBkZXBlbmRzIG9uCiAgIHN0cmVuZ2h0IG9mIHRoZSBwcmVzcyBvbiBzb21l IGRldmljZXMgKGFuZCBzd2l0Y2hlcyBtYXkgZGV2ZWxvcCBoaWdoZXIKICAgcmVzaXN0YW5jZSB3 aXRoIGFnZS91c2UpLgoKU2NoZW1hdGljOiBodHRwczovL21lZ291cy5jb20vZGwvdG1wLzExMjVk OTI0OGE4MjEzYjMucG5nCgpraW5kIHJlZ2FyZHMsCglvLgoKPiBUaGFua3MKPiBIZWlrbwoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2No aXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA0CAC77B70 for ; Mon, 17 Apr 2023 12:38:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q/QLwTDZSjpsoqqJu+aMtUUSGZxH85kRFL76aUu67Lg=; b=pyWg62MBuYcLDc VEDkiq/Vtbukh/Fj0tjGUBxYVxoA66PJry7Wg2oXdka582SWTf25qD06aawoQKot2KNmlsHmw8vVH XKOWHD8tJ4uZ1uNfZQhXWk4PkljGByBu295/snJr0c4wMaafaxXYtoJN6XeFRfPXod4jZCir/DfBf Y6NwfSbN66aNeY6RrZjje4mRCUKuXufTy4cQh/qNzm3330sUdiiAPXscixrP1FMArcgw3Sc5aSYFw n4EO+rpEI+RYC+ioNiGfilQMEs1DoDDK1AMIEibp2wvUc0ZMhfSy5qEwprTGCD5zRXN239zfaCxKH ZKAA1mKywEKf9ZxKO+8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1poO6q-00GA2S-0t; Mon, 17 Apr 2023 12:37:28 +0000 Received: from vps.xff.cz ([195.181.215.36]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1poO6m-00GA1B-2B; Mon, 17 Apr 2023 12:37:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1681735036; bh=gJesLtiDnccwIC0RA7jikU/NZ0vOLBaI0EL8Y7OHrAI=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=SKQOE09xi6VRiW3rlypNrv35XlLjZcT1LxzPDOJaBEQcesmiGmOqr67+WxIoTRmZu NubFRUhbrg8yv0kIQWVlY5mn1HUL+NGM34mBpLBiH7bwGgbCaOr6VPJHtxKI6UQXxS U3rc5iLWiNyqO0OKKDbwpyQBbfDzFmcyNfiYcE6s= Date: Mon, 17 Apr 2023 14:37:16 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Heiko =?utf-8?Q?St=C3=BCbner?= Cc: Peter Robinson , Rob Herring , Krzysztof Kozlowski , Tom Fitzhenry , Martijn Braam , Caleb Connolly , Jarrah Gosbell , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] arm64: dts: rk3399-pinephone-pro: Add support for volume keys Message-ID: <20230417123716.c23izju4ezjrzytn@core> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Heiko =?utf-8?Q?St=C3=BCbner?= , Peter Robinson , Rob Herring , Krzysztof Kozlowski , Tom Fitzhenry , Martijn Braam , Caleb Connolly , Jarrah Gosbell , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20230405123813.2272919-1-pbrobinson@gmail.com> <20230405135339.bcdyjdbtynuwf5yz@core> <4152389.RUnXabflUD@diego> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4152389.RUnXabflUD@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230417_053725_199151_D025CB67 X-CRM114-Status: GOOD ( 19.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gSGVpa28sCgpPbiBNb24sIEFwciAxNywgMjAyMyBhdCAxMDozNDoyMEFNICswMjAwLCBI ZWlrbyBTdMO8Ym5lciB3cm90ZToKPiBIaSBQZXRlciwgT25kcmVqLAo+IAo+IEFtIE1pdHR3b2No LCA1LiBBcHJpbCAyMDIzLCAxNTo1MzozOSBDRVNUIHNjaHJpZWIgT25kxZllaiBKaXJtYW46Cj4g PiBbLi4uXQo+ID4KPiA+IChJIGhhdmUgdG8gcHJlc3MgcXVpdGUgaGFyZCB0byBnZXQgYmVsbG93 IDMwMCBhbmQgdG8gZ2V0IHJlbGlhYmxlIGRldGVjdGlvbgo+ID4gb2Ygdm9sdW1lIGRvd24ga2V5 IHByZXNzKQo+ID4gCj4gPiBPbiBkZXZlbG9wbWVudCB2ZXJzaW9uIG9mIHRoZSBwaG9uZSwgdGhl IHZhbHVlIHJldHVybmVkIGJ5IHNhcmRhYyBpcyBsZXNzCj4gPiB2YXJpYWJsZS4gQmFzaWNhbGx5 IGVpdGhlciAyOTguODI4MTI1IG9yIDMwMC41ODU5Mzc1IGJ1dCBpdCdzIGFsc28gb24KPiA+IHRo ZSBlZGdlLgo+ID4gCj4gPiBJIHN1Z2dlc3QgcmFpc2luZyB0aGUgdGhyZXNob2xkIHRvIHNvbWV0 aGluZyBsaWtlIDYwMCBhbmQgdG8gZG8geW91ciBvd24KPiA+IHRlc3RpbmcsIHRvIGdldCBtb3Jl IGRhdGEgcG9pbnRzLiBVbnByZXNzZWQgdmFsdWUgaXMgfjE3OTEuMjEwOTM3NSBvbiBib3RoCj4g PiBwaG9uZXMsIHNvIDQwMCBzdGlsbCBnZXRzIGEgbG90IG9mIGhlYWRyb29tLiBBbmQgdm9sdW1l IHVwIGlzIGFsd2F5cyA8IDE1Cj4gPiBpbiBteSB0ZXN0cy4KPiAKPiBkaWQgdGhpcyBnZXQgbW9y ZSBhdHRlbnRpb24gbWVhbndoaWxlPwo+IAo+IEkgZG9uJ3QgaGF2ZSBhIFBpbmVwaG9uZSBQcm8g bXlzZWxmLCBzbyB5b3UnbGwgbmVlZCB0byBkZWNpZGUgYmV0d2VlbiB5b3UKPiBhYm91dCB0aGUg dmFsdWUgYW5kIHRoZSBjb25jZXJuIE9uZHJlaiByYWlzZWQgaGVyZSBmb3IgdGhlIHZhbHVlLgoK SXQncyBzYWZlIGFuZCBuZWVkZWQgdG8gdXNlIGEgaGlnaGVyIHZhbHVlLgoKU0FSIEFEQyBpbnB1 dCBpcyBwdWxsZWQgaGlnaCB0byAxLjhWIHVubGVzcyBzb21lIGtleSBpcyBwcmVzc2VkLCBzbyB1 bnByZXNzZWQKdmFsdWUgd2lsbCBhbHdheXMgYmUgYXJvdW5kIDE4MDAgb24gYWxsIFBpbmVwaG9u ZXMsIGFuZCBwcmVzc2VkIHZhbHVlIHdpbGwKZGVwZW5kIG9uIGNvbnRhY3QgcXVhbGl0eSBhbmQg dG9sZXJhbmNlcy4gRm9yIHZvbHVtZSBkb3duLCBTQVIgQURDIGlucHV0IGlzIGZlZApmcm9tIGEg cmVzaXN0b3IgZGl2aWRlciBvZiAoMTBrT2htICsgMmtPaG0pIGZyb20gMS44ViBwb3dlciByYWls LiBTbyB0aGF0IGdpdmVzCjIvMTIqMS44ID0gMC4zVi4gV2UgY2FuJ3QgaGF2ZSB0aGUgcHJlc3Mg ZGV0ZWN0aW9uIHRocmVzaG9sZCByaWdodCBhdCB0aGlzCnZvbHRhZ2UsIGJlY2F1c2U6CgoxKSB0 aGVzZSByZXNpc3RvcnMgaGF2ZSB0b2xlcmFuY2VzIHRoYXQgd2lsbCByYW5kb21seSByZXN1bHQg aW4gbWVhc3VyZWQgdm9sdGFnZQogICBiZWluZyBhYm92ZSBvciBiZWxvdyB0aGUgMC4zViBvbiBy ZWFsIGRldmljZXMgKC0xJSBvbiAxMGsgYW5kICsxJSBvbiAyayA9CiAgIDIqMS4wMS8oMTAqMC45 OSsyKjEuMDEpKjEuOCA9IDMwNSBtViAtIGFscmVhZHkgdG9vIGhpZ2ggZXZlbiB3aXRob3V0CiAg IGNvbnNpZGVyaW5nIHN3aXRjaCBjb250YWN0IHF1YWxpdHkpLCBhbmQKCjIpIHRob3NlIHBpZGRs eSBtZW1icmFuZSBzd2l0Y2hlcyBhcHBhcmVudGx5IGhhdmUgdGhlaXIgb3duIHJhbmRvbSByZXNp c3RhbmNlCiAgIHRoYXQgaXMgYWRkZWQgdG8gdGhlIGJvdHRvbSBsZWcgb2YgdGhlIHJlc2lzdG9y IGRpdmlkZXIsIGFuZCBkZXBlbmRzIG9uCiAgIHN0cmVuZ2h0IG9mIHRoZSBwcmVzcyBvbiBzb21l IGRldmljZXMgKGFuZCBzd2l0Y2hlcyBtYXkgZGV2ZWxvcCBoaWdoZXIKICAgcmVzaXN0YW5jZSB3 aXRoIGFnZS91c2UpLgoKU2NoZW1hdGljOiBodHRwczovL21lZ291cy5jb20vZGwvdG1wLzExMjVk OTI0OGE4MjEzYjMucG5nCgpraW5kIHJlZ2FyZHMsCglvLgoKPiBUaGFua3MKPiBIZWlrbwoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D6FAC77B70 for ; Mon, 17 Apr 2023 12:38:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229988AbjDQMiB (ORCPT ); Mon, 17 Apr 2023 08:38:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbjDQMiA (ORCPT ); Mon, 17 Apr 2023 08:38:00 -0400 Received: from vps.xff.cz (vps.xff.cz [195.181.215.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 554BB46AF for ; Mon, 17 Apr 2023 05:37:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1681735036; bh=gJesLtiDnccwIC0RA7jikU/NZ0vOLBaI0EL8Y7OHrAI=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=SKQOE09xi6VRiW3rlypNrv35XlLjZcT1LxzPDOJaBEQcesmiGmOqr67+WxIoTRmZu NubFRUhbrg8yv0kIQWVlY5mn1HUL+NGM34mBpLBiH7bwGgbCaOr6VPJHtxKI6UQXxS U3rc5iLWiNyqO0OKKDbwpyQBbfDzFmcyNfiYcE6s= Date: Mon, 17 Apr 2023 14:37:16 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Heiko =?utf-8?Q?St=C3=BCbner?= Cc: Peter Robinson , Rob Herring , Krzysztof Kozlowski , Tom Fitzhenry , Martijn Braam , Caleb Connolly , Jarrah Gosbell , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] arm64: dts: rk3399-pinephone-pro: Add support for volume keys Message-ID: <20230417123716.c23izju4ezjrzytn@core> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Heiko =?utf-8?Q?St=C3=BCbner?= , Peter Robinson , Rob Herring , Krzysztof Kozlowski , Tom Fitzhenry , Martijn Braam , Caleb Connolly , Jarrah Gosbell , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20230405123813.2272919-1-pbrobinson@gmail.com> <20230405135339.bcdyjdbtynuwf5yz@core> <4152389.RUnXabflUD@diego> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4152389.RUnXabflUD@diego> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello Heiko, On Mon, Apr 17, 2023 at 10:34:20AM +0200, Heiko Stübner wrote: > Hi Peter, Ondrej, > > Am Mittwoch, 5. April 2023, 15:53:39 CEST schrieb Ondřej Jirman: > > [...] > > > > (I have to press quite hard to get bellow 300 and to get reliable detection > > of volume down key press) > > > > On development version of the phone, the value returned by sardac is less > > variable. Basically either 298.828125 or 300.5859375 but it's also on > > the edge. > > > > I suggest raising the threshold to something like 600 and to do your own > > testing, to get more data points. Unpressed value is ~1791.2109375 on both > > phones, so 400 still gets a lot of headroom. And volume up is always < 15 > > in my tests. > > did this get more attention meanwhile? > > I don't have a Pinephone Pro myself, so you'll need to decide between you > about the value and the concern Ondrej raised here for the value. It's safe and needed to use a higher value. SAR ADC input is pulled high to 1.8V unless some key is pressed, so unpressed value will always be around 1800 on all Pinephones, and pressed value will depend on contact quality and tolerances. For volume down, SAR ADC input is fed from a resistor divider of (10kOhm + 2kOhm) from 1.8V power rail. So that gives 2/12*1.8 = 0.3V. We can't have the press detection threshold right at this voltage, because: 1) these resistors have tolerances that will randomly result in measured voltage being above or below the 0.3V on real devices (-1% on 10k and +1% on 2k = 2*1.01/(10*0.99+2*1.01)*1.8 = 305 mV - already too high even without considering switch contact quality), and 2) those piddly membrane switches apparently have their own random resistance that is added to the bottom leg of the resistor divider, and depends on strenght of the press on some devices (and switches may develop higher resistance with age/use). Schematic: https://megous.com/dl/tmp/1125d9248a8213b3.png kind regards, o. > Thanks > Heiko