From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 192ECC77B7A for ; Mon, 17 Apr 2023 16:09:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1805686003; Mon, 17 Apr 2023 18:09:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=metanate.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=metanate.com header.i=@metanate.com header.b="WiVOiO/E"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6138186005; Mon, 17 Apr 2023 18:09:44 +0200 (CEST) Received: from metanate.com (unknown [IPv6:2001:8b0:1628:5005::111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8619785FD4 for ; Mon, 17 Apr 2023 18:09:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=metanate.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=john@metanate.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metanate.com; s=stronger; h=Content-Transfer-Encoding:Message-Id:Date: Subject:Cc:To:From:Content-Type:Reply-To:Content-ID:Content-Description: In-Reply-To:References; bh=EKqixDRPA6G6ZNZuVe94vDiAGXtvseu5ywLItNxjH6I=; b=Wi VOiO/EEoZdH9ze9I+magOa7HnzIoRuqedzsbONJHTcEdrr+pA2sHuHkkjlStqxNJCIlYI841fPVUI i3P6MZvoe7WrOGC900kyt3ovrHI5DMc84OWwhgoRcm5GaWb34oY7qW2TxCrqRcTTsvkeBBdypZREE 5cyj52QhMHnHhCSZ1hwLg+LXiCWw0acq5myNDYuegoJ/iYggfS44aQ8vWulb5NF4pnRnXeaM7wziT WbRhcWnrHGUciJL5rkNae+Kv0sr5AeJkHEtNiPY1gdoKGwlLOtSc4rrI3zLTOF+2YhVC2SfwzBnMo o1JwBQpYH/g1O8l0TIgzQRHaX16Gd/Tg==; Received: from [81.174.171.191] (helo=donbot.metanate.com) by email.metanate.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1poRQ5-0000vM-MB; Mon, 17 Apr 2023 17:09:34 +0100 From: John Keeping To: u-boot@lists.denx.de Cc: John Keeping , Simon Glass , Philipp Tomsich , Kever Yang Subject: [PATCH] rockchip: efuse: fix rk3399 reading multiple values Date: Mon, 17 Apr 2023 17:09:14 +0100 Message-Id: <20230417160914.2838607-1-john@metanate.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authenticated: YES X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Update rk3399 to match the pattern in the other device-specific implementations to ensure the previous address is cleared when reading multiple blocks. Signed-off-by: John Keeping --- drivers/misc/rockchip-efuse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/rockchip-efuse.c b/drivers/misc/rockchip-efuse.c index 2f96b79ea4..d302271239 100644 --- a/drivers/misc/rockchip-efuse.c +++ b/drivers/misc/rockchip-efuse.c @@ -207,8 +207,8 @@ static int rockchip_rk3399_efuse_read(struct udevice *dev, int offset, udelay(1); while (size--) { - setbits_le32(efuse->base + EFUSE_CTRL, - EFUSE_STROBE | RK3399_ADDR(offset++)); + clrsetbits_le32(efuse->base + EFUSE_CTRL, RK3399_A_MASK, + EFUSE_STROBE | RK3399_ADDR(offset++)); udelay(1); *buffer++ = readl(efuse->base + EFUSE_DOUT); clrbits_le32(efuse->base + EFUSE_CTRL, EFUSE_STROBE); -- 2.40.0