From: Arnd Bergmann <arnd@kernel.org>
To: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Saurabh Sengar <ssengar@linux.microsoft.com>,
Michael Kelley <mikelley@microsoft.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] net: hyperv: select CONFIG_NLS for mac address setting
Date: Mon, 17 Apr 2023 22:55:48 +0200 [thread overview]
Message-ID: <20230417205553.1910749-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
A rare randconfig build error happens when this driver is
enabled, but nothing else enables NLS support:
x86_64-linux-ld: drivers/net/hyperv/rndis_filter.o: in function `rndis_filter_set_device_mac':
rndis_filter.c:(.text+0x1536): undefined reference to `utf8s_to_utf16s'
This is normally selected by PCI, USB, ACPI, or common file systems.
Since the dependency on ACPI is now gone, NLS has to be selected
here directly.
Fixes: 38299f300c12 ("Driver: VMBus: Add Devicetree support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/hyperv/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/hyperv/Kconfig b/drivers/net/hyperv/Kconfig
index ca7bf7f897d3..924dad26ad47 100644
--- a/drivers/net/hyperv/Kconfig
+++ b/drivers/net/hyperv/Kconfig
@@ -2,6 +2,7 @@
config HYPERV_NET
tristate "Microsoft Hyper-V virtual network driver"
depends on HYPERV
+ select NLS
select UCS2_STRING
help
Select this option to enable the Hyper-V virtual network driver.
--
2.39.2
next reply other threads:[~2023-04-17 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 20:55 Arnd Bergmann [this message]
2023-04-19 3:54 ` [PATCH] net: hyperv: select CONFIG_NLS for mac address setting Jakub Kicinski
2023-04-19 19:25 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230417205553.1910749-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ssengar@linux.microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.