From: Jakub Kicinski <kuba@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
netdev@vger.kernel.org, "Björn Töpel" <bjorn@kernel.org>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
bpf@vger.kernel.org, virtualization@lists.linux-foundation.org,
"Michael S. Tsirkin" <mst@redhat.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jens Axboe" <axboe@kernel.dk>,
"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: [PATCH net-next] xsk: introduce xsk_dma_ops
Date: Mon, 17 Apr 2023 23:19:47 -0700 [thread overview]
Message-ID: <20230417231947.3972f1a8@kernel.org> (raw)
In-Reply-To: <ZD4kMOym15pFcjq+@infradead.org>
On Mon, 17 Apr 2023 22:01:36 -0700 Christoph Hellwig wrote:
> On Mon, Apr 17, 2023 at 07:54:00PM -0700, Jakub Kicinski wrote:
> > AF_XDP, io_uring, and increasing number of pinned memory / zero copy
> > implementations need to do DMA mapping outside the drivers.
>
> You can't just do dma mapping outside the driver, because there are
> drivers that do not require DMA mapping at all. virtio is an example,
> but all the classic s390 drivers and some other odd virtualization
> ones are others.
What bus are the classic s390 on (in terms of the device model)?
> > I don't think it's reasonable to be bubbling up custom per-subsystem
> > DMA ops into all of them for the sake of virtio.
>
> dma addresses and thus dma mappings are completely driver specific.
> Upper layers have no business looking at them.
Damn, that's unfortunate. Thinking aloud -- that means that if we want
to continue to pull memory management out of networking drivers to
improve it for all, cross-optimize with the rest of the stack and
allow various upcoming forms of zero copy -- then we need to add an
equivalent of dma_ops and DMA API locally in networking?
next prev parent reply other threads:[~2023-04-18 6:19 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 3:27 [PATCH net-next] xsk: introduce xsk_dma_ops Xuan Zhuo
2023-04-17 3:27 ` Xuan Zhuo
2023-04-17 4:24 ` Christoph Hellwig
2023-04-17 4:24 ` Christoph Hellwig
2023-04-17 5:58 ` Xuan Zhuo
2023-04-17 5:58 ` Xuan Zhuo
2023-04-17 18:56 ` Jakub Kicinski
2023-04-17 18:57 ` Jakub Kicinski
2023-04-18 1:07 ` Jason Wang
2023-04-18 1:07 ` Jason Wang
2023-04-18 1:19 ` Jakub Kicinski
2023-04-18 2:19 ` Xuan Zhuo
2023-04-18 2:19 ` Xuan Zhuo
2023-04-18 2:54 ` Jakub Kicinski
2023-04-18 5:01 ` Christoph Hellwig
2023-04-18 5:01 ` Christoph Hellwig
2023-04-18 6:19 ` Jakub Kicinski [this message]
2023-04-19 5:16 ` Christoph Hellwig
2023-04-19 5:16 ` Christoph Hellwig
2023-04-19 13:14 ` Alexander Lobakin
2023-04-19 13:40 ` Xuan Zhuo
2023-04-19 13:40 ` Xuan Zhuo
2023-04-20 6:16 ` Christoph Hellwig
2023-04-20 6:16 ` Christoph Hellwig
2023-04-20 13:59 ` Alexander Lobakin
2023-04-20 16:15 ` Christoph Hellwig
2023-04-20 16:15 ` Christoph Hellwig
2023-04-20 16:42 ` Alexander Lobakin
2023-05-01 4:28 ` Christoph Hellwig
2023-05-01 4:28 ` Christoph Hellwig
2023-04-19 16:45 ` Jakub Kicinski
2023-04-20 6:19 ` Christoph Hellwig
2023-04-20 6:19 ` Christoph Hellwig
2023-04-20 9:11 ` Xuan Zhuo
2023-04-20 9:11 ` Xuan Zhuo
2023-04-20 16:18 ` Christoph Hellwig
2023-04-20 16:18 ` Christoph Hellwig
2023-04-25 8:12 ` Michael S. Tsirkin
2023-04-25 8:12 ` Michael S. Tsirkin
2023-05-01 4:16 ` Christoph Hellwig
2023-05-01 4:16 ` Christoph Hellwig
2023-04-20 14:13 ` Jakub Kicinski
2023-04-21 7:31 ` Xuan Zhuo
2023-04-21 7:31 ` Xuan Zhuo
2023-04-21 13:50 ` Jakub Kicinski
2023-04-23 1:54 ` Xuan Zhuo
2023-04-23 1:54 ` Xuan Zhuo
2023-04-24 15:28 ` Jakub Kicinski
2023-04-24 15:28 ` Alexander Lobakin
2023-04-25 2:11 ` Xuan Zhuo
2023-04-25 2:11 ` Xuan Zhuo
2023-04-18 2:15 ` Xuan Zhuo
2023-04-18 2:15 ` Xuan Zhuo
2023-04-17 6:38 ` kernel test robot
2023-04-17 6:38 ` kernel test robot
2023-04-17 6:43 ` Michael S. Tsirkin
2023-04-17 6:43 ` Michael S. Tsirkin
2023-04-17 6:48 ` Xuan Zhuo
2023-04-17 6:48 ` Xuan Zhuo
2023-04-17 6:48 ` kernel test robot
2023-04-17 6:48 ` kernel test robot
2023-04-19 13:22 ` Alexander Lobakin
2023-04-19 13:42 ` Xuan Zhuo
2023-04-19 13:42 ` Xuan Zhuo
2023-04-20 6:12 ` Christoph Hellwig
2023-04-20 6:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230417231947.3972f1a8@kernel.org \
--to=kuba@kernel.org \
--cc=ast@kernel.org \
--cc=axboe@kernel.dk \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hawk@kernel.org \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kraxel@redhat.com \
--cc=linux@roeck-us.net \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.