From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 264E4C77B72 for ; Tue, 18 Apr 2023 00:51:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbjDRAvO (ORCPT ); Mon, 17 Apr 2023 20:51:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbjDRAvN (ORCPT ); Mon, 17 Apr 2023 20:51:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF9F52D47 for ; Mon, 17 Apr 2023 17:51:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5363A62904 for ; Tue, 18 Apr 2023 00:51:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB111C433D2; Tue, 18 Apr 2023 00:51:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1681779071; bh=conUkZDL/4CTF568Rao8lWTyF1/CNeFz73qa3jDnVKM=; h=Date:To:From:Subject:From; b=y1LqjDDNJaB4VmDh+Im1WA3xvo7Km3SlD8BBEbvdw/zhRLLrs2o3/VM+r0c4rSi2l FVf/DlStt7svO9Ob8fDW6TFe7xRFYADNzO5Jfqp+sws+LyZHkMqW1W0gS5ohqTxp4Q RHMN/+nIKBL12Xj37l7Jw/6vajQv7Ts+DMn3oklc= Date: Mon, 17 Apr 2023 17:51:10 -0700 To: mm-commits@vger.kernel.org, willy@infradead.org, viro@zeniv.linux.org.uk, mcgrof@kernel.org, hare@suse.de, brauner@kernel.org, p.raghav@samsung.com, akpm@linux-foundation.org From: Andrew Morton Subject: + fs-buffer-add-folio_set_bh-helper.patch added to mm-unstable branch Message-Id: <20230418005111.AB111C433D2@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: fs/buffer: add folio_set_bh helper has been added to the -mm mm-unstable branch. Its filename is fs-buffer-add-folio_set_bh-helper.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/fs-buffer-add-folio_set_bh-helper.patch This patch will later appear in the mm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Pankaj Raghav Subject: fs/buffer: add folio_set_bh helper Date: Mon, 17 Apr 2023 14:36:15 +0200 Patch series "convert create_page_buffers to folio_create_buffers". One of the first kernel panic we hit when we try to increase the block size > 4k is inside create_page_buffers()[1]. Even though buffer.c function do not support large folios (folios > PAGE_SIZE) at the moment, these changes are required when we want to remove that constraint. This patch (of 4): The folio version of set_bh_page(). This is required to convert create_page_buffers() to folio_create_buffers() later in the series. Link: https://lkml.kernel.org/r/20230417123618.22094-1-p.raghav@samsung.com Link: https://lkml.kernel.org/r/20230417123618.22094-2-p.raghav@samsung.com Signed-off-by: Pankaj Raghav Reviewed-by: Matthew Wilcox (Oracle) Reviewed-by: Hannes Reinecke Cc: Alexander Viro Cc: Christian Brauner Cc: Luis Chamberlain Signed-off-by: Andrew Morton --- fs/buffer.c | 15 +++++++++++++++ include/linux/buffer_head.h | 2 ++ 2 files changed, 17 insertions(+) --- a/fs/buffer.c~fs-buffer-add-folio_set_bh-helper +++ a/fs/buffer.c @@ -1485,6 +1485,21 @@ void set_bh_page(struct buffer_head *bh, } EXPORT_SYMBOL(set_bh_page); +void folio_set_bh(struct buffer_head *bh, struct folio *folio, + unsigned long offset) +{ + bh->b_folio = folio; + BUG_ON(offset >= folio_size(folio)); + if (folio_test_highmem(folio)) + /* + * This catches illegal uses and preserves the offset: + */ + bh->b_data = (char *)(0 + offset); + else + bh->b_data = folio_address(folio) + offset; +} +EXPORT_SYMBOL(folio_set_bh); + /* * Called when truncating a buffer on a page completely. */ --- a/include/linux/buffer_head.h~fs-buffer-add-folio_set_bh-helper +++ a/include/linux/buffer_head.h @@ -196,6 +196,8 @@ void mark_buffer_write_io_error(struct b void touch_buffer(struct buffer_head *bh); void set_bh_page(struct buffer_head *bh, struct page *page, unsigned long offset); +void folio_set_bh(struct buffer_head *bh, struct folio *folio, + unsigned long offset); bool try_to_free_buffers(struct folio *); struct buffer_head *alloc_page_buffers(struct page *page, unsigned long size, bool retry); _ Patches currently in -mm which might be from p.raghav@samsung.com are orangefs-use-folios-in-orangefs_readahead.patch mpage-split-submit_bio-and-bio-end_io-handler-for-reads-and-writes.patch mpage-use-folios-in-bio-end_io-handler.patch fs-buffer-add-folio_set_bh-helper.patch buffer-add-folio_alloc_buffers-helper.patch fs-buffer-add-folio_create_empty_buffers-helper.patch fs-buffer-convert-create_page_buffers-to-folio_create_buffers.patch