From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Avri Altman <avri.altman@wdc.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-scsi@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Ming Lei <ming.lei@redhat.com>, Hannes Reinecke <hare@suse.de>,
Mike Christie <michael.christie@oracle.com>,
Tomas Henzl <thenzl@redhat.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: Re: [PATCH v2 1/4] scsi: sd: Let sd_shutdown() fail future I/O
Date: Tue, 18 Apr 2023 07:06:37 +0200 [thread overview]
Message-ID: <20230418050637.GA29686@lst.de> (raw)
In-Reply-To: <20230417230656.523826-2-bvanassche@acm.org>
On Mon, Apr 17, 2023 at 04:06:53PM -0700, Bart Van Assche wrote:
> +fail_future_io:
> + q = sdkp->disk->queue;
> + blk_queue_flag_set(QUEUE_FLAG_DYING, q);
SD does not own the queue and has abslutely not business marking it
dying.
next prev parent reply other threads:[~2023-04-18 5:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 23:06 [PATCH v2 0/4] SCSI core and UFS patches for kernel v6.4 Bart Van Assche
2023-04-17 23:06 ` [PATCH v2 1/4] scsi: sd: Let sd_shutdown() fail future I/O Bart Van Assche
2023-04-18 4:37 ` Ming Lei
2023-04-18 14:09 ` Bart Van Assche
2023-04-18 5:06 ` Christoph Hellwig [this message]
2023-04-18 14:36 ` James Bottomley
2023-04-18 18:37 ` Bart Van Assche
2023-04-19 2:34 ` James Bottomley
2023-04-19 13:36 ` Tomas Henzl
2023-04-19 14:02 ` James Bottomley
2023-04-19 17:58 ` Bart Van Assche
2023-04-19 18:33 ` James Bottomley
2023-04-19 19:24 ` Bart Van Assche
2023-04-19 19:29 ` James Bottomley
2023-04-17 23:06 ` [PATCH v2 2/4] scsi: ufs: Simplify ufshcd_wl_shutdown() Bart Van Assche
2023-04-18 13:45 ` Adrian Hunter
2023-04-18 14:06 ` Bart Van Assche
2023-04-18 14:13 ` Adrian Hunter
2023-04-18 20:14 ` Bart Van Assche
2023-04-19 5:23 ` Adrian Hunter
2023-04-17 23:06 ` [PATCH v2 3/4] scsi: ufs: Increase the START STOP UNIT timeout from one to ten seconds Bart Van Assche
2023-04-18 7:30 ` Adrian Hunter
2023-04-18 7:57 ` Stanley Chu
2023-04-17 23:06 ` [PATCH v2 4/4] scsi: ufs: Fix handling of lrbp->cmd Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418050637.GA29686@lst.de \
--to=hch@lst.de \
--cc=adrian.hunter@intel.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=ming.lei@redhat.com \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.