From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>, Davide Caratti <dcaratti@redhat.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Christoph Paasch <cpaasch@apple.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net] net/sched: sch_fq: fix integer overflow of "credit"
Date: Tue, 18 Apr 2023 07:43:33 -0700 [thread overview]
Message-ID: <20230418074333.7d084348@kernel.org> (raw)
In-Reply-To: <CANn89iJ0zy6rr4=O3328heYgiBHNcc9hmAHweTFvAW7iZi8QFw@mail.gmail.com>
On Tue, 18 Apr 2023 12:26:13 +0200 Eric Dumazet wrote:
> > Please set the right policy in fq_policy[] instead.
>
> Not sure these policies are available for old kernels (sch_fq was
> added in linux-3.12) ?
>
> Or have we backported all this infra already on stable kernels ?
>
> commit d06a09b94c618c96ced584dd4611a888c8856b8d
> Author: Johannes Berg <johannes.berg@intel.com>
> Date: Thu Apr 30 22:13:08 2020 +0200
>
> netlink: extend policy range validation
Good point, Davide, once the policy based fix hits the trees please
send this version of the fix to stable@ for 5.4 and older stable trees.
next prev parent reply other threads:[~2023-04-18 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 11:02 [PATCH net] net/sched: sch_fq: fix integer overflow of "credit" Davide Caratti
2023-04-17 11:16 ` Eric Dumazet
2023-04-18 2:30 ` Jakub Kicinski
2023-04-18 10:26 ` Eric Dumazet
2023-04-18 14:43 ` Jakub Kicinski [this message]
2023-04-18 15:03 ` Davide Caratti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418074333.7d084348@kernel.org \
--to=kuba@kernel.org \
--cc=cpaasch@apple.com \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.