From: Tony Lindgren <tony@atomide.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Johan Hovold <johan@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-omap@vger.kernel.org,
linux-serial <linux-serial@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: 8250: Clear port->pm on port specific driver unbind
Date: Tue, 18 Apr 2023 12:41:23 +0300 [thread overview]
Message-ID: <20230418094123.GA14287@atomide.com> (raw)
In-Reply-To: <20230414094035.GF36234@atomide.com>
* Tony Lindgren <tony@atomide.com> [230414 09:40]:
> I'm now wondering still if we should clear all the conditional hardware
> specific functions too in addition to port->pm that get set in
> serial8250_register_8250_port(). Maybe best done in a separate patch
> as needed.. Any suggestions?
Well we can't do memset on the port for sure at this point.. But what
we can do is call serial8250_set_defaults() instead of clearing just
port->pm. This will set the port back to serial8250 default functions,
and will set port->pm too.
I'll send v2 patch after some more testing.
Regards,
Tony
prev parent reply other threads:[~2023-04-18 9:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 7:03 [PATCH] serial: 8250: Clear port->pm on port specific driver unbind Tony Lindgren
2023-04-13 16:06 ` Andy Shevchenko
2023-04-14 5:47 ` Tony Lindgren
2023-04-14 7:35 ` Ilpo Järvinen
2023-04-14 9:40 ` Tony Lindgren
2023-04-18 9:41 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418094123.GA14287@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.