From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: tee.min.tan@linux.intel.com, intel-wired-lan@osuosl.org,
jesse.brandeburg@intel.com
Subject: Re: [Intel-wired-lan] [PATCH net-next v2] igc: Add TransmissionOverrun counter
Date: Tue, 18 Apr 2023 17:19:04 -0700 [thread overview]
Message-ID: <20230418171904.2d01642c@kernel.org> (raw)
In-Reply-To: <84acb1a0-f51b-cd2d-d42c-5133767a6698@intel.com>
On Tue, 18 Apr 2023 16:51:17 -0700 Tony Nguyen wrote:
> On 4/10/2023 10:55 PM, Muhammad Husaini Zulkifli wrote:
> > Add TransmissionOverrun as defined by IEEE Std 802.1Q.
> > TransmissionOverrun counter shall be incremented if the implementation
> > detects that a frame from a given queue is still being transmitted by
> > the MAC when that gate-close event for that queue occurs.
> >
> > This counter is utilised by the Certification conformance test to
> > inform the user application whether any packets are currently being
> > transmitted on a particular queue during a gate-close event.
> >
> > Intel Discrete I225/I226 have a mechanism to not transmit a packets if
> > the gate open time is insufficient for the packet transmission by setting
> > the Strict_End bit. Thus, it is expected for this counter to be always
> > zero at this moment.
>
> This still nets to adding driver statistics that always reports 0. My
> initial reaction is since it's an IEEE stat and part of a certification
> test, it should go higher than driver level since other drivers running
> the test would need the same statistic? However, I'm not sure how that
> fits in since you're adding per-queue tracking.
>
> Also, not a fan of the camel case naming.
>
> Jakub - are you ok with this 0 driver stat or did you have a thought of
> where you'd like to see it?
Seems like something that should be reported back to the qdisc which
configured the gate.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-04-19 0:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 5:55 [Intel-wired-lan] [PATCH net-next v2] igc: Add TransmissionOverrun counter Muhammad Husaini Zulkifli
2023-04-18 23:51 ` Tony Nguyen
2023-04-19 0:19 ` Jakub Kicinski [this message]
2023-05-02 1:47 ` Zulkifli, Muhammad Husaini
2023-05-02 15:27 ` Jakub Kicinski
2023-05-28 10:10 ` Zulkifli, Muhammad Husaini
2023-05-29 13:59 ` Vladimir Oltean
2023-05-29 17:33 ` Vladimir Oltean
2023-05-30 2:08 ` Jakub Kicinski
2023-05-30 2:56 ` Zulkifli, Muhammad Husaini
2023-05-30 8:31 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418171904.2d01642c@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=tee.min.tan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.