From: Jakub Kicinski <kuba@kernel.org>
To: Emeel Hakim <ehakim@nvidia.com>
Cc: <davem@davemloft.net>, <pabeni@redhat.com>, <edumazet@google.com>,
<sd@queasysnail.net>, <netdev@vger.kernel.org>, <leon@kernel.org>
Subject: Re: [PATCH net-next v6 3/5] net/mlx5: Support MACsec over VLAN
Date: Tue, 18 Apr 2023 17:36:03 -0700 [thread overview]
Message-ID: <20230418173603.5b41e2e0@kernel.org> (raw)
In-Reply-To: <20230418083102.14326-4-ehakim@nvidia.com>
On Tue, 18 Apr 2023 11:31:00 +0300 Emeel Hakim wrote:
> +static inline struct mlx5e_priv *macsec_netdev_priv(const struct net_device *dev)
Does the compiler really not inline this without the explicit inline
keyword?
> +{
> +#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
That's what IS_ENABLED() is for
> + if (is_vlan_dev(dev))
> + return netdev_priv(vlan_dev_priv(dev)->real_dev);
> +#endif
> + return netdev_priv(dev);
> +}
--
pw-bot: cr
next prev parent reply other threads:[~2023-04-19 0:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 8:30 [PATCH net-next v6 0/5] Support MACsec VLAN Emeel Hakim
2023-04-18 8:30 ` [PATCH net-next v6 1/5] vlan: Add MACsec offload operations for VLAN interface Emeel Hakim
2023-04-18 8:30 ` [PATCH net-next v6 2/5] net/mlx5: Enable MACsec offload feature " Emeel Hakim
2023-04-18 8:31 ` [PATCH net-next v6 3/5] net/mlx5: Support MACsec over VLAN Emeel Hakim
2023-04-19 0:36 ` Jakub Kicinski [this message]
2023-04-19 8:03 ` Emeel Hakim
2023-04-18 8:31 ` [PATCH net-next v6 4/5] net/mlx5: Consider VLAN interface in MACsec TX steering rules Emeel Hakim
2023-04-18 8:31 ` [PATCH net-next v6 5/5] macsec: Don't rely solely on the dst MAC address to identify destination MACsec device Emeel Hakim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418173603.5b41e2e0@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ehakim@nvidia.com \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.