From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16F3AC77B73 for ; Wed, 19 Apr 2023 04:27:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231654AbjDSE1v (ORCPT ); Wed, 19 Apr 2023 00:27:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230211AbjDSE1u (ORCPT ); Wed, 19 Apr 2023 00:27:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0D9961A7; Tue, 18 Apr 2023 21:27:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4EFD262F3A; Wed, 19 Apr 2023 04:27:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84120C433EF; Wed, 19 Apr 2023 04:27:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681878468; bh=z8Cnl+y8ZhRaFWwRA/tNVWmuFrnUGtE2tQkn1vH03MQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fkdNpsYCFIgLsxaPwHhk+tlApLi0x3z8fn+/RXy3qBRrG8HKTZez0cdG9Q4Tn/zqW pbDuIK7Da13J3SVPnzCq8RxZzzgxK+kf8tZ6dWxM2DMVeSgbb65dPl/5IMaYQFO5JA KP50dxYOK1RDFKc0Y7gZPql9cVf/tMGsfCEMPbyLZOu0DQ2ZHSzYxU2sddWHCPbQOl zzZoCJi5Or1D/qjAUeytjnOtePKUobrfvCVhfdaLSJqEHKsy3omA7a3/vShF6y/rwu WrvBO1Cz20shBfjEi4kU67X8yeUUEdEMLA6ULoUN2Ez2V/Qs3xPheEqlSS5fpqZr8Q bSFubUXxlgcKA== Date: Tue, 18 Apr 2023 21:27:46 -0700 From: Jakub Kicinski To: Christian Marangi Cc: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Jonathan Corbet , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , Pavel Machek , Lee Jones , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [net-next PATCH v7 00/16] net: Add basic LED support for switch/phy Message-ID: <20230418212746.7db8096e@kernel.org> In-Reply-To: <20230417151738.19426-1-ansuelsmth@gmail.com> References: <20230417151738.19426-1-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, 17 Apr 2023 17:17:22 +0200 Christian Marangi wrote: > This is a continue of [1]. It was decided to take a more gradual > approach to implement LEDs support for switch and phy starting with > basic support and then implementing the hw control part when we have all > the prereq done. > > This series implements only the brightness_set() and blink_set() ops. > An example of switch implementation is done with qca8k. > > For PHY a more generic approach is used with implementing the LED > support in PHY core and with the user (in this case marvell) adding all > the required functions. > > Currently we set the default-state as "keep" to not change the default > configuration of the declared LEDs since almost every switch have a > default configuration. IIRC we were supposed to take these via netdev with acks from Pavel/Lee. So we need acks on patches 4/5/16 ? If there is a repost, could you take out the arch/arm patches? They should not go via netdev, we'll try to filter them out when applying but mistakes happen. -- pw-bot: need-ack From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAF04C6FD18 for ; Wed, 19 Apr 2023 04:28:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pjvdvCxO9tTgjOJIvBnNGQ5104ZZQwZizvVZFeJ6768=; b=Cd4xpF7DhgHFEf A/SbAnKDQrSQA78v+o55Kj/o6nNWkOXs94vnvtFuiR7dB2GV0bHtZ9xjkih6dhu+IsY2VLnaXWW5D eYEblq/kT9InGd5+qwhNzBFa14GOFYPHMjuywtqZn6qbWnyNnTyLVNgK1Qr7uZry0Hrxha6cVxRc/ HhToJLXTZjegxhVIFRek9Nd76kJCn8uIp/XWJOS5jGWRUtQs4C2ykcMhL2gky33/4DNKkBtafVm7I fYOhoqpPYZMotPLziE3wcu0ddxqWmDLPt5UYbkSGDznlsg3JAhdDkCE7vR/KsU9xEX4F1AJkm4f9A o8yU8OcUD1Ye6L6OOOXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pozQB-00412F-1z; Wed, 19 Apr 2023 04:27:55 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pozQ8-00410z-0s for linux-arm-kernel@lists.infradead.org; Wed, 19 Apr 2023 04:27:53 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5382063AE8; Wed, 19 Apr 2023 04:27:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84120C433EF; Wed, 19 Apr 2023 04:27:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681878468; bh=z8Cnl+y8ZhRaFWwRA/tNVWmuFrnUGtE2tQkn1vH03MQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fkdNpsYCFIgLsxaPwHhk+tlApLi0x3z8fn+/RXy3qBRrG8HKTZez0cdG9Q4Tn/zqW pbDuIK7Da13J3SVPnzCq8RxZzzgxK+kf8tZ6dWxM2DMVeSgbb65dPl/5IMaYQFO5JA KP50dxYOK1RDFKc0Y7gZPql9cVf/tMGsfCEMPbyLZOu0DQ2ZHSzYxU2sddWHCPbQOl zzZoCJi5Or1D/qjAUeytjnOtePKUobrfvCVhfdaLSJqEHKsy3omA7a3/vShF6y/rwu WrvBO1Cz20shBfjEi4kU67X8yeUUEdEMLA6ULoUN2Ez2V/Qs3xPheEqlSS5fpqZr8Q bSFubUXxlgcKA== Date: Tue, 18 Apr 2023 21:27:46 -0700 From: Jakub Kicinski To: Christian Marangi Cc: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Jonathan Corbet , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , Pavel Machek , Lee Jones , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [net-next PATCH v7 00/16] net: Add basic LED support for switch/phy Message-ID: <20230418212746.7db8096e@kernel.org> In-Reply-To: <20230417151738.19426-1-ansuelsmth@gmail.com> References: <20230417151738.19426-1-ansuelsmth@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230418_212752_372711_DE50CBD9 X-CRM114-Status: GOOD ( 18.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 17 Apr 2023 17:17:22 +0200 Christian Marangi wrote: > This is a continue of [1]. It was decided to take a more gradual > approach to implement LEDs support for switch and phy starting with > basic support and then implementing the hw control part when we have all > the prereq done. > > This series implements only the brightness_set() and blink_set() ops. > An example of switch implementation is done with qca8k. > > For PHY a more generic approach is used with implementing the LED > support in PHY core and with the user (in this case marvell) adding all > the required functions. > > Currently we set the default-state as "keep" to not change the default > configuration of the declared LEDs since almost every switch have a > default configuration. IIRC we were supposed to take these via netdev with acks from Pavel/Lee. So we need acks on patches 4/5/16 ? If there is a repost, could you take out the arch/arm patches? They should not go via netdev, we'll try to filter them out when applying but mistakes happen. -- pw-bot: need-ack _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel