From: Jakub Kicinski <kuba@kernel.org>
To: Zheng Wang <zyytlz.wz@163.com>
Cc: davem@davemloft.net, horatiu.vultur@microchip.com,
edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, hackerzheng666@gmail.com,
1395428693sheep@gmail.com, alex000young@gmail.com
Subject: Re: [PATCH net v3] net: ethernet: fix use after free bug in ns83820_remove_one due to race condition
Date: Tue, 18 Apr 2023 21:33:40 -0700 [thread overview]
Message-ID: <20230418213340.153529d7@kernel.org> (raw)
In-Reply-To: <20230417013107.360888-1-zyytlz.wz@163.com>
On Mon, 17 Apr 2023 09:31:07 +0800 Zheng Wang wrote:
> + netif_carrier_off(ndev);
> + netif_tx_disable(ndev);
> +
> unregister_netdev(ndev
It's not immediately obvious to me why disabling carrier and tx
are supposed to help. Please elaborate in the commit message if
you're confident that this is right.
--
pw-bot: cr
next prev parent reply other threads:[~2023-04-19 4:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 1:31 [PATCH net v3] net: ethernet: fix use after free bug in ns83820_remove_one due to race condition Zheng Wang
2023-04-18 11:44 ` Horatiu Vultur
2023-04-19 4:33 ` Jakub Kicinski [this message]
2023-04-19 5:30 ` Zheng Hacker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418213340.153529d7@kernel.org \
--to=kuba@kernel.org \
--cc=1395428693sheep@gmail.com \
--cc=alex000young@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hackerzheng666@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zyytlz.wz@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.