All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org,
	rfoss@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	wens@csie.org, samuel@sholland.org,
	Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
	airlied@gmail.com, daniel@ffwll.ch,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-media@vger.kernel.org,
	hverkuil-cisco@xs4all.nl
Subject: Re: [PATCH 1/3] dt-bindings: display: synopsys,dw-hdmi: Add property for disabling CEC
Date: Tue, 18 Apr 2023 16:41:15 -0500	[thread overview]
Message-ID: <20230418214115.GA2376963-robh@kernel.org> (raw)
In-Reply-To: <20230415104613.61224-2-jernej.skrabec@gmail.com>

On Sat, Apr 15, 2023 at 12:46:11PM +0200, Jernej Skrabec wrote:
> Even though some DW-HDMI controllers have perfectly usable HDMI-CEC
> implementation, some boards might prefer not to use it or even use
> software implementation instead.
> 
> Add property for disabling CEC so driver doesn't expose unused CEC
> interface, if CEC pin isn't connected anywhere.

Isn't this all true for any bridge supporting CEC? Make this common.

> 
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> ---
>  .../devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
> index 4b7e54a8f037..624d32c024f6 100644
> --- a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
> @@ -48,6 +48,11 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  snps,disable-cec:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      Disable HDMI-CEC.
> +
>  additionalProperties: true
>  
>  ...
> -- 
> 2.40.0
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org,
	rfoss@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	wens@csie.org, samuel@sholland.org,
	Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
	airlied@gmail.com, daniel@ffwll.ch,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-media@vger.kernel.org,
	hverkuil-cisco@xs4all.nl
Subject: Re: [PATCH 1/3] dt-bindings: display: synopsys,dw-hdmi: Add property for disabling CEC
Date: Tue, 18 Apr 2023 16:41:15 -0500	[thread overview]
Message-ID: <20230418214115.GA2376963-robh@kernel.org> (raw)
In-Reply-To: <20230415104613.61224-2-jernej.skrabec@gmail.com>

On Sat, Apr 15, 2023 at 12:46:11PM +0200, Jernej Skrabec wrote:
> Even though some DW-HDMI controllers have perfectly usable HDMI-CEC
> implementation, some boards might prefer not to use it or even use
> software implementation instead.
> 
> Add property for disabling CEC so driver doesn't expose unused CEC
> interface, if CEC pin isn't connected anywhere.

Isn't this all true for any bridge supporting CEC? Make this common.

> 
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> ---
>  .../devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
> index 4b7e54a8f037..624d32c024f6 100644
> --- a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
> @@ -48,6 +48,11 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  snps,disable-cec:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      Disable HDMI-CEC.
> +
>  additionalProperties: true
>  
>  ...
> -- 
> 2.40.0
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, neil.armstrong@linaro.org,
	rfoss@kernel.org, andrzej.hajda@intel.com, samuel@sholland.org,
	jonas@kwiboo.se, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, wens@csie.org,
	Laurent.pinchart@ideasonboard.com,
	krzysztof.kozlowski+dt@linaro.org, hverkuil-cisco@xs4all.nl,
	linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: display: synopsys, dw-hdmi: Add property for disabling CEC
Date: Tue, 18 Apr 2023 16:41:15 -0500	[thread overview]
Message-ID: <20230418214115.GA2376963-robh@kernel.org> (raw)
In-Reply-To: <20230415104613.61224-2-jernej.skrabec@gmail.com>

On Sat, Apr 15, 2023 at 12:46:11PM +0200, Jernej Skrabec wrote:
> Even though some DW-HDMI controllers have perfectly usable HDMI-CEC
> implementation, some boards might prefer not to use it or even use
> software implementation instead.
> 
> Add property for disabling CEC so driver doesn't expose unused CEC
> interface, if CEC pin isn't connected anywhere.

Isn't this all true for any bridge supporting CEC? Make this common.

> 
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> ---
>  .../devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
> index 4b7e54a8f037..624d32c024f6 100644
> --- a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
> @@ -48,6 +48,11 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  snps,disable-cec:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      Disable HDMI-CEC.
> +
>  additionalProperties: true
>  
>  ...
> -- 
> 2.40.0
> 

  reply	other threads:[~2023-04-18 21:41 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-15 10:46 [PATCH 0/3] drm/bridge: dw_hdmi: allow to disable CEC from DT Jernej Skrabec
2023-04-15 10:46 ` Jernej Skrabec
2023-04-15 10:46 ` Jernej Skrabec
2023-04-15 10:46 ` [PATCH 1/3] dt-bindings: display: synopsys,dw-hdmi: Add property for disabling CEC Jernej Skrabec
2023-04-15 10:46   ` [PATCH 1/3] dt-bindings: display: synopsys, dw-hdmi: " Jernej Skrabec
2023-04-15 10:46   ` [PATCH 1/3] dt-bindings: display: synopsys,dw-hdmi: " Jernej Skrabec
2023-04-18 21:41   ` Rob Herring [this message]
2023-04-18 21:41     ` [PATCH 1/3] dt-bindings: display: synopsys, dw-hdmi: " Rob Herring
2023-04-18 21:41     ` [PATCH 1/3] dt-bindings: display: synopsys,dw-hdmi: " Rob Herring
2023-04-21  7:07     ` Hans Verkuil
2023-04-21  7:07       ` [PATCH 1/3] dt-bindings: display: synopsys, dw-hdmi: " Hans Verkuil
2023-04-21  7:07       ` [PATCH 1/3] dt-bindings: display: synopsys,dw-hdmi: " Hans Verkuil
2023-04-15 10:46 ` [PATCH 2/3] drm/bridge: dw_hdmi: Handle snps,disable-cec property Jernej Skrabec
2023-04-15 10:46   ` Jernej Skrabec
2023-04-15 10:46   ` Jernej Skrabec
2023-04-17 13:32   ` Robert Foss
2023-04-17 13:32     ` [PATCH 2/3] drm/bridge: dw_hdmi: Handle snps, disable-cec property Robert Foss
2023-04-17 13:32     ` [PATCH 2/3] drm/bridge: dw_hdmi: Handle snps,disable-cec property Robert Foss
2023-04-15 10:46 ` [PATCH 3/3] ARM: dts: sun8i: h3: beelink-x2: Disable DW-HDMI CEC Jernej Skrabec
2023-04-15 10:46   ` Jernej Skrabec
2023-04-15 10:46   ` Jernej Skrabec
2023-04-16 13:25   ` Laurent Pinchart
2023-04-16 13:25     ` Laurent Pinchart
2023-04-16 13:25     ` Laurent Pinchart
2023-04-16 13:31     ` Jernej Škrabec
2023-04-16 13:31       ` Jernej Škrabec
2023-04-16 13:31       ` Jernej Škrabec
2023-04-16 13:47       ` Laurent Pinchart
2023-04-16 13:47         ` Laurent Pinchart
2023-04-16 13:47         ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230418214115.GA2376963-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.