From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EDF2C77B75 for ; Tue, 18 Apr 2023 22:26:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230523AbjDRW0R (ORCPT ); Tue, 18 Apr 2023 18:26:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230202AbjDRW0Q (ORCPT ); Tue, 18 Apr 2023 18:26:16 -0400 Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 369D559D7; Tue, 18 Apr 2023 15:26:15 -0700 (PDT) Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-1842c7c2daaso470971fac.0; Tue, 18 Apr 2023 15:26:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681856774; x=1684448774; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DzkYu2FZFUxwYvdabyHvXaq9bbCUpOwOEj0N+6nTnPE=; b=dvhF4A1PpuHaqCHDBeyzvgJrX354fRn2/VrKKNq6bW1R6Q7cMj6vomNpaLq1OpZHe2 0Guq9r556cWq6AWKzqKsv/+6o/K8q9RsuMFFJkIi6WSFwPa54tZBx2VV8BLJYe+OH5ru akJmbMttjOh92iIygodVTsFWdyA+qhm43YCUQVR90kSzUnue5nmfZnL3VDSBdmEEK7x6 1mBzVROySrecgTKd4ESEAaUaVQEiSX2S4uM0dDRSbkTI0rL3BANTDIrIoh4yTMVAUcCw +V74HHc9EOTxDHsnoVz5/80HQ5X94WdYXBWE5qyKBmbuWwskDodAvHq9O7pxHm2q2GJu vYVw== X-Gm-Message-State: AAQBX9fhRcd2BgOh0a1aIG/hI5+Bti9lo9/iU0voPA7wZ/N7yMkbzn0R cKjJoG+Rx9LQZvU+VTKr0w== X-Google-Smtp-Source: AKy350bFvNy0NlWTzt68rhthpi/WPjnoE7xLzVZ9Y3ny/MmMDQ7CWhC385UPZEOO6x3QefiiZ6rpbQ== X-Received: by 2002:a05:6870:f2a5:b0:184:50ac:2e27 with SMTP id u37-20020a056870f2a500b0018450ac2e27mr1936247oap.50.1681856774469; Tue, 18 Apr 2023 15:26:14 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id e8-20020a9d63c8000000b006a5f70dd12bsm1374581otl.17.2023.04.18.15.26.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 15:26:13 -0700 (PDT) Received: (nullmailer pid 2439794 invoked by uid 1000); Tue, 18 Apr 2023 22:26:13 -0000 Date: Tue, 18 Apr 2023 17:26:13 -0500 From: Rob Herring To: Krzysztof Kozlowski Cc: Neil Armstrong , Sam Ravnborg , David Airlie , Daniel Vetter , Krzysztof Kozlowski , Thierry Reding , Laurent Pinchart , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio Subject: Re: [PATCH] dt-bindings: display: panel: add common definition of ports Message-ID: <20230418222613.GA2408838-robh@kernel.org> References: <20230416153929.356330-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230416153929.356330-1-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Apr 16, 2023 at 05:39:29PM +0200, Krzysztof Kozlowski wrote: > Few panel bindings for dual-link connections just type "ports: true", > which does not enforce any type. Add common definition of ports, so the > type will be fixed. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Cc: Konrad Dybcio > --- > .../bindings/display/panel/panel-common.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml > index 5b38dc89cb21..ad62d34e6fa3 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml > @@ -70,6 +70,16 @@ properties: > port: > $ref: /schemas/graph.yaml#/properties/port > > + # For dual-link connections > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + patternProperties: > + "^port@[0-9a-f]+$": > + $ref: /schemas/graph.yaml#/$defs/port-base This allows any undocumented property. > + > + required: > + - port@0 > + I don't think this should be added here because users must define what each port is. With it here, we're going to validate the nodes twice as well. Same can be said for 'port' though. It can't be extended though. I originally wanted to a do a meta-schema to enforce some of this, but there's just too many exceptions. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEE28C6FD18 for ; Tue, 18 Apr 2023 22:26:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E15B310E215; Tue, 18 Apr 2023 22:26:16 +0000 (UTC) Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by gabe.freedesktop.org (Postfix) with ESMTPS id 772F110E215 for ; Tue, 18 Apr 2023 22:26:15 +0000 (UTC) Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-6a5ecdb455bso485516a34.0 for ; Tue, 18 Apr 2023 15:26:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681856774; x=1684448774; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DzkYu2FZFUxwYvdabyHvXaq9bbCUpOwOEj0N+6nTnPE=; b=HjjcDgLNtMpXfW9BEG7kmEv0HZrUJcXcuA5WamVMfN2DqXFxWNS27c81Ji2ZoJ1Mnq XihvL4/3HOeH1D4cnBORjhVE5dExWxXyyXb5ZcSOv8L7cgTao7ISck55DIFfl9ndQ4X7 Z62JcCyZi/NyJk643RzXu6/mjLZHqQW13cYnb4e/1DOk/tx8wK900mWvZuDV54PET3Iw QmbkCamc4NgN7l7/LjYUVFQzysPt8ZDhwu3XQYQhYDACpy0rIxdEB0BY8u48NvhO3DPR kmipD3cbLIJdslicxDF6TwXarvyWMHlc8N6kkrBdAooMn5ldGQH4y4YuHyMqXtXTJR6B E9pw== X-Gm-Message-State: AAQBX9e0ZJSgxapruszdSTpXn+P0xA/7jSCs4HePguH+SVVBd27gi346 uPsItyJLNBklD4O6S6n2Fg== X-Google-Smtp-Source: AKy350bFvNy0NlWTzt68rhthpi/WPjnoE7xLzVZ9Y3ny/MmMDQ7CWhC385UPZEOO6x3QefiiZ6rpbQ== X-Received: by 2002:a05:6870:f2a5:b0:184:50ac:2e27 with SMTP id u37-20020a056870f2a500b0018450ac2e27mr1936247oap.50.1681856774469; Tue, 18 Apr 2023 15:26:14 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id e8-20020a9d63c8000000b006a5f70dd12bsm1374581otl.17.2023.04.18.15.26.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 15:26:13 -0700 (PDT) Received: (nullmailer pid 2439794 invoked by uid 1000); Tue, 18 Apr 2023 22:26:13 -0000 Date: Tue, 18 Apr 2023 17:26:13 -0500 From: Rob Herring To: Krzysztof Kozlowski Subject: Re: [PATCH] dt-bindings: display: panel: add common definition of ports Message-ID: <20230418222613.GA2408838-robh@kernel.org> References: <20230416153929.356330-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230416153929.356330-1-krzysztof.kozlowski@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Laurent Pinchart , devicetree@vger.kernel.org, Sam Ravnborg , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Konrad Dybcio , Thierry Reding , Krzysztof Kozlowski Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Apr 16, 2023 at 05:39:29PM +0200, Krzysztof Kozlowski wrote: > Few panel bindings for dual-link connections just type "ports: true", > which does not enforce any type. Add common definition of ports, so the > type will be fixed. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Cc: Konrad Dybcio > --- > .../bindings/display/panel/panel-common.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml > index 5b38dc89cb21..ad62d34e6fa3 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml > @@ -70,6 +70,16 @@ properties: > port: > $ref: /schemas/graph.yaml#/properties/port > > + # For dual-link connections > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + patternProperties: > + "^port@[0-9a-f]+$": > + $ref: /schemas/graph.yaml#/$defs/port-base This allows any undocumented property. > + > + required: > + - port@0 > + I don't think this should be added here because users must define what each port is. With it here, we're going to validate the nodes twice as well. Same can be said for 'port' though. It can't be extended though. I originally wanted to a do a meta-schema to enforce some of this, but there's just too many exceptions. Rob