From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
Christoph Hellwig <hch@lst.de>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH v2 06/11] block: mq-deadline: Disable head insertion for zoned writes
Date: Wed, 19 Apr 2023 06:30:44 +0200 [thread overview]
Message-ID: <20230419043044.GC25329@lst.de> (raw)
In-Reply-To: <20230418224002.1195163-7-bvanassche@acm.org>
On Tue, Apr 18, 2023 at 03:39:57PM -0700, Bart Van Assche wrote:
> Make sure that zoned writes (REQ_OP_WRITE and REQ_OP_WRITE_ZEROES) are
> submitted in LBA order. This patch does not affect REQ_OP_WRITE_APPEND
> requests.
As said before this is not correct. What we need to instead is to
support proper patch insertation when the at_head flag is set so
that the requests get inserted before the existing requests, but
in ordered they are passed to the I/O scheduler.
This also needs to be done for the other two I/O schedulers.
next prev parent reply other threads:[~2023-04-19 4:30 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 22:39 [PATCH v2 00/11] mq-deadline: Improve support for zoned block devices Bart Van Assche
2023-04-18 22:39 ` [PATCH v2 01/11] block: Simplify blk_req_needs_zone_write_lock() Bart Van Assche
2023-04-19 4:09 ` Christoph Hellwig
2023-04-18 22:39 ` [PATCH v2 02/11] block: Micro-optimize blk_req_needs_zone_write_lock() Bart Van Assche
2023-04-19 4:11 ` Christoph Hellwig
2023-04-19 18:30 ` Bart Van Assche
2023-04-20 5:00 ` Christoph Hellwig
2023-04-18 22:39 ` [PATCH v2 03/11] block: Introduce blk_rq_is_seq_zoned_write() Bart Van Assche
2023-04-19 4:50 ` Christoph Hellwig
2023-04-19 21:12 ` Bart Van Assche
2023-04-20 1:03 ` Damien Le Moal
2023-04-20 5:01 ` Christoph Hellwig
2023-04-18 22:39 ` [PATCH v2 04/11] block: mq-deadline: Simplify deadline_skip_seq_writes() Bart Van Assche
2023-04-19 4:52 ` Christoph Hellwig
2023-04-18 22:39 ` [PATCH v2 05/11] block: mq-deadline: Improve deadline_skip_seq_writes() Bart Van Assche
2023-04-18 22:39 ` [PATCH v2 06/11] block: mq-deadline: Disable head insertion for zoned writes Bart Van Assche
2023-04-19 4:30 ` Christoph Hellwig [this message]
2023-04-19 22:43 ` Bart Van Assche
2023-04-20 5:06 ` Christoph Hellwig
2023-04-20 17:00 ` Bart Van Assche
2023-04-24 7:00 ` Christoph Hellwig
2023-04-18 22:39 ` [PATCH v2 07/11] block: mq-deadline: Preserve write streams for all device types Bart Van Assche
2023-04-18 22:39 ` [PATCH v2 08/11] block: mq-deadline: Fix a race condition related to zoned writes Bart Van Assche
2023-04-19 5:07 ` Christoph Hellwig
2023-04-19 18:46 ` Bart Van Assche
2023-04-20 1:00 ` Damien Le Moal
2023-04-18 22:40 ` [PATCH v2 09/11] block: mq-deadline: Handle requeued requests correctly Bart Van Assche
2023-04-19 5:07 ` Christoph Hellwig
2023-04-19 23:01 ` Bart Van Assche
2023-04-20 1:07 ` Damien Le Moal
2023-04-18 22:40 ` [PATCH v2 10/11] block: Add support for the zone capacity concept Bart Van Assche
2023-04-20 9:23 ` Niklas Cassel
2023-04-20 17:12 ` Bart Van Assche
2023-04-20 22:00 ` Damien Le Moal
2023-04-20 22:51 ` Bart Van Assche
2023-04-20 23:37 ` Damien Le Moal
2023-04-20 23:44 ` Bart Van Assche
2023-04-20 23:53 ` Damien Le Moal
2023-04-21 0:29 ` Jaegeuk Kim
2023-04-21 1:52 ` Damien Le Moal
2023-04-21 20:15 ` Jaegeuk Kim
2023-04-21 22:25 ` Damien Le Moal
2023-04-24 6:01 ` Christoph Hellwig
2023-04-24 17:58 ` Jaegeuk Kim
2023-04-24 19:05 ` Jaegeuk Kim
2023-04-25 13:38 ` Damien Le Moal
2023-04-24 17:48 ` Jaegeuk Kim
2023-04-18 22:40 ` [PATCH v2 11/11] block: mq-deadline: Respect the active zone limit Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230419043044.GC25329@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.