All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sai Krishna <saikrishnag@marvell.com>
To: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <simon.horman@corigine.com>,
	<leon@kernel.org>, <sgoutham@marvell.com>, <gakula@marvell.com>,
	<lcherian@marvell.com>, <jerinj@marvell.com>,
	<hkelam@marvell.com>, <sbhatta@marvell.com>
Cc: Suman Ghosh <sumang@marvell.com>, Sai Krishna <saikrishnag@marvell.com>
Subject: [net PATCH v3 06/10] octeontx2-af: Update correct mask to filter IPv4 fragments
Date: Wed, 19 Apr 2023 11:50:14 +0530	[thread overview]
Message-ID: <20230419062018.286136-7-saikrishnag@marvell.com> (raw)
In-Reply-To: <20230419062018.286136-1-saikrishnag@marvell.com>

From: Suman Ghosh <sumang@marvell.com>

During the initial design, the IPv4 ip_flag mask was set to 0xff.
Which results to filter only fragmets with (fragment_offset == 0).
As part of the fix, updated the mask to 0x20 to filter all the
fragmented packets irrespective of the fragment_offset value.

Fixes: c672e3727989 ("octeontx2-pf: Add support to filter packet based on IP fragment")
Signed-off-by: Suman Ghosh <sumang@marvell.com>
Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
Signed-off-by: Sai Krishna <saikrishnag@marvell.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
---
 drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
index 044cc211424e..8392f63e433f 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
@@ -544,7 +544,7 @@ static int otx2_tc_prepare_flow(struct otx2_nic *nic, struct otx2_tc_flow *node,
 		if (match.mask->flags & FLOW_DIS_IS_FRAGMENT) {
 			if (ntohs(flow_spec->etype) == ETH_P_IP) {
 				flow_spec->ip_flag = IPV4_FLAG_MORE;
-				flow_mask->ip_flag = 0xff;
+				flow_mask->ip_flag = IPV4_FLAG_MORE;
 				req->features |= BIT_ULL(NPC_IPFRAG_IPV4);
 			} else if (ntohs(flow_spec->etype) == ETH_P_IPV6) {
 				flow_spec->next_header = IPPROTO_FRAGMENT;
-- 
2.25.1


  parent reply	other threads:[~2023-04-19  6:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19  6:20 [net PATCH v3 00/10] octeontx2: Miscellaneous fixes Sai Krishna
2023-04-19  6:20 ` [net PATCH v3 01/10] octeontx2-af: Secure APR table update with the lock Sai Krishna
2023-04-19  6:20 ` [net PATCH v3 02/10] octeontx2-af: Fix start and end bit for scan config Sai Krishna
2023-04-19 10:35   ` Simon Horman
2023-04-20  7:32     ` Sai Krishna Gajula
2023-04-19  6:20 ` [net PATCH v3 03/10] octeontx2-af: Fix depth of cam and mem table Sai Krishna
2023-04-19  9:54   ` Simon Horman
2023-04-20  7:40     ` Sai Krishna Gajula
2023-04-19  6:20 ` [net PATCH v3 04/10] octeontx2-pf: Increase the size of dmac filter flows Sai Krishna
2023-04-19 10:38   ` Simon Horman
2023-04-19  6:20 ` [net PATCH v3 05/10] octeontx2-af: Add validation for lmac type Sai Krishna
2023-04-19  6:20 ` Sai Krishna [this message]
2023-04-19  6:20 ` [net PATCH v3 07/10] octeontx2-af: Update/Fix NPC field hash extract feature Sai Krishna
2023-04-19 11:05   ` Simon Horman
2023-04-19  6:20 ` [net PATCH v3 08/10] octeontx2-af: Fix issues with NPC field hash extract Sai Krishna
2023-04-19 11:06   ` Simon Horman
2023-04-19  6:20 ` [net PATCH v3 09/10] octeontx2-af: Skip PFs if not enabled Sai Krishna
2023-04-19 10:51   ` Simon Horman
2023-04-20  7:29     ` Sai Krishna Gajula
2023-04-19  6:20 ` [net PATCH v3 10/10] octeontx2-pf: Disable packet I/O for graceful exit Sai Krishna
2023-04-19 11:03   ` Simon Horman
2023-04-20  7:21     ` Sai Krishna Gajula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230419062018.286136-7-saikrishnag@marvell.com \
    --to=saikrishnag@marvell.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gakula@marvell.com \
    --cc=hkelam@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=kuba@kernel.org \
    --cc=lcherian@marvell.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    --cc=simon.horman@corigine.com \
    --cc=sumang@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.