From: kernel test robot <lkp@intel.com>
To: luhongfei <luhongfei@vivo.com>, Jens Axboe <axboe@kernel.dk>,
Pavel Begunkov <asml.silence@gmail.com>,
"open list:IO_URING" <io-uring@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
opensource.kernel@vivo.com, luhongfei <luhongfei@vivo.com>
Subject: Re: [PATCH] io_uring: Optimization of buffered random write
Date: Thu, 20 Apr 2023 05:30:07 +0800 [thread overview]
Message-ID: <202304200502.T4Waeqad-lkp@intel.com> (raw)
In-Reply-To: <20230419092233.56338-1-luhongfei@vivo.com>
Hi luhongfei,
kernel test robot noticed the following build errors:
[auto build test ERROR on linus/master]
[also build test ERROR on v6.3-rc7 next-20230418]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/luhongfei/io_uring-Optimization-of-buffered-random-write/20230419-172539
patch link: https://lore.kernel.org/r/20230419092233.56338-1-luhongfei%40vivo.com
patch subject: [PATCH] io_uring: Optimization of buffered random write
config: i386-randconfig-a012-20230417 (https://download.01.org/0day-ci/archive/20230420/202304200502.T4Waeqad-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/620dbcc5ab192992f08035fd9d271ffffb8ff043
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review luhongfei/io_uring-Optimization-of-buffered-random-write/20230419-172539
git checkout 620dbcc5ab192992f08035fd9d271ffffb8ff043
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304200502.T4Waeqad-lkp@intel.com/
All errors (new ones prefixed by >>):
>> io_uring/io_uring.c:2091:25: error: no member named 'rw' in 'struct io_kiocb'
if (!is_write || (req->rw.kiocb.ki_flags & IOCB_DIRECT))
~~~ ^
1 error generated.
vim +2091 io_uring/io_uring.c
2073
2074 static inline void io_queue_sqe(struct io_kiocb *req)
2075 __must_hold(&req->ctx->uring_lock)
2076 {
2077 int ret;
2078 bool is_write;
2079
2080 switch (req->opcode) {
2081 case IORING_OP_WRITEV:
2082 case IORING_OP_WRITE_FIXED:
2083 case IORING_OP_WRITE:
2084 is_write = true;
2085 break;
2086 default:
2087 is_write = false;
2088 break;
2089 }
2090
> 2091 if (!is_write || (req->rw.kiocb.ki_flags & IOCB_DIRECT))
2092 ret = io_issue_sqe(req, IO_URING_F_NONBLOCK|IO_URING_F_COMPLETE_DEFER);
2093 else
2094 ret = io_issue_sqe(req, 0);
2095
2096 /*
2097 * We async punt it if the file wasn't marked NOWAIT, or if the file
2098 * doesn't support non-blocking read/write attempts
2099 */
2100 if (likely(!ret))
2101 io_arm_ltimeout(req);
2102 else
2103 io_queue_async(req, ret);
2104 }
2105
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-04-19 21:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 9:22 [PATCH] io_uring: Optimization of buffered random write luhongfei
2023-04-19 13:32 ` Jens Axboe
2023-04-19 14:11 ` Jens Axboe
2023-04-19 19:26 ` kernel test robot
2023-04-19 21:30 ` kernel test robot [this message]
2023-04-19 21:40 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202304200502.T4Waeqad-lkp@intel.com \
--to=lkp@intel.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=luhongfei@vivo.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.