From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 939E8C77B72 for ; Thu, 20 Apr 2023 10:54:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235102AbjDTKyB (ORCPT ); Thu, 20 Apr 2023 06:54:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234489AbjDTKxh (ORCPT ); Thu, 20 Apr 2023 06:53:37 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 029549038; Thu, 20 Apr 2023 03:51:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681987876; x=1713523876; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=KmE64Zj6fg+JjmPyFrX4JWdvnkdBVGIAbEnhh9TTANI=; b=ILpveA9qRgTW7jyGSvc2SfKqSYOe5SxSUwZ0ePC5NlNGc1Te2WheejfD Yt2WsYoltrDbrJcQkeB+bQ5ZaN+suNxG1OSluUpGPYKehoNAfQp/7MEJZ ZWhXuPqD1/l66SJrZCc5bYLe0rer21EN0Xv1Ne12lvHjOWe7z39c7YVTr ssv1k7XljsX8gRIld11qbXUS3p+aPqqhCrcW7HVMv9FFd1ZSaxRFnWJ6O LuYTjTDiiWlVmk2Gy0N1dITgeRJuo+Y04TvC3OS6ciUleuamMjj+RYjNs e2vgaPv07+NwmXpxRDffn7E7JXoo6lkqHWL3yvlTYbXxT9duvKriMmnDy g==; X-IronPort-AV: E=McAfee;i="6600,9927,10685"; a="373596339" X-IronPort-AV: E=Sophos;i="5.99,212,1677571200"; d="scan'208";a="373596339" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2023 03:50:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10685"; a="803299501" X-IronPort-AV: E=Sophos;i="5.99,212,1677571200"; d="scan'208";a="803299501" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 20 Apr 2023 03:50:08 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id A04B721E7; Thu, 20 Apr 2023 13:50:13 +0300 (EEST) Date: Thu, 20 Apr 2023 13:50:13 +0300 From: Mika Westerberg To: Kai-Heng Feng Cc: bhelgaas@google.com, koba.ko@canonical.com, sathyanarayanan.kuppuswamy@linux.intel.com, Mahesh J Salgaonkar , Oliver O'Halloran , linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] PCI/AER: Disable AER interrupt on suspend Message-ID: <20230420105013.GN66750@black.fi.intel.com> References: <20230420015830.309845-1-kai.heng.feng@canonical.com> <20230420015830.309845-3-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230420015830.309845-3-kai.heng.feng@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Apr 20, 2023 at 09:58:29AM +0800, Kai-Heng Feng wrote: > PCIe service that shares IRQ with PME may cause spurious wakeup on > system suspend. > > PCIe Base Spec 5.0, section 5.2 "Link State Power Management" states > that TLP and DLLP transmission is disabled for a Link in L2/L3 Ready > (D3hot), L2 (D3cold with aux power) and L3 (D3cold), so we don't lose > much here to disable AER during system suspend. > > This is very similar to previous attempts to suspend AER and DPC [1], > but with a different reason. > > [1] https://lore.kernel.org/linux-pci/20220408153159.106741-1-kai.heng.feng@canonical.com/ > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216295 > > Signed-off-by: Kai-Heng Feng Reviewed-by: Mika Westerberg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00FC5C77B73 for ; Thu, 20 Apr 2023 10:51:09 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Q2DwX24xVz3f5M for ; Thu, 20 Apr 2023 20:51:08 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Pun8GlzU; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=mika.westerberg@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Pun8GlzU; dkim-atps=neutral Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Q2Dvb2T8pz3chl for ; Thu, 20 Apr 2023 20:50:18 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681987819; x=1713523819; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=KmE64Zj6fg+JjmPyFrX4JWdvnkdBVGIAbEnhh9TTANI=; b=Pun8GlzUevWjchaKUskD/wvJZUuW4LrLH4uU1sfgODdKF5P2f7h1CRnk l6bZ7x3zcF+fBb3IT8f4KvWdCCqc/CiBt/Y8BB9qgc2/Ip0IBv/Qa6acb 8f+0/AG0PvlgBxKMzS2kwXJuevGIGcXXzzPza/xZnreZ7CfYA66V+QiTy /ajUDUw2P04iJBFwhYI690tABA7UJyDMK+dVI3M4uXCRTEvkG11dEz6T0 o2zWIPJ7uTyPnczsOEj2u6B9dmS6gnXeYD5F95qEUC/B04B4/wiWdvMUR QUqhuS52EieXTkv14AV08Kf7KQHYa7GwjPSyCwjVyUVWQ/DBHSaqYGQmx g==; X-IronPort-AV: E=McAfee;i="6600,9927,10685"; a="373596344" X-IronPort-AV: E=Sophos;i="5.99,212,1677571200"; d="scan'208";a="373596344" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2023 03:50:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10685"; a="803299501" X-IronPort-AV: E=Sophos;i="5.99,212,1677571200"; d="scan'208";a="803299501" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 20 Apr 2023 03:50:08 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id A04B721E7; Thu, 20 Apr 2023 13:50:13 +0300 (EEST) Date: Thu, 20 Apr 2023 13:50:13 +0300 From: Mika Westerberg To: Kai-Heng Feng Subject: Re: [PATCH v2 3/4] PCI/AER: Disable AER interrupt on suspend Message-ID: <20230420105013.GN66750@black.fi.intel.com> References: <20230420015830.309845-1-kai.heng.feng@canonical.com> <20230420015830.309845-3-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230420015830.309845-3-kai.heng.feng@canonical.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sathyanarayanan.kuppuswamy@linux.intel.com, linux-pci@vger.kernel.org, Mahesh J Salgaonkar , linux-kernel@vger.kernel.org, koba.ko@canonical.com, Oliver O'Halloran , bhelgaas@google.com, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Apr 20, 2023 at 09:58:29AM +0800, Kai-Heng Feng wrote: > PCIe service that shares IRQ with PME may cause spurious wakeup on > system suspend. > > PCIe Base Spec 5.0, section 5.2 "Link State Power Management" states > that TLP and DLLP transmission is disabled for a Link in L2/L3 Ready > (D3hot), L2 (D3cold with aux power) and L3 (D3cold), so we don't lose > much here to disable AER during system suspend. > > This is very similar to previous attempts to suspend AER and DPC [1], > but with a different reason. > > [1] https://lore.kernel.org/linux-pci/20220408153159.106741-1-kai.heng.feng@canonical.com/ > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216295 > > Signed-off-by: Kai-Heng Feng Reviewed-by: Mika Westerberg