From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 525DCC77B72 for ; Thu, 20 Apr 2023 10:54:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234694AbjDTKy3 (ORCPT ); Thu, 20 Apr 2023 06:54:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235112AbjDTKyE (ORCPT ); Thu, 20 Apr 2023 06:54:04 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF5EAA258; Thu, 20 Apr 2023 03:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681987901; x=1713523901; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=VQeRmgq2CDJ+tcP+P+IQ5uUOrFT2lqNUDOdu5qsJP4E=; b=LrtED/zGjIvk9DTZ53uy/EslWznC5+HS0JbU1IENwVf6Y22aMSWyb2xp 0cE7m9W9vWcYh4haFOKwAOYHTXsz0Ni3K0h7TDDECy3h/aY3L7xsOek4C PZ2nLyjFY9BVZK1XuCA8NfFndmQTY+/9BPh8aTFd7j08o6avwfBB8kzDr 6kuz8g8TZ4CifFKYcK3YohDe4AXAxDCYAExO+vg1nLzIvyJHh37YkMDnn lqv3y+Z12vxCm7Yn8dLpXEv9INj0AQw82LRB7SMDNmLv4yi40KnZ6gY1z xFxTRy1YJkKRFdEzWo9Mp+bVNlCcets7vrQ+Vj/+kaAdYQ+BXx6z+32EZ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10685"; a="373596454" X-IronPort-AV: E=Sophos;i="5.99,212,1677571200"; d="scan'208";a="373596454" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2023 03:51:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10685"; a="756465504" X-IronPort-AV: E=Sophos;i="5.99,212,1677571200"; d="scan'208";a="756465504" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga008.fm.intel.com with ESMTP; 20 Apr 2023 03:51:00 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id 51AAE21E7; Thu, 20 Apr 2023 13:51:05 +0300 (EEST) Date: Thu, 20 Apr 2023 13:51:05 +0300 From: Mika Westerberg To: Kai-Heng Feng Cc: bhelgaas@google.com, koba.ko@canonical.com, sathyanarayanan.kuppuswamy@linux.intel.com, Mahesh J Salgaonkar , Oliver O'Halloran , linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] PCI/DPC: Disable DPC interrupt during suspend Message-ID: <20230420105105.GO66750@black.fi.intel.com> References: <20230420015830.309845-1-kai.heng.feng@canonical.com> <20230420015830.309845-4-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230420015830.309845-4-kai.heng.feng@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Apr 20, 2023 at 09:58:30AM +0800, Kai-Heng Feng wrote: > PCIe service that shares IRQ with PME may cause spurious wakeup on > system suspend. > > Since AER is conditionally disabled in previous patch, also apply the > same logic to disable DPC which depends on AER to work. > > PCIe Base Spec 5.0, section 5.2 "Link State Power Management" states > that TLP and DLLP transmission is disabled for a Link in L2/L3 Ready > (D3hot), L2 (D3cold with aux power) and L3 (D3cold), so we don't lose > much here to disable DPC during system suspend. > > This is very similar to previous attempts to suspend AER and DPC [1], > but with a different reason. > > [1] https://lore.kernel.org/linux-pci/20220408153159.106741-1-kai.heng.feng@canonical.com/ > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216295 > > Signed-off-by: Kai-Heng Feng Reviewed-by: Mika Westerberg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF604C77B72 for ; Thu, 20 Apr 2023 10:51:57 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Q2DxS1R3fz3fWn for ; Thu, 20 Apr 2023 20:51:56 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=eG7O2EVx; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=mika.westerberg@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=eG7O2EVx; dkim-atps=neutral Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Q2DwT3NSbz3fSn for ; Thu, 20 Apr 2023 20:51:04 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681987865; x=1713523865; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=VQeRmgq2CDJ+tcP+P+IQ5uUOrFT2lqNUDOdu5qsJP4E=; b=eG7O2EVxfmIBIvIGnq4HXBsBAJDEFv6ujZ0/kl9H2NaoY5VwKQ/QLCxq KRy/r6AdLIPWLXU6ftphIvXTsI6B2GW02GAEjK5lIWbL9I6v9C/CH59Bu cC7vCi1Vhq1lET0YctE14WjGVryxQzVUSs7Zcg9IqMrLdsSDU1dKzOtZa k0iLQwkOD6fmFKHKOTtmScF+RwR+OWLQNt4F0tI6U72luCj4f1MBFlHCS G7L4arFPzfVaV6a7W+5fES8odZ9enO6vCT0D7MvcoEENdVLuMFAICGSzU HRJHaEXYqOUYeA4CDBZDEWzvAhR72tRsw9C3S51Su02GCqF59qvBzT2Ei A==; X-IronPort-AV: E=McAfee;i="6600,9927,10685"; a="373596459" X-IronPort-AV: E=Sophos;i="5.99,212,1677571200"; d="scan'208";a="373596459" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2023 03:51:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10685"; a="756465504" X-IronPort-AV: E=Sophos;i="5.99,212,1677571200"; d="scan'208";a="756465504" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga008.fm.intel.com with ESMTP; 20 Apr 2023 03:51:00 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id 51AAE21E7; Thu, 20 Apr 2023 13:51:05 +0300 (EEST) Date: Thu, 20 Apr 2023 13:51:05 +0300 From: Mika Westerberg To: Kai-Heng Feng Subject: Re: [PATCH v2 4/4] PCI/DPC: Disable DPC interrupt during suspend Message-ID: <20230420105105.GO66750@black.fi.intel.com> References: <20230420015830.309845-1-kai.heng.feng@canonical.com> <20230420015830.309845-4-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230420015830.309845-4-kai.heng.feng@canonical.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sathyanarayanan.kuppuswamy@linux.intel.com, linux-pci@vger.kernel.org, Mahesh J Salgaonkar , linux-kernel@vger.kernel.org, koba.ko@canonical.com, Oliver O'Halloran , bhelgaas@google.com, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Apr 20, 2023 at 09:58:30AM +0800, Kai-Heng Feng wrote: > PCIe service that shares IRQ with PME may cause spurious wakeup on > system suspend. > > Since AER is conditionally disabled in previous patch, also apply the > same logic to disable DPC which depends on AER to work. > > PCIe Base Spec 5.0, section 5.2 "Link State Power Management" states > that TLP and DLLP transmission is disabled for a Link in L2/L3 Ready > (D3hot), L2 (D3cold with aux power) and L3 (D3cold), so we don't lose > much here to disable DPC during system suspend. > > This is very similar to previous attempts to suspend AER and DPC [1], > but with a different reason. > > [1] https://lore.kernel.org/linux-pci/20220408153159.106741-1-kai.heng.feng@canonical.com/ > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216295 > > Signed-off-by: Kai-Heng Feng Reviewed-by: Mika Westerberg