From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3474BC77B72 for ; Thu, 20 Apr 2023 11:03:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235151AbjDTLDr (ORCPT ); Thu, 20 Apr 2023 07:03:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235189AbjDTLDZ (ORCPT ); Thu, 20 Apr 2023 07:03:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DD267294; Thu, 20 Apr 2023 04:02:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D0F65647AF; Thu, 20 Apr 2023 11:01:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC1A5C433EF; Thu, 20 Apr 2023 11:01:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681988477; bh=40BVpmsumFk3aPJFU2dLAwtHIV2znVDn+AorQnPvg6U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rwc9h8CxmHsWH284LQ5Y9kjXKGF9zPhi6pLlHfED54eNbX2FmxNVsemhJ7eirXBc/ 5AgxzXtlUt+BHop476+JBDh9JGzRVvm6iNmwxq4ShniCA3ivmFTRHvNYAA2uwItmgN Imwzc8LZwYlUoE+V5dpZj30PkfNPvNFQxH8hnoOzDnEvkaszH7gVrr/zq5p5jyFBdK FhQpbGbSnalKu7k0vRBI+XQzzAgwoIqoMKVQHVFY1eczA3whwPW2MUGDSz7hLuCTtO SJqSA0go6sPOd3AK7Hu42fdk3MNzJCt0HYfU3FAeoBRkGzLEvBJUCqOMrCOtMD7WPw HYj+dYmI5SCvA== Date: Thu, 20 Apr 2023 12:01:11 +0100 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Maxime Coquelin , Alexandre Torgue , William Breathitt Gray , Fabrice Gasnier , Olivier Moysan , Thierry Reding , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-iio@vger.kernel.org Subject: Re: [PATCH] counter: stm32-timer-cnt: Reset TIM_TISEL and TIM_SMCR to their default value Message-ID: <20230420110111.GM9904@google.com> References: <20230412153709.3557323-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230412153709.3557323-1-u.kleine-koenig@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 12 Apr 2023, Uwe Kleine-König wrote: > The driver assumes that the input selection register (TIM_TISEL) is at > its reset default value. Usually this is the case, but the bootloader > might have modified it. Also reset the SMCR register while at it. > > This bases on the effectively same patch submitted by Olivier Moysan for > pwm-stm32. > > Signed-off-by: Uwe Kleine-König > --- > Hello, > > note that the patch by Olivier Moysan[1] for pwm-stm32 is expected to > appear in Thierry's tree soon. It added the definition of TIM_TISEL in > the same way, so the two patches should merge just fine. Alternatively > you can commit it to a tree that already has the pwm change (and then > drop the change to include/linux/mfd/stm32-timers.h from this one). > > Best regards > Uwe > > [1] https://lore.kernel.org/linux-pwm/20221213102707.1096345-1-olivier.moysan@foss.st.com > > drivers/counter/stm32-timer-cnt.c | 4 ++++ > include/linux/mfd/stm32-timers.h | 1 + Acked-by: Lee Jones > 2 files changed, 5 insertions(+) > > diff --git a/drivers/counter/stm32-timer-cnt.c b/drivers/counter/stm32-timer-cnt.c > index 9bf20a5d6bda..d001d77f17ac 100644 > --- a/drivers/counter/stm32-timer-cnt.c > +++ b/drivers/counter/stm32-timer-cnt.c > @@ -342,6 +342,10 @@ static int stm32_timer_cnt_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, priv); > > + /* Reset input selector to its default input and disable slave mode */ > + regmap_write(priv->regmap, TIM_TISEL, 0x0); > + regmap_write(priv->regmap, TIM_SMCR, 0x0); > + > /* Register Counter device */ > ret = devm_counter_add(dev, counter); > if (ret < 0) > diff --git a/include/linux/mfd/stm32-timers.h b/include/linux/mfd/stm32-timers.h > index 5f5c43fd69dd..1b94325febb3 100644 > --- a/include/linux/mfd/stm32-timers.h > +++ b/include/linux/mfd/stm32-timers.h > @@ -31,6 +31,7 @@ > #define TIM_BDTR 0x44 /* Break and Dead-Time Reg */ > #define TIM_DCR 0x48 /* DMA control register */ > #define TIM_DMAR 0x4C /* DMA register for transfer */ > +#define TIM_TISEL 0x68 /* Input Selection */ > > #define TIM_CR1_CEN BIT(0) /* Counter Enable */ > #define TIM_CR1_DIR BIT(4) /* Counter Direction */ > > base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6 > -- > 2.39.2 > -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B0D5C77B73 for ; Thu, 20 Apr 2023 11:02:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DZBev3n2MqOEqDRndIWZ9LH0eynXw1Ge1KbJ3XrJW5M=; b=C3RYXM5IYV3sMt fWEuDUywF9W0hPQtujHM7yrkegNarLIhfCatVBm70xbwoYjxhX+jIPXv7zzpDfvuPUTXlPIRO8KOZ iCSY3htXHZvN+36f62tKoxzizL3+56wXS847Bl8ZJdSh3lGtfutW7ed4IG6VMjdJSIDzTOwnBpbIH uTgcs/DVaq2w47tA0Q0wxKhoJHKiya3mJaG1bMy6gteLuorTyVnbP5e4lj28mfG/yj4+tTrH0gfvN HCmYClrCY4mibKl7eEZXwCTMAda3/E1BnRcUmxvxh1Wiq7nKjuBFsnYlvUzbR8NQEmppyx6lry1C4 EeXdcVHfXIIzUYLNRcZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ppS2U-007rwk-1H; Thu, 20 Apr 2023 11:01:22 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ppS2Q-007rvs-1b for linux-arm-kernel@lists.infradead.org; Thu, 20 Apr 2023 11:01:20 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C4CD1647A7; Thu, 20 Apr 2023 11:01:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC1A5C433EF; Thu, 20 Apr 2023 11:01:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681988477; bh=40BVpmsumFk3aPJFU2dLAwtHIV2znVDn+AorQnPvg6U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rwc9h8CxmHsWH284LQ5Y9kjXKGF9zPhi6pLlHfED54eNbX2FmxNVsemhJ7eirXBc/ 5AgxzXtlUt+BHop476+JBDh9JGzRVvm6iNmwxq4ShniCA3ivmFTRHvNYAA2uwItmgN Imwzc8LZwYlUoE+V5dpZj30PkfNPvNFQxH8hnoOzDnEvkaszH7gVrr/zq5p5jyFBdK FhQpbGbSnalKu7k0vRBI+XQzzAgwoIqoMKVQHVFY1eczA3whwPW2MUGDSz7hLuCTtO SJqSA0go6sPOd3AK7Hu42fdk3MNzJCt0HYfU3FAeoBRkGzLEvBJUCqOMrCOtMD7WPw HYj+dYmI5SCvA== Date: Thu, 20 Apr 2023 12:01:11 +0100 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Maxime Coquelin , Alexandre Torgue , William Breathitt Gray , Fabrice Gasnier , Olivier Moysan , Thierry Reding , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-iio@vger.kernel.org Subject: Re: [PATCH] counter: stm32-timer-cnt: Reset TIM_TISEL and TIM_SMCR to their default value Message-ID: <20230420110111.GM9904@google.com> References: <20230412153709.3557323-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230412153709.3557323-1-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230420_040118_615812_2897CEBC X-CRM114-Status: GOOD ( 27.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAxMiBBcHIgMjAyMywgVXdlIEtsZWluZS1Lw7ZuaWcgd3JvdGU6Cgo+IFRoZSBkcml2 ZXIgYXNzdW1lcyB0aGF0IHRoZSBpbnB1dCBzZWxlY3Rpb24gcmVnaXN0ZXIgKFRJTV9USVNFTCkg aXMgYXQKPiBpdHMgcmVzZXQgZGVmYXVsdCB2YWx1ZS4gVXN1YWxseSB0aGlzIGlzIHRoZSBjYXNl LCBidXQgdGhlIGJvb3Rsb2FkZXIKPiBtaWdodCBoYXZlIG1vZGlmaWVkIGl0LiBBbHNvIHJlc2V0 IHRoZSBTTUNSIHJlZ2lzdGVyIHdoaWxlIGF0IGl0Lgo+IAo+IFRoaXMgYmFzZXMgb24gdGhlIGVm ZmVjdGl2ZWx5IHNhbWUgcGF0Y2ggc3VibWl0dGVkIGJ5IE9saXZpZXIgTW95c2FuIGZvcgo+IHB3 bS1zdG0zMi4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUt a29lbmlnQHBlbmd1dHJvbml4LmRlPgo+IC0tLQo+IEhlbGxvLAo+IAo+IG5vdGUgdGhhdCB0aGUg cGF0Y2ggYnkgT2xpdmllciBNb3lzYW5bMV0gZm9yIHB3bS1zdG0zMiBpcyBleHBlY3RlZCB0bwo+ IGFwcGVhciBpbiBUaGllcnJ5J3MgdHJlZSBzb29uLiBJdCBhZGRlZCB0aGUgZGVmaW5pdGlvbiBv ZiBUSU1fVElTRUwgaW4KPiB0aGUgc2FtZSB3YXksIHNvIHRoZSB0d28gcGF0Y2hlcyBzaG91bGQg bWVyZ2UganVzdCBmaW5lLiBBbHRlcm5hdGl2ZWx5Cj4geW91IGNhbiBjb21taXQgaXQgdG8gYSB0 cmVlIHRoYXQgYWxyZWFkeSBoYXMgdGhlIHB3bSBjaGFuZ2UgKGFuZCB0aGVuCj4gZHJvcCB0aGUg Y2hhbmdlIHRvIGluY2x1ZGUvbGludXgvbWZkL3N0bTMyLXRpbWVycy5oIGZyb20gdGhpcyBvbmUp Lgo+IAo+IEJlc3QgcmVnYXJkcwo+IFV3ZQo+IAo+IFsxXSBodHRwczovL2xvcmUua2VybmVsLm9y Zy9saW51eC1wd20vMjAyMjEyMTMxMDI3MDcuMTA5NjM0NS0xLW9saXZpZXIubW95c2FuQGZvc3Mu c3QuY29tCj4gCj4gIGRyaXZlcnMvY291bnRlci9zdG0zMi10aW1lci1jbnQuYyB8IDQgKysrKwoK PiAgaW5jbHVkZS9saW51eC9tZmQvc3RtMzItdGltZXJzLmggIHwgMSArCgpBY2tlZC1ieTogTGVl IEpvbmVzIDxsZWVAa2VybmVsLm9yZz4KCj4gIDIgZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRpb25z KCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvY291bnRlci9zdG0zMi10aW1lci1jbnQuYyBi L2RyaXZlcnMvY291bnRlci9zdG0zMi10aW1lci1jbnQuYwo+IGluZGV4IDliZjIwYTVkNmJkYS4u ZDAwMWQ3N2YxN2FjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvY291bnRlci9zdG0zMi10aW1lci1j bnQuYwo+ICsrKyBiL2RyaXZlcnMvY291bnRlci9zdG0zMi10aW1lci1jbnQuYwo+IEBAIC0zNDIs NiArMzQyLDEwIEBAIHN0YXRpYyBpbnQgc3RtMzJfdGltZXJfY250X3Byb2JlKHN0cnVjdCBwbGF0 Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIAo+ICAJcGxhdGZvcm1fc2V0X2RydmRhdGEocGRldiwgcHJp dik7Cj4gIAo+ICsJLyogUmVzZXQgaW5wdXQgc2VsZWN0b3IgdG8gaXRzIGRlZmF1bHQgaW5wdXQg YW5kIGRpc2FibGUgc2xhdmUgbW9kZSAqLwo+ICsJcmVnbWFwX3dyaXRlKHByaXYtPnJlZ21hcCwg VElNX1RJU0VMLCAweDApOwo+ICsJcmVnbWFwX3dyaXRlKHByaXYtPnJlZ21hcCwgVElNX1NNQ1Is IDB4MCk7Cj4gKwo+ICAJLyogUmVnaXN0ZXIgQ291bnRlciBkZXZpY2UgKi8KPiAgCXJldCA9IGRl dm1fY291bnRlcl9hZGQoZGV2LCBjb3VudGVyKTsKPiAgCWlmIChyZXQgPCAwKQo+IGRpZmYgLS1n aXQgYS9pbmNsdWRlL2xpbnV4L21mZC9zdG0zMi10aW1lcnMuaCBiL2luY2x1ZGUvbGludXgvbWZk L3N0bTMyLXRpbWVycy5oCj4gaW5kZXggNWY1YzQzZmQ2OWRkLi4xYjk0MzI1ZmViYjMgMTAwNjQ0 Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9tZmQvc3RtMzItdGltZXJzLmgKPiArKysgYi9pbmNsdWRl L2xpbnV4L21mZC9zdG0zMi10aW1lcnMuaAo+IEBAIC0zMSw2ICszMSw3IEBACj4gICNkZWZpbmUg VElNX0JEVFIJMHg0NAkvKiBCcmVhayBhbmQgRGVhZC1UaW1lIFJlZyAqLwo+ICAjZGVmaW5lIFRJ TV9EQ1IJCTB4NDgJLyogRE1BIGNvbnRyb2wgcmVnaXN0ZXIgICAgKi8KPiAgI2RlZmluZSBUSU1f RE1BUgkweDRDCS8qIERNQSByZWdpc3RlciBmb3IgdHJhbnNmZXIgKi8KPiArI2RlZmluZSBUSU1f VElTRUwJMHg2OAkvKiBJbnB1dCBTZWxlY3Rpb24gICAgICAgICAqLwo+ICAKPiAgI2RlZmluZSBU SU1fQ1IxX0NFTglCSVQoMCkJLyogQ291bnRlciBFbmFibGUJICAgKi8KPiAgI2RlZmluZSBUSU1f Q1IxX0RJUglCSVQoNCkgIC8qIENvdW50ZXIgRGlyZWN0aW9uCSAgICovCj4gCj4gYmFzZS1jb21t aXQ6IGZlMTVjMjZlZTI2ZWZhMTE3NDFhN2I2MzJlOWYyM2IwMWFjYTRjYzYKPiAtLSAKPiAyLjM5 LjIKPiAKCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK