From: Lee Jones <lee@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Pavel Machek <pavel@ucw.cz>,
Johannes Berg <johannes@sipsolutions.net>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH 0/4] Fix oops about sleeping in led_trigger_blink()
Date: Thu, 20 Apr 2023 14:56:35 +0100 [thread overview]
Message-ID: <20230420135635.GE996918@google.com> (raw)
In-Reply-To: <9ba72334-6c3a-e8cd-0692-b30278c4a88d@redhat.com>
On Thu, 20 Apr 2023, Hans de Goede wrote:
> Hi Lee,
>
> On 4/20/23 13:36, Lee Jones wrote:
> > On Wed, 12 Apr 2023, Hans de Goede wrote:
> >
> >> Hi All,
> >>
> >> Here is a patch series to fix an oops about sleeping in led_trigger_blink()
> >> + one other small bugfix.
> >>
> >> Patches 1-3 should arguably have a:
> >>
> >> Fixes: 0b9536c95709 ("leds: Add ability to blink via simple trigger")
> >>
> >> tag, but Fixes tags tend to lead to patches getting automatically added
> >> to the stable series and I would prefer to see this series get some
> >> significant testing time in mainline first, so I have chosen to omit
> >> the tag.
> >
> > With subjects with the word "fix" in it, they will be hoovered up by the
> > Stable auto-picker anyway.
>
> Ok, in that case patch 3 should have:
>
> Fixes: 0b9536c95709 ("leds: Add ability to blink via simple trigger")
>
> Patches 1-2 are more preparation patches for this. Patch 2 does
> fix another race, but I'm not sure we ever hit that.
>
> Can you add the fixes tag while merging these, or do you
> want a v2 of this series ?
I'm holding out for either a Pavel review or some Tested-by's suggested
by Jacek.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-04-20 13:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 21:58 [PATCH 0/4] Fix oops about sleeping in led_trigger_blink() Hans de Goede
2023-04-12 21:58 ` [PATCH 1/4] leds: Change led_trigger_blink[_oneshot]() delay parameters to pass-by-value Hans de Goede
2023-05-10 11:57 ` Lee Jones
2023-05-10 15:32 ` Hans de Goede
2023-04-12 21:58 ` [PATCH 2/4] leds: Fix set_brightness_delayed() race Hans de Goede
2023-04-12 21:58 ` [PATCH 3/4] leds: Fix oops about sleeping in led_trigger_blink() Hans de Goede
2023-04-12 21:58 ` [PATCH 4/4] leds: Clear LED_INIT_DEFAULT_TRIGGER when clearing current trigger Hans de Goede
2023-04-16 15:36 ` [PATCH 0/4] Fix oops about sleeping in led_trigger_blink() Jacek Anaszewski
2023-04-20 11:36 ` Lee Jones
2023-04-20 12:04 ` Hans de Goede
2023-04-20 13:56 ` Lee Jones [this message]
2023-04-25 14:03 ` Hans de Goede
2023-04-26 14:34 ` Lee Jones
2023-05-04 13:08 ` Yauhen Kharuzhy
2023-05-09 8:58 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420135635.GE996918@google.com \
--to=lee@kernel.org \
--cc=hdegoede@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.