From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEE7FC77B72 for ; Thu, 20 Apr 2023 16:02:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2VGyCHZR0aw7CL0CuVU5n3uR4rzbU7DoxyLoiUtfV+E=; b=O7gNOzqjMf4YtE mJ+SLU0SKmKBqK0qTUAcCZ9VBUkzmLUwhI5d869Co+hixVO1TVgBFS2eqFNYWgoDubgaRhmYEnTE4 AUR6YL3adcE1ZiBNDU90UWYLFZca3Mf6QKAsD4SgwKUpaqxkCtrevqra8mE7xoS4tdkDp7SPQY0UN u/QdibdtHe/ECk6OlajVM7rC/iAIVqVp6nYyTA0i9c6E77cf5moWsIiKg4t8WZXRrTWeLPzND4hpa aAzrmV/F1EvDveJx/XDHwG7ABcnexkYzYi0FKXtxL43MRgzPnTpbUdFhVyPSjEFqqrqeWAUYvhAh+ mxcpccCLNgYL6fh6BT7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ppWiz-008UKY-2i; Thu, 20 Apr 2023 16:01:33 +0000 Received: from mail-oo1-f49.google.com ([209.85.161.49]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ppWix-008UK3-0O for linux-arm-kernel@lists.infradead.org; Thu, 20 Apr 2023 16:01:32 +0000 Received: by mail-oo1-f49.google.com with SMTP id k1-20020a4ab281000000b0053e8b5524abso798347ooo.2 for ; Thu, 20 Apr 2023 09:01:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682006490; x=1684598490; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mIpdpe/NpR/Ih+cQndC/G+rH56/6XJaiFLeSU8K5oA0=; b=iqdWt1ePLZ7o673Kmcmiz7N0CI4dXDXNF7nPWzTaHoYWJwxfLNTxhVyxTshT5oCAHg T08vOahbBaN8/KAkfTfCMHJra0M+kdnVWQxM7GVOjoEfSPvjsBVgmU6JKHDX6QGTB1+q Ix6MntFD06tm4JH4zvLaCaZqADZOv+ZNjAdNNxwO67LL+OvVuD0/a4PIBRKH7NycDRt5 fKh+Au6zobKCgz6C+i5d0eIziLETZtcW2PjVDbF1U+PcicdfYyq/Fnkm4Pn3W3W+mjx7 8osxu5ukq/73tIq/Ig/wEX1h19cGULYymPgU2ewZse7csT/wU2OlM9YX/+O6FvAkfslU 5MgQ== X-Gm-Message-State: AAQBX9cdH8H81P57wcVOrVPcaVRSG57ligvDHy83sHUKsJLbRtCQvD/O DUN49D9EkOILMzGjiene6A== X-Google-Smtp-Source: AKy350bt+0X2w1Rb34a72ni3IOj9CQFLCcOcDdhi78zN3O8KOC08bs/0RKiA7zeCHsbuuGFdNtrbGw== X-Received: by 2002:a4a:95af:0:b0:546:1d7b:20be with SMTP id o44-20020a4a95af000000b005461d7b20bemr765333ooi.7.1682006489810; Thu, 20 Apr 2023 09:01:29 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id v12-20020a4aad8c000000b0054542d3219asm748526oom.11.2023.04.20.09.01.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 09:01:29 -0700 (PDT) Received: (nullmailer pid 2950580 invoked by uid 1000); Thu, 20 Apr 2023 16:01:28 -0000 Date: Thu, 20 Apr 2023 11:01:28 -0500 From: Rob Herring To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Krzysztof Kozlowski , Srinivas Kandagatla , Florian Fainelli , Hauke Mehrtens , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH 1/3] dt-bindings: nvmem: brcm,nvram: add #nvmem-cell-cells for MACs Message-ID: <20230420160128.GA2945386-robh@kernel.org> References: <20230406110804.12024-1-zajec5@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230406110804.12024-1-zajec5@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230420_090131_160548_95966939 X-CRM114-Status: GOOD ( 20.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBcHIgMDYsIDIwMjMgYXQgMDE6MDg6MDJQTSArMDIwMCwgUmFmYcWCIE1pxYJlY2tp IHdyb3RlOgo+IEZyb206IFJhZmHFgiBNacWCZWNraSA8cmFmYWxAbWlsZWNraS5wbD4KPiAKPiBC cm9hZGNvbSdzIE5WUkFNIGNvbnRhaW5zIE1BQ3MgZm9yIEV0aGVybmV0IGludGVyZmFjZXMuIFRo b3NlIE1BQ3MgYXJlCj4gdXN1YWxseSBiYXNlIGFkZHJlc3NlcyB0aGF0IGFyZSBhbHNvIHVzZWQg Zm9yIGNhbGN1bGF0aW5nIG90aGVyIE1BQ3MuCj4gCj4gRm9yIGV4YW1wbGUgaWYgYSByb3V0ZXIg dmVuZG9yIGRlY2lkZWQgdG8gdXNlIGdtYWMwIGl0IG1vc3QgbGlrZWx5Cj4gcHJvZ3JhbW1lZCBO VlJBTSBvZiBlYWNoIHVuaXQgd2l0aCBhIHByb3BlciAiZXQwbWFjYWRkciIgdmFsdWUuIFRoYXQg aXMKPiBhIGJhc2UuCj4gCj4gRXRoZXJuZXQgaW50ZXJmYWNlIGlzIHVzdWFsbHkgY29ubmVjdGVk IHRvIHN3aXRjaCBwb3J0LiBTd2l0Y2ggdXN1YWxseQo+IGluY2x1ZGVzIGZldyBMQU4gcG9ydHMg YW5kIGEgV0FOIHBvcnQuIE1BQyBvZiBXQU4gcG9ydCBnZXRzIGNhbGN1bGF0ZWQKPiBhcyByZWxh dGl2ZSBhZGRyZXNzIHRvIHRoZSBpbnRlcmZhY2Ugb25lLiBPZmZzZXQgdmFyaWVzIGRlcGVuZGlu ZyBvbgo+IGRldmljZSBtb2RlbC4KPiAKPiBXaXJlbGVzcyBNQUNzIG1heSBhbHNvIG5lZWQgdG8g YmUgY2FsY3VsYXRlZCB1c2luZyByZWxldmFudCBvZmZzZXRzLgo+IAo+IFRvIHN1cHBvcnQgYWxs IHRob3NlIHNjZW5hcmlvcyBsZXQgTUFDIE5WTUVNIGNlbGxzIGJlIHJlZmVyZW5jZWQgd2l0aCBh bgo+IGluZGV4IHNwZWNpZnlpbmcgTUFDIG9mZnNldC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBSYWZh xYIgTWnFgmVja2kgPHJhZmFsQG1pbGVja2kucGw+Cj4gLS0tCj4gIC4uLi9kZXZpY2V0cmVlL2Jp bmRpbmdzL252bWVtL2JyY20sbnZyYW0ueWFtbCAgICAgICAgfCAxMiArKysrKysrKysrKysKPiAg MSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL252bWVtL2JyY20sbnZyYW0ueWFtbCBiL0RvY3Vt ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9udm1lbS9icmNtLG52cmFtLnlhbWwKPiBpbmRl eCAzNmRlZjcxMjhmY2EuLmE5MjFlMDVjYzU0NCAxMDA2NDQKPiAtLS0gYS9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvbnZtZW0vYnJjbSxudnJhbS55YW1sCj4gKysrIGIvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL252bWVtL2JyY20sbnZyYW0ueWFtbAo+IEBAIC0z NiwxNCArMzYsMjYgQEAgcHJvcGVydGllczoKPiAgICBldDBtYWNhZGRyOgo+ICAgICAgdHlwZTog b2JqZWN0Cj4gICAgICBkZXNjcmlwdGlvbjogRmlyc3QgRXRoZXJuZXQgaW50ZXJmYWNlJ3MgTUFD IGFkZHJlc3MKPiArICAgIHByb3BlcnRpZXM6Cj4gKyAgICAgICIjbnZtZW0tY2VsbC1jZWxscyI6 Cj4gKyAgICAgICAgZGVzY3JpcHRpb246IFRoZSBmaXJzdCBhcmd1bWVudCBpcyBhIE1BQyBhZGRy ZXNzIG9mZnNldC4KPiArICAgICAgICBjb25zdDogMQoKTm90IGEgbmV3IGlzc3VlLCBidXQgdGhl c2Ugbm9kZXMgYXJlIG1pc3NpbmcgJ2FkZGl0aW9uYWxQcm9wZXJ0aWVzOiAKZmFsc2UnLiBDYW4g eW91IGFkZCB0aGF0LiBXaXRoIHRoYXQsCgpSZXZpZXdlZC1ieTogUm9iIEhlcnJpbmcgPHJvYmhA a2VybmVsLm9yZz4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0E90C77B72 for ; Thu, 20 Apr 2023 16:01:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232835AbjDTQBf (ORCPT ); Thu, 20 Apr 2023 12:01:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232605AbjDTQBb (ORCPT ); Thu, 20 Apr 2023 12:01:31 -0400 Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE928110; Thu, 20 Apr 2023 09:01:30 -0700 (PDT) Received: by mail-oo1-f44.google.com with SMTP id c17-20020a4aa4d1000000b005418821052aso783375oom.6; Thu, 20 Apr 2023 09:01:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682006490; x=1684598490; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mIpdpe/NpR/Ih+cQndC/G+rH56/6XJaiFLeSU8K5oA0=; b=WijXUS6T6QWuDPimJfAW988Zx7ImcnbTa7nQW0fqT57JquB7KfWSN9F82unEbyd4Bl qM7+Vag7UXbuiTg8k62pqMkygod26HcHvCGelhL59AcH5yZXAuD7wgSFktvrw1SYEbKD p32FIUkSGUHXFFiqkfROs3JcK7tiQQxULGANkn0+d78/NVlZduLAsTtfL+nUmLVyJSRS RE8ThYit8mhFqYLXdmII1r6S0rI+6hQ7kB+0SPl9Qo1w74fLiXo2BGoSd+YeUlOs6Gkv 9aAZ02X1vGCEpEaPDlYTKdQVcBqhPG4M8M/z0LY/g6hNoKp8iV/QQHNaDeWT9jU5kwhg vzBg== X-Gm-Message-State: AAQBX9fmjKMBo+bX6s7x2+b823EXKaGtO90ZeF37RszS1jfYYBq7nWP7 +lZX2HO5mBqOWiqFWfBYVg== X-Google-Smtp-Source: AKy350bt+0X2w1Rb34a72ni3IOj9CQFLCcOcDdhi78zN3O8KOC08bs/0RKiA7zeCHsbuuGFdNtrbGw== X-Received: by 2002:a4a:95af:0:b0:546:1d7b:20be with SMTP id o44-20020a4a95af000000b005461d7b20bemr765333ooi.7.1682006489810; Thu, 20 Apr 2023 09:01:29 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id v12-20020a4aad8c000000b0054542d3219asm748526oom.11.2023.04.20.09.01.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 09:01:29 -0700 (PDT) Received: (nullmailer pid 2950580 invoked by uid 1000); Thu, 20 Apr 2023 16:01:28 -0000 Date: Thu, 20 Apr 2023 11:01:28 -0500 From: Rob Herring To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Krzysztof Kozlowski , Srinivas Kandagatla , Florian Fainelli , Hauke Mehrtens , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH 1/3] dt-bindings: nvmem: brcm,nvram: add #nvmem-cell-cells for MACs Message-ID: <20230420160128.GA2945386-robh@kernel.org> References: <20230406110804.12024-1-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230406110804.12024-1-zajec5@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Apr 06, 2023 at 01:08:02PM +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > Broadcom's NVRAM contains MACs for Ethernet interfaces. Those MACs are > usually base addresses that are also used for calculating other MACs. > > For example if a router vendor decided to use gmac0 it most likely > programmed NVRAM of each unit with a proper "et0macaddr" value. That is > a base. > > Ethernet interface is usually connected to switch port. Switch usually > includes few LAN ports and a WAN port. MAC of WAN port gets calculated > as relative address to the interface one. Offset varies depending on > device model. > > Wireless MACs may also need to be calculated using relevant offsets. > > To support all those scenarios let MAC NVMEM cells be referenced with an > index specifying MAC offset. > > Signed-off-by: Rafał Miłecki > --- > .../devicetree/bindings/nvmem/brcm,nvram.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > index 36def7128fca..a921e05cc544 100644 > --- a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > +++ b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > @@ -36,14 +36,26 @@ properties: > et0macaddr: > type: object > description: First Ethernet interface's MAC address > + properties: > + "#nvmem-cell-cells": > + description: The first argument is a MAC address offset. > + const: 1 Not a new issue, but these nodes are missing 'additionalProperties: false'. Can you add that. With that, Reviewed-by: Rob Herring