All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v2 0/3] vhost: memslot handling improvements
Date: Thu, 20 Apr 2023 16:28:05 +0200	[thread overview]
Message-ID: <20230420162805.6781701b@imammedo.users.ipa.redhat.com> (raw)
In-Reply-To: <20230316153658.214487-1-david@redhat.com>

On Thu, 16 Mar 2023 16:36:55 +0100
David Hildenbrand <david@redhat.com> wrote:

> Following up on my previous work to make virtio-mem consume multiple
> memslots dynamically [1] that requires precise accounting between used vs.
> reserved memslots, I realized that vhost makes this extra hard by
> filtering out some memory region sections (so they don't consume a
> memslot) in the vhost-user case, which messes up the whole memslot
> accounting.
> 
> This series fixes what I found to be broken and prepares for more work on
> [1]. Further, it cleanes up the merge checks that I consider unnecessary.

Acked-by: Igor Mammedov <imammedo@redhat.com>

> 
> [1] https://lkml.kernel.org/r/20211027124531.57561-8-david@redhat.com
> 
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> 
> v1 -> v2:
> - "vhost: Rework memslot filtering and fix "used_memslot" tracking"
> -- New approach: keep filtering, but make filtering less generic and
>    track separately. This should keep any existing setups working.
> - "softmmu/physmem: Fixup qemu_ram_block_from_host() documentation"
> -- As requested by Igor
> 
> David Hildenbrand (3):
>   vhost: Rework memslot filtering and fix "used_memslot" tracking
>   vhost: Remove vhost_backend_can_merge() callback
>   softmmu/physmem: Fixup qemu_ram_block_from_host() documentation
> 
>  hw/virtio/vhost-user.c            | 21 ++---------
>  hw/virtio/vhost-vdpa.c            |  1 -
>  hw/virtio/vhost.c                 | 62 ++++++++++++++++++++++++-------
>  include/exec/cpu-common.h         | 15 ++++++++
>  include/hw/virtio/vhost-backend.h |  9 +----
>  softmmu/physmem.c                 | 17 ---------
>  6 files changed, 68 insertions(+), 57 deletions(-)
> 



  parent reply	other threads:[~2023-04-20 14:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-16 15:36 [PATCH v2 0/3] vhost: memslot handling improvements David Hildenbrand
2023-03-16 15:36 ` [PATCH v2 1/3] vhost: Rework memslot filtering and fix "used_memslot" tracking David Hildenbrand
2023-03-16 15:36 ` [PATCH v2 2/3] vhost: Remove vhost_backend_can_merge() callback David Hildenbrand
2023-03-16 15:36 ` [PATCH v2 3/3] softmmu/physmem: Fixup qemu_ram_block_from_host() documentation David Hildenbrand
2023-04-20 14:27   ` Igor Mammedov
2023-04-20 14:28 ` Igor Mammedov [this message]
2023-05-03 14:16   ` [PATCH v2 0/3] vhost: memslot handling improvements David Hildenbrand
2023-05-03 14:23     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230420162805.6781701b@imammedo.users.ipa.redhat.com \
    --to=imammedo@redhat.com \
    --cc=david@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.