All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Guo Xuenan <guoxuenan@huawei.com>
Cc: djwong@kernel.org, dchinner@redhat.com,
	linux-xfs@vger.kernel.org, sandeen@redhat.com,
	guoxuenan@huaweicloud.com, houtao1@huawei.com,
	fangwei1@huawei.com, jack.qiu@huawei.com, yi.zhang@huawei.com
Subject: Re: [PATCH 3/3] xfs: clean up some unnecessary xfs_stack_trace
Date: Fri, 21 Apr 2023 16:18:42 +1000	[thread overview]
Message-ID: <20230421061842.GC3223426@dread.disaster.area> (raw)
In-Reply-To: <20230421033142.1656296-4-guoxuenan@huawei.com>

On Fri, Apr 21, 2023 at 11:31:42AM +0800, Guo Xuenan wrote:
> With xfs print level parsing correctly, these duplicate dump
> information can be removed.
> 
> Signed-off-by: Guo Xuenan <guoxuenan@huawei.com>

Looks good when considering the previous patch would result in
emitting the stacks in each of these situations.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2023-04-21  6:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21  3:31 [PATCH 0/3] xfs fixes and clean up Guo Xuenan
2023-04-21  3:31 ` [PATCH 1/3] xfs: fix leak memory when xfs_attr_inactive fails Guo Xuenan
2023-04-21  7:49   ` Dave Chinner
2023-04-21 15:32     ` Darrick J. Wong
2023-04-21 20:54       ` Dave Chinner
2023-05-05  8:16   ` kernel test robot
2023-05-05 11:27     ` Guo Xuenan
2023-04-21  3:31 ` [PATCH 2/3] xfs: fix xfs print level wrong parsing Guo Xuenan
2023-04-21  6:17   ` Dave Chinner
2023-04-21  7:01     ` Guo Xuenan
2023-04-21  3:31 ` [PATCH 3/3] xfs: clean up some unnecessary xfs_stack_trace Guo Xuenan
2023-04-21  6:18   ` Dave Chinner [this message]
2023-04-21  3:50 ` [PATCH 1/3] xfs: fix leak memory when xfs_attr_inactive fails Guo Xuenan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230421061842.GC3223426@dread.disaster.area \
    --to=david@fromorbit.com \
    --cc=dchinner@redhat.com \
    --cc=djwong@kernel.org \
    --cc=fangwei1@huawei.com \
    --cc=guoxuenan@huawei.com \
    --cc=guoxuenan@huaweicloud.com \
    --cc=houtao1@huawei.com \
    --cc=jack.qiu@huawei.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.