From: Lee Jones <lee@kernel.org>
To: Benjamin Bara <bbara93@gmail.com>
Cc: benjamin.bara@skidata.com, dmitry.osipenko@collabora.com,
jonathanh@nvidia.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
peterz@infradead.org, rafael.j.wysocki@intel.com,
richard.leitner@linux.dev, treding@nvidia.com, wsa@kernel.org
Subject: Re: [PATCH v5 6/6] mfd: tps6586x: register restart handler
Date: Fri, 21 Apr 2023 08:42:22 +0100 [thread overview]
Message-ID: <20230421074222.GP996918@google.com> (raw)
In-Reply-To: <20230421073250.1203077-1-bbara93@gmail.com>
On Fri, 21 Apr 2023, Benjamin Bara wrote:
> On Fri, 21 Apr 2023 at 09:25, Lee Jones <lee@kernel.org> wrote:
> > The confusing part for me, the reader, was that both say "will take at
> > least 10ms" or words to that effect, but they sleep for a different
> > amount of time.
>
> Yep, got it. For the next version, I will rewrite to:
> "Put the PMIC into * state. Data sheet states that this takes at least 20ms.
> As this is board-specific, add some buffer to prevent the timeout error."
> and change to -ETIMEDOUT instead of -ETIME.
No need to be more verbose.
Stick to the one liner, just be more clear about the timings.
The reader can see that you've added a little buffer without explanation.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-04-21 7:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 11:09 [PATCH v5 0/6] mfd: tps6586x: register restart handler Benjamin Bara
2023-04-18 11:10 ` [PATCH v5 1/6] kernel/reboot: emergency_restart: set correct system_state Benjamin Bara
2023-04-18 11:10 ` [PATCH v5 2/6] i2c: core: run atomic i2c xfer when !preemptible Benjamin Bara
2023-04-18 11:10 ` [PATCH v5 3/6] kernel/reboot: add device to sys_off_handler Benjamin Bara
2023-04-18 11:10 ` [PATCH v5 4/6] kernel/reboot: sys_off_notify: always return NOTIFY_DONE Benjamin Bara
2023-04-18 11:10 ` [PATCH v5 5/6] mfd: tps6586x: use devm-based power off handler Benjamin Bara
2023-04-20 14:02 ` Lee Jones
2023-04-18 11:10 ` [PATCH v5 6/6] mfd: tps6586x: register restart handler Benjamin Bara
2023-04-20 14:04 ` Lee Jones
2023-04-20 14:32 ` Benjamin Bara
2023-04-21 7:25 ` Lee Jones
2023-04-21 7:32 ` Benjamin Bara
2023-04-21 7:42 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230421074222.GP996918@google.com \
--to=lee@kernel.org \
--cc=bbara93@gmail.com \
--cc=benjamin.bara@skidata.com \
--cc=dmitry.osipenko@collabora.com \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=richard.leitner@linux.dev \
--cc=treding@nvidia.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.