Re: [PATCH] firmware:Remove unnecessary (void*) conversions

[kernel test robot <lkp@intel.com>]

Hi yunchuan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.3-rc7 next-20230419]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/yunchuan/firmware-Remove-unnecessary-void-conversions/20230420-154004
patch link:    https://lore.kernel.org/r/20230420073751.1031944-1-yunchuan%40nfschina.com
patch subject: [PATCH] firmware:Remove unnecessary (void*) conversions
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230421/202304210825.cb223IAt-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/1dee3a7afbb402fc49f0af9eeb312f221e99fab6
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review yunchuan/firmware-Remove-unnecessary-void-conversions/20230420-154004
        git checkout 1dee3a7afbb402fc49f0af9eeb312f221e99fab6
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304210825.cb223IAt-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/firmware/turris-mox-rwtm.c: In function 'mox_hwrng_read':
>> drivers/firmware/turris-mox-rwtm.c:286:33: warning: initialization of 'struct mox_rwtm *' from 'long unsigned int' makes pointer from integer without a cast [-Wint-conversion]
     286 |         struct mox_rwtm *rwtm = rng->priv;
         |                                 ^~~


vim +286 drivers/firmware/turris-mox-rwtm.c

   283	
   284	static int mox_hwrng_read(struct hwrng *rng, void *data, size_t max, bool wait)
   285	{
 > 286		struct mox_rwtm *rwtm = rng->priv;
   287		struct armada_37xx_rwtm_tx_msg msg;
   288		int ret;
   289	
   290		if (max > 4096)
   291			max = 4096;
   292	
   293		msg.command = MBOX_CMD_GET_RANDOM;
   294		msg.args[0] = 1;
   295		msg.args[1] = rwtm->buf_phys;
   296		msg.args[2] = (max + 3) & ~3;
   297	
   298		if (!wait) {
   299			if (!mutex_trylock(&rwtm->busy))
   300				return -EBUSY;
   301		} else {
   302			mutex_lock(&rwtm->busy);
   303		}
   304	
   305		ret = mbox_send_message(rwtm->mbox, &msg);
   306		if (ret < 0)
   307			goto unlock_mutex;
   308	
   309		ret = wait_for_completion_interruptible(&rwtm->cmd_done);
   310		if (ret < 0)
   311			goto unlock_mutex;
   312	
   313		ret = mox_get_status(MBOX_CMD_GET_RANDOM, rwtm->reply.retval);
   314		if (ret < 0)
   315			goto unlock_mutex;
   316	
   317		memcpy(data, rwtm->buf, max);
   318		ret = max;
   319	
   320	unlock_mutex:
   321		mutex_unlock(&rwtm->busy);
   322		return ret;
   323	}
   324	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests