Re: [RFC PATCH 5/5] SUNRPC: store GSS creds in keyrings

[kernel test robot <lkp@intel.com>]

Hi Scott,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on trondmy-nfs/linux-next]
[also build test ERROR on linus/master v6.3-rc7 next-20230420]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Scott-Mayhew/keys-export-keyring_ptr_to_key/20230421-042202
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
patch link:    https://lore.kernel.org/r/20230420202004.239116-6-smayhew%40redhat.com
patch subject: [RFC PATCH 5/5] SUNRPC: store GSS creds in keyrings
config: arc-defconfig (https://download.01.org/0day-ci/archive/20230421/202304211200.n2ErV9D8-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/6a654188690846a7c5e1de83e390a2bce53d79a8
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Scott-Mayhew/keys-export-keyring_ptr_to_key/20230421-042202
        git checkout 6a654188690846a7c5e1de83e390a2bce53d79a8
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304211200.n2ErV9D8-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/trace/define_trace.h:102,
                    from include/trace/events/rpcgss.h:726,
                    from net/sunrpc/auth_gss/trace.c:14:
   include/trace/events/rpcgss.h: In function 'trace_event_raw_event_rpcgss_request_key_result':
>> include/trace/events/rpcgss.h:654:46: error: invalid use of undefined type 'const struct key'
     654 |                         __entry->serial = key->serial;
         |                                              ^~
   include/trace/trace_events.h:402:11: note: in definition of macro 'DECLARE_EVENT_CLASS'
     402 |         { assign; }                                                     \
         |           ^~~~~~
   include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
      44 |                              PARAMS(assign),                   \
         |                              ^~~~~~
   include/trace/events/rpcgss.h:629:1: note: in expansion of macro 'TRACE_EVENT'
     629 | TRACE_EVENT(rpcgss_request_key_result,
         | ^~~~~~~~~~~
   include/trace/events/rpcgss.h:645:9: note: in expansion of macro 'TP_fast_assign'
     645 |         TP_fast_assign(
         |         ^~~~~~~~~~~~~~
   In file included from include/trace/define_trace.h:103:
   include/trace/events/rpcgss.h: In function 'perf_trace_rpcgss_request_key_result':
>> include/trace/events/rpcgss.h:654:46: error: invalid use of undefined type 'const struct key'
     654 |                         __entry->serial = key->serial;
         |                                              ^~
   include/trace/perf.h:51:11: note: in definition of macro 'DECLARE_EVENT_CLASS'
      51 |         { assign; }                                                     \
         |           ^~~~~~
   include/trace/trace_events.h:44:30: note: in expansion of macro 'PARAMS'
      44 |                              PARAMS(assign),                   \
         |                              ^~~~~~
   include/trace/events/rpcgss.h:629:1: note: in expansion of macro 'TRACE_EVENT'
     629 | TRACE_EVENT(rpcgss_request_key_result,
         | ^~~~~~~~~~~
   include/trace/events/rpcgss.h:645:9: note: in expansion of macro 'TP_fast_assign'
     645 |         TP_fast_assign(
         |         ^~~~~~~~~~~~~~


vim +654 include/trace/events/rpcgss.h

   628	
   629	TRACE_EVENT(rpcgss_request_key_result,
   630		TP_PROTO(
   631			const struct auth_cred *acred,
   632			const struct key *key
   633		),
   634	
   635		TP_ARGS(acred, key),
   636	
   637		TP_STRUCT__entry(
   638			__field(u32, uid)
   639			__string(principal, acred->principal)
   640			__field(const void *, credkey)
   641			__field(int, serial)
   642			__field(int, error)
   643		),
   644	
   645		TP_fast_assign(
   646			__entry->uid = from_kuid(&init_user_ns, acred->cred->fsuid);
   647			__assign_str(principal, acred->principal);
   648			if (IS_ERR(key)) {
   649				__entry->credkey = 0;
   650				__entry->serial = 0;
   651				__entry->error = PTR_ERR(key);
   652			} else {
   653				__entry->credkey = key;
 > 654				__entry->serial = key->serial;
   655				__entry->error = 0;
   656			}
   657		),
   658	
   659		TP_printk(" for acred { uid %u princ %s }, key=%px serial=%d error=%d",
   660			__entry->uid, __get_str(principal), __entry->credkey,
   661			__entry->serial, __entry->error)
   662	);
   663	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests