From: kernel test robot <lkp@intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v2 8/8] sched: drop for_each_numa_hop_mask()
Date: Fri, 21 Apr 2023 16:38:26 +0800 [thread overview]
Message-ID: <202304211617.4nr99gar-lkp@intel.com> (raw)
In-Reply-To: <20230420051946.7463-9-yury.norov@gmail.com>
Hi Yury,
kernel test robot noticed the following build errors:
[auto build test ERROR on net/main]
[also build test ERROR on linus/master v6.3-rc7]
[cannot apply to tip/sched/core horms-ipvs/master net-next/main next-20230420]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yury-Norov/lib-find-add-find_next_and_andnot_bit/20230420-132247
patch link: https://lore.kernel.org/r/20230420051946.7463-9-yury.norov%40gmail.com
patch subject: [PATCH v2 8/8] sched: drop for_each_numa_hop_mask()
config: i386-randconfig-a013 (https://download.01.org/0day-ci/archive/20230421/202304211617.4nr99gar-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/2425882bb68586aad08582c2efbb860a78e1b8e3
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Yury-Norov/lib-find-add-find_next_and_andnot_bit/20230420-132247
git checkout 2425882bb68586aad08582c2efbb860a78e1b8e3
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/intel/ice/ kernel/rcu/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304211617.4nr99gar-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/net/ethernet/intel/ice/ice_base.c:664:23: error: no member named 'numa_node' in 'struct device'
int numa_node = dev->numa_node;
~~~ ^
>> drivers/net/ethernet/intel/ice/ice_base.c:681:2: error: implicit declaration of function 'for_each_numa_hop_mask' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
for_each_numa_hop_mask(aff_mask, numa_node) {
^
>> drivers/net/ethernet/intel/ice/ice_base.c:681:45: error: expected ';' after expression
for_each_numa_hop_mask(aff_mask, numa_node) {
^
;
3 errors generated.
vim +/for_each_numa_hop_mask +681 drivers/net/ethernet/intel/ice/ice_base.c
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 652
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 653 /**
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 654 * ice_vsi_alloc_q_vectors - Allocate memory for interrupt vectors
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 655 * @vsi: the VSI being configured
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 656 *
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 657 * We allocate one q_vector per queue interrupt. If allocation fails we
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 658 * return -ENOMEM.
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 659 */
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 660 int ice_vsi_alloc_q_vectors(struct ice_vsi *vsi)
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 661 {
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 662 cpumask_t *aff_mask, *last_aff_mask = cpu_none_mask;
3306f79f428e85 Anirudh Venkataramanan 2020-02-06 663 struct device *dev = ice_pf_to_dev(vsi->back);
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 @664 int numa_node = dev->numa_node;
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 665 u16 v_idx, cpu = 0;
88865fc4bbd61e Karol Kolacinski 2020-05-07 666 int err;
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 667
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 668 if (vsi->q_vectors[0]) {
4015d11e4b9720 Brett Creeley 2019-11-08 669 dev_dbg(dev, "VSI %d has existing q_vectors\n", vsi->vsi_num);
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 670 return -EEXIST;
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 671 }
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 672
3306f79f428e85 Anirudh Venkataramanan 2020-02-06 673 for (v_idx = 0; v_idx < vsi->num_q_vectors; v_idx++) {
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 674 err = ice_vsi_alloc_q_vector(vsi, v_idx);
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 675 if (err)
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 676 goto err_out;
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 677 }
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 678
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 679 v_idx = 0;
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 680
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 @681 for_each_numa_hop_mask(aff_mask, numa_node) {
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 682 for_each_cpu_andnot(cpu, aff_mask, last_aff_mask) {
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 683 if (v_idx >= vsi->num_q_vectors)
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 684 goto out;
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 685
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 686 if (cpu_online(cpu)) {
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 687 cpumask_set_cpu(cpu, &vsi->q_vectors[v_idx]->affinity_mask);
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 688 v_idx++;
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 689 }
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 690 }
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 691
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 692 last_aff_mask = aff_mask;
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 693 }
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 694
5dfb0e8f9fff34 Pawel Chmielewski 2023-02-16 695 out:
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 696 return 0;
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 697
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 698 err_out:
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 699 while (v_idx--)
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 700 ice_free_q_vector(vsi, v_idx);
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 701
4015d11e4b9720 Brett Creeley 2019-11-08 702 dev_err(dev, "Failed to allocate %d q_vector for VSI %d, ret=%d\n",
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 703 vsi->num_q_vectors, vsi->vsi_num, err);
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 704 vsi->num_q_vectors = 0;
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 705 return err;
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 706 }
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 707
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
prev parent reply other threads:[~2023-04-21 8:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 5:19 [PATCH v2 0/8] sched/topology: add for_each_numa_cpu() macro Yury Norov
2023-04-20 5:19 ` [PATCH v2 1/8] lib/find: add find_next_and_andnot_bit() Yury Norov
2023-04-20 5:19 ` [PATCH v2 2/8] sched/topology: introduce sched_numa_find_next_cpu() Yury Norov
2023-04-25 9:54 ` Valentin Schneider
2023-04-26 5:26 ` Yury Norov
2023-04-26 9:17 ` Valentin Schneider
2023-04-20 5:19 ` [PATCH v2 3/8] sched/topology: add for_each_numa_cpu() macro Yury Norov
2023-04-25 9:54 ` Valentin Schneider
2023-04-26 5:32 ` Yury Norov
2023-04-26 9:17 ` Valentin Schneider
2023-04-20 5:19 ` [PATCH v2 4/8] net: mlx5: switch comp_irqs_request() to using for_each_numa_cpu Yury Norov
2023-04-20 8:27 ` Tariq Toukan
2023-04-20 22:45 ` Yury Norov
2023-04-20 5:19 ` [PATCH v2 5/8] lib/cpumask: update comment to cpumask_local_spread() Yury Norov
2023-04-20 5:19 ` [PATCH v2 6/8] sched/topology: export sched_domains_numa_levels Yury Norov
2023-04-20 5:19 ` [PATCH v2 7/8] lib: add test for for_each_numa_{cpu,hop_mask}() Yury Norov
2023-04-24 17:09 ` Valentin Schneider
2023-04-26 5:50 ` Yury Norov
2023-04-26 9:17 ` Valentin Schneider
2023-04-26 20:51 ` Yury Norov
2023-04-27 9:35 ` Valentin Schneider
2023-04-20 5:19 ` [PATCH v2 8/8] sched: drop for_each_numa_hop_mask() Yury Norov
2023-04-20 10:15 ` kernel test robot
2023-04-21 8:38 ` kernel test robot
2023-04-21 8:38 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202304211617.4nr99gar-lkp@intel.com \
--to=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.