All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: virtio-dev@lists.oasis-open.org, pasic@linux.ibm.com,
	cohuck@redhat.com, virtio-comment@lists.oasis-open.org,
	shahafs@nvidia.com
Subject: [virtio-comment] Re: [PATCH v3 0/2] transport-pci: msix register desc improve
Date: Sat, 22 Apr 2023 06:10:32 -0400	[thread overview]
Message-ID: <20230422061011-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230421145434.83774-1-parav@nvidia.com>

On Fri, Apr 21, 2023 at 05:54:32PM +0300, Parav Pandit wrote:
> Problem:
> 
> Current wording queue_msix_vector and config_msix_vector says
> "for MSI-X", which is bit confusing.
> 
> config_msix_vector and queue_msix_vector are the msix vector
> number for configuration change and queue related interrupts.
> 
> Hence, reword it.

LGTM.
Given the amount of back and forth, I guess we should vote.

> ---
> changelog:
> v2->v3:
> - reword
> v1->v2:
> - rewrote to indicate MSI-X table entry index
> v0->v1:
> - added 'here'
> - dropped 'receiving'
> - dropped already merged patch for empty line
> 
> 
> Parav Pandit (2):
>   transport-pci: Improve config msix vector description
>   transport-pci: Improve queue msix vector register desc
> 
>  transport-pci.tex | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> -- 
> 2.26.2


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: virtio-dev@lists.oasis-open.org, pasic@linux.ibm.com,
	cohuck@redhat.com, virtio-comment@lists.oasis-open.org,
	shahafs@nvidia.com
Subject: [virtio-dev] Re: [PATCH v3 0/2] transport-pci: msix register desc improve
Date: Sat, 22 Apr 2023 06:10:32 -0400	[thread overview]
Message-ID: <20230422061011-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230421145434.83774-1-parav@nvidia.com>

On Fri, Apr 21, 2023 at 05:54:32PM +0300, Parav Pandit wrote:
> Problem:
> 
> Current wording queue_msix_vector and config_msix_vector says
> "for MSI-X", which is bit confusing.
> 
> config_msix_vector and queue_msix_vector are the msix vector
> number for configuration change and queue related interrupts.
> 
> Hence, reword it.

LGTM.
Given the amount of back and forth, I guess we should vote.

> ---
> changelog:
> v2->v3:
> - reword
> v1->v2:
> - rewrote to indicate MSI-X table entry index
> v0->v1:
> - added 'here'
> - dropped 'receiving'
> - dropped already merged patch for empty line
> 
> 
> Parav Pandit (2):
>   transport-pci: Improve config msix vector description
>   transport-pci: Improve queue msix vector register desc
> 
>  transport-pci.tex | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> -- 
> 2.26.2


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  parent reply	other threads:[~2023-04-22 10:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21 14:54 [virtio-comment] [PATCH v3 0/2] transport-pci: msix register desc improve Parav Pandit
2023-04-21 14:54 ` [virtio-dev] " Parav Pandit
2023-04-21 14:54 ` [virtio-comment] [PATCH v3 1/2] transport-pci: Improve config msix vector description Parav Pandit
2023-04-21 14:54   ` [virtio-dev] " Parav Pandit
2023-04-21 14:54 ` [virtio-comment] [PATCH v3 2/2] transport-pci: Improve queue msix vector register desc Parav Pandit
2023-04-21 14:54   ` [virtio-dev] " Parav Pandit
2023-04-22 10:10 ` Michael S. Tsirkin [this message]
2023-04-22 10:10   ` [virtio-dev] Re: [PATCH v3 0/2] transport-pci: msix register desc improve Michael S. Tsirkin
2023-04-24 15:15   ` [virtio-comment] " Parav Pandit
2023-04-24 15:15     ` [virtio-dev] " Parav Pandit
2023-04-28  4:10     ` [virtio-comment] " Parav Pandit
2023-04-28  4:10       ` [virtio-dev] " Parav Pandit
2023-04-28  4:46       ` [virtio-comment] " Michael S. Tsirkin
2023-04-28  4:46         ` [virtio-dev] " Michael S. Tsirkin
2023-04-28  4:47         ` [virtio-comment] " Michael S. Tsirkin
2023-04-28  4:47           ` [virtio-dev] " Michael S. Tsirkin
2023-04-28 13:35           ` [virtio-comment] " Parav Pandit
2023-04-28 13:35             ` [virtio-dev] " Parav Pandit
2023-05-10 18:29       ` [virtio-comment] " Parav Pandit
2023-05-10 18:29         ` [virtio-dev] " Parav Pandit
2023-05-19  6:29       ` [virtio-comment] " Michael S. Tsirkin
2023-05-19  6:29         ` [virtio-dev] " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230422061011-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=parav@nvidia.com \
    --cc=pasic@linux.ibm.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.