From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [Patch V10 2/3] tpm_tis-spi: Add hardware wait polling
Date: Sat, 22 Apr 2023 15:02:25 +0800 [thread overview]
Message-ID: <202304221457.9URN171w-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20230421091309.2672-3-kyarlagadda@nvidia.com>
References: <20230421091309.2672-3-kyarlagadda@nvidia.com>
TO: Krishna Yarlagadda <kyarlagadda@nvidia.com>
TO: jsnitsel@redhat.com
TO: robh+dt@kernel.org
TO: broonie@kernel.org
TO: peterhuewe@gmx.de
TO: jgg@ziepe.ca
TO: jarkko@kernel.org
TO: krzysztof.kozlowski+dt@linaro.org
TO: linux-spi@vger.kernel.org
TO: linux-tegra@vger.kernel.org
TO: linux-integrity@vger.kernel.org
TO: linux-kernel@vger.kernel.org
CC: thierry.reding@gmail.com
CC: jonathanh@nvidia.com
CC: skomatineni@nvidia.com
CC: ldewangan@nvidia.com
CC: Krishna Yarlagadda <kyarlagadda@nvidia.com>
Hi Krishna,
kernel test robot noticed the following build warnings:
[auto build test WARNING on broonie-spi/for-next]
[also build test WARNING on char-misc/char-misc-testing char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.3-rc7 next-20230421]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Krishna-Yarlagadda/spi-Add-TPM-HW-flow-flag/20230421-171759
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
patch link: https://lore.kernel.org/r/20230421091309.2672-3-kyarlagadda%40nvidia.com
patch subject: [Patch V10 2/3] tpm_tis-spi: Add hardware wait polling
:::::: branch date: 22 hours ago
:::::: commit date: 22 hours ago
config: arc-randconfig-m041-20230421 (https://download.01.org/0day-ci/archive/20230422/202304221457.9URN171w-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202304221457.9URN171w-lkp@intel.com/
smatch warnings:
drivers/char/tpm/tpm_tis_spi_main.c:137 tpm_tis_spi_transfer_half() error: uninitialized symbol 'ret'.
vim +/ret +137 drivers/char/tpm/tpm_tis_spi_main.c
8ab5e82afa969b drivers/char/tpm/tpm_tis_spi.c Stephen Boyd 2019-09-20 73
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 74 /*
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 75 * Half duplex controller with support for TPM wait state detection like
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 76 * Tegra QSPI need CMD, ADDR & DATA sent in single message to manage HW flow
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 77 * control. Each phase sent in different transfer for controller to idenity
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 78 * phase.
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 79 */
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 80 static int tpm_tis_spi_transfer_half(struct tpm_tis_data *data, u32 addr,
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 81 u16 len, u8 *in, const u8 *out)
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 82 {
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 83 struct tpm_tis_spi_phy *phy = to_tpm_tis_spi_phy(data);
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 84 struct spi_transfer spi_xfer[3];
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 85 struct spi_message m;
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 86 u8 transfer_len;
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 87 int ret;
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 88
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 89 while (len) {
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 90 transfer_len = min_t(u16, len, MAX_SPI_FRAMESIZE);
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 91
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 92 spi_message_init(&m);
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 93 phy->iobuf[0] = (in ? 0x80 : 0) | (transfer_len - 1);
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 94 phy->iobuf[1] = 0xd4;
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 95 phy->iobuf[2] = addr >> 8;
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 96 phy->iobuf[3] = addr;
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 97
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 98 memset(&spi_xfer, 0, sizeof(spi_xfer));
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 99
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 100 spi_xfer[0].tx_buf = phy->iobuf;
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 101 spi_xfer[0].len = 1;
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 102 spi_message_add_tail(&spi_xfer[0], &m);
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 103
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 104 spi_xfer[1].tx_buf = phy->iobuf + 1;
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 105 spi_xfer[1].len = 3;
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 106 spi_message_add_tail(&spi_xfer[1], &m);
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 107
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 108 if (out) {
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 109 spi_xfer[2].tx_buf = &phy->iobuf[4];
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 110 spi_xfer[2].rx_buf = NULL;
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 111 memcpy(&phy->iobuf[4], out, transfer_len);
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 112 out += transfer_len;
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 113 }
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 114
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 115 if (in) {
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 116 spi_xfer[2].tx_buf = NULL;
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 117 spi_xfer[2].rx_buf = &phy->iobuf[4];
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 118 }
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 119
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 120 spi_xfer[2].len = transfer_len;
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 121 spi_message_add_tail(&spi_xfer[2], &m);
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 122
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 123 reinit_completion(&phy->ready);
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 124
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 125 ret = spi_sync(phy->spi_device, &m);
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 126 if (ret < 0)
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 127 return ret;
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 128
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 129 if (in) {
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 130 memcpy(in, &phy->iobuf[4], transfer_len);
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 131 in += transfer_len;
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 132 }
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 133
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 134 len -= transfer_len;
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 135 }
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 136
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 @137 return ret;
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 138 }
c09d1b20ab5d73 drivers/char/tpm/tpm_tis_spi_main.c Krishna Yarlagadda 2023-04-21 139
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next reply other threads:[~2023-04-22 7:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-22 7:02 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-04-21 9:13 [Patch V10 0/3] Tegra TPM driver with HW flow control Krishna Yarlagadda
2023-04-21 9:13 ` [Patch V10 2/3] tpm_tis-spi: Add hardware wait polling Krishna Yarlagadda
2023-04-23 15:08 ` Jarkko Sakkinen
2023-04-24 11:56 ` Mark Brown
2023-04-24 13:11 ` Jarkko Sakkinen
2023-04-24 14:46 ` Thierry Reding
2023-04-24 15:18 ` Mark Brown
2023-04-24 15:31 ` Thierry Reding
2023-05-10 15:10 ` Krishna Yarlagadda
2023-05-24 12:43 ` Krishna Yarlagadda
2023-06-01 8:29 ` Thierry Reding
2023-06-01 11:04 ` Mark Brown
2023-06-01 12:36 ` Thierry Reding
2023-06-01 12:40 ` Mark Brown
2023-06-09 14:19 ` Jarkko Sakkinen
2023-06-09 14:22 ` Mark Brown
2023-06-09 15:12 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202304221457.9URN171w-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.