All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Knight <james.d.knight@live.com>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/4] package/libglib2: bump version to 2.76.1
Date: Sun, 23 Apr 2023 13:05:55 +0200	[thread overview]
Message-ID: <20230423110555.GE2696@scaer> (raw)
In-Reply-To: <SN4P221MB06822B245A5155FE545F0362A0609@SN4P221MB0682.NAMP221.PROD.OUTLOOK.COM>

James, All,

On 2023-04-21 10:12 -0400, James Knight spake thusly:
> - glib2 has moved from PCRE to PCRE2 [1].
> - Drop `fam` option since it no longer available [2].
> - Drop "0001-fix-compile-time-atomic-detection.patch" since upstream
>    patch was dropped and new atomic detection implementation has been
>    applied in this version.
> - Drop "0002-remove-cpp-requirement.patch" since upstream has modified
>    its Meson scripts to have any C++ usage as optional.
> - Drop "0003-Add-Wno-format-nonliteral-to-compiler-arguments.patch"
>    since change is available in this version.
> - Add new patch to address new Werror compilation errors [3].
> - Renamed "0004-*.patch" -> "0001-*.patch" since it should still be
>    applicable for its mentioned build case.
> 
> [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1938974
> [2]: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2570
> [3]: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3390
> 
> Signed-off-by: James Knight <james.d.knight@live.com>
> ---
[--SNIP--]
> diff --git a/package/libglib2/0002-Fix-error-format-in-gio-gunixconnection.c-part-2.patch b/package/libglib2/0002-Fix-error-format-in-gio-gunixconnection.c-part-2.patch
> new file mode 100644
> index 0000000000000000000000000000000000000000..047eedcfa5aa2e2acd7d28bee69c2c78a72eecd9
> --- /dev/null
> +++ b/package/libglib2/0002-Fix-error-format-in-gio-gunixconnection.c-part-2.patch
> @@ -0,0 +1,93 @@
> +From 4ae8606b6f80f9764e1f0a82cea7e23c8af487ae Mon Sep 17 00:00:00 2001
> +From: James Knight <james.d.knight@live.com>
> +Date: Thu, 20 Apr 2023 23:41:32 -0400
> +Subject: [PATCH] Fix error format in gio/gunixconnection.c (part 2)
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +Update a series of error messages to use `g_set_error_literal` instead
> +of `g_set_error`. This should prevent `format-nonliteral` compiler
> +issues when `-Werror` is configured:
> +
> +    ../gio/gunixconnection.c: In function ‘g_unix_connection_receive_fd’:
> +    ../gio/gunixconnection.c:183:9: error: format not a string literal, argument types not checked [-Werror=format-nonliteral]
> +      183 |         nscm);
> +          |         ^~~~
> +    ../gio/gunixconnection.c:217:20: error: format not a string literal, argument types not checked [-Werror=format-nonliteral]
> +      217 |                    nfd);
> +          |                    ^~~
> +    ../gio/gunixconnection.c: In function ‘g_unix_connection_receive_credentials’:
> +    ../gio/gunixconnection.c:601:24: error: format not a string literal, argument types not checked [-Werror=format-nonliteral]
> +      601 |                        nscm);
> +          |                        ^~~~
> +
> +This is similar to a previous change [1] made to `gunixconnection.c`.
> +
> +[1]: 44b3d5d80445234041f6c59feb89645f7102c3a4
> +
> +Signed-off-by: James Knight <james.d.knight@live.com>
> +Upstream: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3390

This has now been accepted, so I updated to the actual commit URL.

Applied to master, thanks.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-04-23 11:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21 14:12 [Buildroot] [PATCH 1/4] package/libglib2: bump version to 2.76.1 James Knight
2023-04-23 11:05 ` Yann E. MORIN [this message]
     [not found] <20230421141209.2826-1-james.d.knight@live.com>
2023-04-21 14:12 ` [Buildroot] [PATCH 2/4] package/libglib2: apply upstream status on girdir patch James Knight
2023-04-23 11:03   ` Yann E. MORIN
2023-04-21 14:12 ` [Buildroot] [PATCH 3/4] package/glib-networking: bump version to 2.76.0 James Knight
2023-04-23 11:06   ` Yann E. MORIN
2023-04-21 14:12 ` [Buildroot] [PATCH 4/4] .checkpackageignore: drop legacy ignores (glib2) James Knight
2023-04-23 11:07   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230423110555.GE2696@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=james.d.knight@live.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.