From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH 2/2] iio: gts-helpers: fix integration time units
Date: Sun, 23 Apr 2023 11:45:26 +0800 [thread overview]
Message-ID: <202304231128.2wtp08sj-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <eeacd192c259e885850b5a2dd8b776bccfc44fa8.1681722914.git.mazziesaccount@gmail.com>
References: <eeacd192c259e885850b5a2dd8b776bccfc44fa8.1681722914.git.mazziesaccount@gmail.com>
TO: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>, Matti Vaittinen <mazziesaccount@gmail.com>
TO: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>, Matti Vaittinen <mazziesaccount@gmail.com>
CC: Jonathan Cameron <jic23@kernel.org>
CC: "Lars-Peter Clausen" <lars@metafoo.de>
CC: linux-iio@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Hi Matti,
kernel test robot noticed the following build warnings:
[auto build test WARNING on c86b0e73f0bebbb0245ef2bac4cf269d61ff828c]
url: https://github.com/intel-lab-lkp/linux/commits/Matti-Vaittinen/iio-bu27034-Fix-integration-time/20230417-172240
base: c86b0e73f0bebbb0245ef2bac4cf269d61ff828c
patch link: https://lore.kernel.org/r/eeacd192c259e885850b5a2dd8b776bccfc44fa8.1681722914.git.mazziesaccount%40gmail.com
patch subject: [PATCH 2/2] iio: gts-helpers: fix integration time units
:::::: branch date: 6 days ago
:::::: commit date: 6 days ago
config: parisc-randconfig-m031-20230421 (https://download.01.org/0day-ci/archive/20230423/202304231128.2wtp08sj-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202304231128.2wtp08sj-lkp@intel.com/
New smatch warnings:
drivers/iio/industrialio-gts-helper.c:395 iio_gts_build_avail_time_table() warn: double check that we're allocating correct size: 4 vs 8
Old smatch warnings:
drivers/iio/industrialio-gts-helper.c:246 gain_to_scaletables() warn: double check that we're allocating correct size: 4 vs 8
drivers/iio/industrialio-gts-helper.c:269 gain_to_scaletables() error: uninitialized symbol 'ret'.
drivers/iio/industrialio-gts-helper.c:302 iio_gts_build_avail_scale_table() warn: double check that we're allocating correct size: 4 vs 8
vim +395 drivers/iio/industrialio-gts-helper.c
0cfd72b41d5fe0 Matti Vaittinen 2023-04-17 350
38416c28e16890 Matti Vaittinen 2023-03-31 351 /**
38416c28e16890 Matti Vaittinen 2023-03-31 352 * iio_gts_build_avail_time_table - build table of available integration times
38416c28e16890 Matti Vaittinen 2023-03-31 353 * @gts: Gain time scale descriptor
38416c28e16890 Matti Vaittinen 2023-03-31 354 *
38416c28e16890 Matti Vaittinen 2023-03-31 355 * Build the table which can represent the available times to be returned
38416c28e16890 Matti Vaittinen 2023-03-31 356 * to users using the read_avail-callback.
38416c28e16890 Matti Vaittinen 2023-03-31 357 *
38416c28e16890 Matti Vaittinen 2023-03-31 358 * NOTE: Space allocated for the tables must be freed using
38416c28e16890 Matti Vaittinen 2023-03-31 359 * iio_gts_purge_avail_time_table() when the tables are no longer needed.
38416c28e16890 Matti Vaittinen 2023-03-31 360 *
38416c28e16890 Matti Vaittinen 2023-03-31 361 * Return: 0 on success.
38416c28e16890 Matti Vaittinen 2023-03-31 362 */
38416c28e16890 Matti Vaittinen 2023-03-31 363 static int iio_gts_build_avail_time_table(struct iio_gts *gts)
38416c28e16890 Matti Vaittinen 2023-03-31 364 {
0cfd72b41d5fe0 Matti Vaittinen 2023-04-17 365 int *times, i, j, idx = 0, *int_micro_times;
38416c28e16890 Matti Vaittinen 2023-03-31 366
38416c28e16890 Matti Vaittinen 2023-03-31 367 if (!gts->num_itime)
38416c28e16890 Matti Vaittinen 2023-03-31 368 return 0;
38416c28e16890 Matti Vaittinen 2023-03-31 369
38416c28e16890 Matti Vaittinen 2023-03-31 370 times = kcalloc(gts->num_itime, sizeof(int), GFP_KERNEL);
38416c28e16890 Matti Vaittinen 2023-03-31 371 if (!times)
38416c28e16890 Matti Vaittinen 2023-03-31 372 return -ENOMEM;
38416c28e16890 Matti Vaittinen 2023-03-31 373
0cfd72b41d5fe0 Matti Vaittinen 2023-04-17 374
38416c28e16890 Matti Vaittinen 2023-03-31 375 /* Sort times from all tables to one and remove duplicates */
38416c28e16890 Matti Vaittinen 2023-03-31 376 for (i = gts->num_itime - 1; i >= 0; i--) {
38416c28e16890 Matti Vaittinen 2023-03-31 377 int new = gts->itime_table[i].time_us;
38416c28e16890 Matti Vaittinen 2023-03-31 378
38416c28e16890 Matti Vaittinen 2023-03-31 379 if (times[idx] < new) {
38416c28e16890 Matti Vaittinen 2023-03-31 380 times[idx++] = new;
38416c28e16890 Matti Vaittinen 2023-03-31 381 continue;
38416c28e16890 Matti Vaittinen 2023-03-31 382 }
38416c28e16890 Matti Vaittinen 2023-03-31 383
38416c28e16890 Matti Vaittinen 2023-03-31 384 for (j = 0; j <= idx; j++) {
38416c28e16890 Matti Vaittinen 2023-03-31 385 if (times[j] > new) {
38416c28e16890 Matti Vaittinen 2023-03-31 386 memmove(×[j + 1], ×[j],
38416c28e16890 Matti Vaittinen 2023-03-31 387 (idx - j) * sizeof(int));
38416c28e16890 Matti Vaittinen 2023-03-31 388 times[j] = new;
38416c28e16890 Matti Vaittinen 2023-03-31 389 idx++;
38416c28e16890 Matti Vaittinen 2023-03-31 390 }
38416c28e16890 Matti Vaittinen 2023-03-31 391 }
38416c28e16890 Matti Vaittinen 2023-03-31 392 }
0cfd72b41d5fe0 Matti Vaittinen 2023-04-17 393
0cfd72b41d5fe0 Matti Vaittinen 2023-04-17 394 /* create a list of times formatted as list of IIO_VAL_INT_PLUS_MICRO */
0cfd72b41d5fe0 Matti Vaittinen 2023-04-17 @395 int_micro_times = kcalloc(idx, sizeof(int) * 2, GFP_KERNEL);
0cfd72b41d5fe0 Matti Vaittinen 2023-04-17 396 if (int_micro_times) {
38416c28e16890 Matti Vaittinen 2023-03-31 397 /*
0cfd72b41d5fe0 Matti Vaittinen 2023-04-17 398 * This is just to survive a unlikely corner-case where times in
0cfd72b41d5fe0 Matti Vaittinen 2023-04-17 399 * the given time table were not unique. Else we could just
0cfd72b41d5fe0 Matti Vaittinen 2023-04-17 400 * trust the gts->num_itime.
38416c28e16890 Matti Vaittinen 2023-03-31 401 */
38416c28e16890 Matti Vaittinen 2023-03-31 402 gts->num_avail_time_tables = idx;
0cfd72b41d5fe0 Matti Vaittinen 2023-04-17 403 iio_gts_us_to_int_micro(times, int_micro_times, idx);
0cfd72b41d5fe0 Matti Vaittinen 2023-04-17 404 }
0cfd72b41d5fe0 Matti Vaittinen 2023-04-17 405
0cfd72b41d5fe0 Matti Vaittinen 2023-04-17 406 gts->avail_time_tables = int_micro_times;
0cfd72b41d5fe0 Matti Vaittinen 2023-04-17 407 kfree(times);
0cfd72b41d5fe0 Matti Vaittinen 2023-04-17 408
0cfd72b41d5fe0 Matti Vaittinen 2023-04-17 409 if (!int_micro_times)
0cfd72b41d5fe0 Matti Vaittinen 2023-04-17 410 return -ENOMEM;
38416c28e16890 Matti Vaittinen 2023-03-31 411
38416c28e16890 Matti Vaittinen 2023-03-31 412 return 0;
38416c28e16890 Matti Vaittinen 2023-03-31 413 }
38416c28e16890 Matti Vaittinen 2023-03-31 414
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next reply other threads:[~2023-04-23 3:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-23 3:45 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-04-17 9:19 [PATCH 0/2] iio: Fix integration time unit Matti Vaittinen
2023-04-17 9:20 ` [PATCH 2/2] iio: gts-helpers: fix integration time units Matti Vaittinen
2023-04-23 11:18 ` Jonathan Cameron
2023-04-24 5:09 ` Vaittinen, Matti
2023-05-01 15:48 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202304231128.2wtp08sj-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.