From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AEDBC7618E for ; Mon, 24 Apr 2023 06:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682316249; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=0tB5i7ko95zxPxuZnORawNJI8beraMrPF57S2FQN1F8=; b=FnsC5/dmtzyBSNR3k4BlNl8ESaV0UdLIW71xhifGmA7uToo6LR8+oJH6yfjwxNRW4pu3IY euFAdKAk+zzEvO3nB/zcg+T8QWLiMj1WYSsCiXdRHGH1U4p1rouYrdpG30BBuPYxkSMXB4 tqmf5MxakxWHZi7DqvIkY3mMzmV/SD4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-573-6mzlcy4CMMmLtJYbeC2Aqg-1; Mon, 24 Apr 2023 02:04:08 -0400 X-MC-Unique: 6mzlcy4CMMmLtJYbeC2Aqg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 086041C1743A; Mon, 24 Apr 2023 06:04:06 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6A8491121319; Mon, 24 Apr 2023 06:04:01 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1BCC51946587; Mon, 24 Apr 2023 06:04:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 787BB1946586 for ; Mon, 24 Apr 2023 02:36:41 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 49A37492B0F; Mon, 24 Apr 2023 02:36:41 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast08.extmail.prod.ext.rdu2.redhat.com [10.11.55.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 41545492B03 for ; Mon, 24 Apr 2023 02:36:41 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0BE863814588 for ; Mon, 24 Apr 2023 02:36:41 +0000 (UTC) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-65-BvP3K16rN-6kKcTISaHTAQ-1; Sun, 23 Apr 2023 22:36:31 -0400 X-MC-Unique: BvP3K16rN-6kKcTISaHTAQ-1 Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-63b620188aeso4983117b3a.0 for ; Sun, 23 Apr 2023 19:36:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682303790; x=1684895790; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Er9IodKAhu5Xy/24MmuM3ISnj8SFsqKhcDcV85YYtd4=; b=ePFu2FOUWAAb4n+ToLx9FIy8AJ6ke62sFwTgPJSUsfeUM/roVLAlAaqqiPMUr3aa6n YoxMMg32xY+YJixv2T2nC3zsPtnredgFgkHTloU7aqwTAZO70gjw+OpafUUfQ11ARznX W1EOC+DwVvS56zF6tQJ+rimefErRRgWceXW+IcV/z3mCJ3/RLSdtqS0BjNAlpYpCYWnG KM3G7YdR+1r+6NHJIC2vz5qb337JEIlAkTDGonUEkJ3iknfUJx6WroE2JABH9IMnp0wn hqFkOyneaVGvam3hsyNvXBhx+XbrZg2RkYLr/H/PJHi3GxpGqLX/5EDZ4TX4m5b+uSpN M0iA== X-Gm-Message-State: AAQBX9c2kDvXjI2H8BdUYgwaUxckQmuWJou3m+sD9HoINy/GW9Un9IV0 Sqvj5uNLFZJYLsobdGxnvPnj0k/a1nOzVhlK2ow= X-Google-Smtp-Source: AKy350a438RODTsIQbvbOZb4mhoGqhZ1pvzPivBPJ5Ra5hjJQnsR6/IRQqkIVQmM+kaUu2d3rd1IMA== X-Received: by 2002:a05:6a00:2406:b0:63d:38aa:5617 with SMTP id z6-20020a056a00240600b0063d38aa5617mr12656579pfh.6.1682303790512; Sun, 23 Apr 2023 19:36:30 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id h8-20020aa786c8000000b0063b8279d3aasm6183422pfo.159.2023.04.23.19.36.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 19:36:29 -0700 (PDT) Date: Mon, 24 Apr 2023 11:36:23 +0900 From: Sergey Senozhatsky To: Luis Chamberlain Message-ID: <20230424023623.GC1496740@google.com> References: <20230421195807.2804512-1-mcgrof@kernel.org> <20230421195807.2804512-6-mcgrof@kernel.org> MIME-Version: 1.0 In-Reply-To: <20230421195807.2804512-6-mcgrof@kernel.org> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mailman-Approved-At: Mon, 24 Apr 2023 06:04:00 +0000 Subject: Re: [dm-devel] [PATCH 5/5] zram: use generic PAGE_SECTORS and PAGE_SECTORS_SHIFT X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: djwong@kernel.org, philipp.reisner@linbit.com, linux-mm@kvack.org, dm-devel@redhat.com, agk@redhat.com, drbd-dev@lists.linbit.com, christoph.boehmwalder@linbit.com, willy@infradead.org, hch@infradead.org, p.raghav@samsung.com, senozhatsky@chromium.org, snitzer@kernel.org, linux-block@vger.kernel.org, kbusch@kernel.org, axboe@kernel.dk, da.gomez@samsung.com, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, minchan@kernel.org, patches@lists.linux.dev, linux-fsdevel@vger.kernel.org, lars.ellenberg@linbit.com Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: chromium.org Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On (23/04/21 12:58), Luis Chamberlain wrote: > > Instead of re-defining the already existing constants use the provided ones: > > So replace: > > o SECTORS_PER_PAGE_SHIFT with PAGE_SECTORS_SHIFT > o SECTORS_PER_PAGE with PAGE_SECTORS > > This produces no functional changes. > > Signed-off-by: Luis Chamberlain Reviewed-by: Sergey Senozhatsky -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2565C7EE20 for ; Mon, 24 Apr 2023 02:36:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229476AbjDXCgd (ORCPT ); Sun, 23 Apr 2023 22:36:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230018AbjDXCgc (ORCPT ); Sun, 23 Apr 2023 22:36:32 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C9D22117 for ; Sun, 23 Apr 2023 19:36:31 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-63b4e5fdb1eso4965572b3a.1 for ; Sun, 23 Apr 2023 19:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1682303790; x=1684895790; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Er9IodKAhu5Xy/24MmuM3ISnj8SFsqKhcDcV85YYtd4=; b=Myis4J2Z9lmx+G/UGHQV666UFM6OJ8EKtdAre2rvRUUjU2E+rQLKwJ+D0eYgmT72Z9 5SaX6H/C77vylvdgFXO4tn7m7ArVvZvZSOxiW6NiLDX5h8w4cEfp1YoxEuHlyRXPz09e 5JgUmEmUJwM1H8XEmuezqPmJ+lzP8zXU2UJcc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682303790; x=1684895790; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Er9IodKAhu5Xy/24MmuM3ISnj8SFsqKhcDcV85YYtd4=; b=Is4K/4dO/Z2+/u9U15rQq+/zsDqx62r+FWGLnA3HE8Ip65ZY2SJuG3LRRh507/VGWb wnc8lTmNTjuXd2zVacyOZSihOZH2od5TRkqavkkfwvy5DKCQ/0ixcfuKn1OFi+EbtHOY /GS8bigoxBfkG3Cy1NcJ+FbczDiD2FH5IyacKjQxrFu7aNqt3+zUdmnpaYBc9fqfGQRN fW6rwJR2nse4sHrdeLAw5nZw6nWWDywhi+pPsKXoO8bTpTzcr4+m+yrExKc6Rel3JxP0 ourfjoinhPVOacZq3RiqFVjLEtsOKWXQq77+h1UNWRiAgtQwNpkDRu+mpS33b3UArHK5 cxYg== X-Gm-Message-State: AAQBX9dbUagSWkbuZkEzmMzjd69jWEh/8H7xGHzQELBJNt8cza2cIPe7 00RUle1E6rUB+EiUl/IFCw0dgA== X-Google-Smtp-Source: AKy350a438RODTsIQbvbOZb4mhoGqhZ1pvzPivBPJ5Ra5hjJQnsR6/IRQqkIVQmM+kaUu2d3rd1IMA== X-Received: by 2002:a05:6a00:2406:b0:63d:38aa:5617 with SMTP id z6-20020a056a00240600b0063d38aa5617mr12656579pfh.6.1682303790512; Sun, 23 Apr 2023 19:36:30 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id h8-20020aa786c8000000b0063b8279d3aasm6183422pfo.159.2023.04.23.19.36.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 19:36:29 -0700 (PDT) Date: Mon, 24 Apr 2023 11:36:23 +0900 From: Sergey Senozhatsky To: Luis Chamberlain Cc: axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, christoph.boehmwalder@linbit.com, hch@infradead.org, djwong@kernel.org, minchan@kernel.org, senozhatsky@chromium.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, willy@infradead.org, hare@suse.de, p.raghav@samsung.com, da.gomez@samsung.com, kbusch@kernel.org Subject: Re: [PATCH 5/5] zram: use generic PAGE_SECTORS and PAGE_SECTORS_SHIFT Message-ID: <20230424023623.GC1496740@google.com> References: <20230421195807.2804512-1-mcgrof@kernel.org> <20230421195807.2804512-6-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421195807.2804512-6-mcgrof@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On (23/04/21 12:58), Luis Chamberlain wrote: > > Instead of re-defining the already existing constants use the provided ones: > > So replace: > > o SECTORS_PER_PAGE_SHIFT with PAGE_SECTORS_SHIFT > o SECTORS_PER_PAGE with PAGE_SECTORS > > This produces no functional changes. > > Signed-off-by: Luis Chamberlain Reviewed-by: Sergey Senozhatsky From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id C45144202F5 for ; Mon, 24 Apr 2023 04:36:31 +0200 (CEST) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-63b4e5fdb1eso4965573b3a.1 for ; Sun, 23 Apr 2023 19:36:31 -0700 (PDT) Date: Mon, 24 Apr 2023 11:36:23 +0900 From: Sergey Senozhatsky To: Luis Chamberlain Message-ID: <20230424023623.GC1496740@google.com> References: <20230421195807.2804512-1-mcgrof@kernel.org> <20230421195807.2804512-6-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421195807.2804512-6-mcgrof@kernel.org> Cc: djwong@kernel.org, philipp.reisner@linbit.com, linux-mm@kvack.org, dm-devel@redhat.com, agk@redhat.com, drbd-dev@lists.linbit.com, willy@infradead.org, hch@infradead.org, p.raghav@samsung.com, senozhatsky@chromium.org, snitzer@kernel.org, linux-block@vger.kernel.org, hare@suse.de, kbusch@kernel.org, axboe@kernel.dk, da.gomez@samsung.com, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, minchan@kernel.org, patches@lists.linux.dev, linux-fsdevel@vger.kernel.org, lars.ellenberg@linbit.com Subject: Re: [Drbd-dev] [PATCH 5/5] zram: use generic PAGE_SECTORS and PAGE_SECTORS_SHIFT List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On (23/04/21 12:58), Luis Chamberlain wrote: > > Instead of re-defining the already existing constants use the provided ones: > > So replace: > > o SECTORS_PER_PAGE_SHIFT with PAGE_SECTORS_SHIFT > o SECTORS_PER_PAGE with PAGE_SECTORS > > This produces no functional changes. > > Signed-off-by: Luis Chamberlain Reviewed-by: Sergey Senozhatsky