From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94937C6FD18 for ; Mon, 24 Apr 2023 03:17:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TE3BMBwCgq6bTaRMErvTkkpDapRMWsSa35/hYlM+FR0=; b=GboJXLamZoRQFn zuVIT3ictIN5hlicjbBu+EriO/We21ej89k2sBUxMwixyOtta+RJEjKaixzxedRKVHVuhucE6W4oG lsd1yvC5doaP7wgaWpnXXz0/nf5zIaK/QsdQX0/bQJcMMKtN3Yf70Vw0DVl0bnNL4T+DTQe42pmX+ 2/r2piw+nYKbY3Gt+hU8EoR1W3C638TauL9utxXH63jBDLWjolkvOZiUPi3yAASIIRtvgUegqC9rK u4AwKS9jRxcIwPdvXKiu/lgWrxTLdkUNXaPpaUmUUdqEzwIS1ED6Tq5a8vM+DBjC15F/eeHiyQeTo wdpPMi/ihBluCJ36m20w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pqmgp-00FBEQ-0y; Mon, 24 Apr 2023 03:16:31 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pqmgl-00FBDc-2Q for linux-arm-kernel@lists.infradead.org; Mon, 24 Apr 2023 03:16:29 +0000 Received: from pendragon.ideasonboard.com (133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 366064AD; Mon, 24 Apr 2023 05:16:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1682306174; bh=NPDpujV+oOXwqE5M++R03f5yEhCC275fXEtdzF7RN4s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BSSNceogIo0YOP3CzBwaoB8kVtirtVOqkEu91cd83/k+zxhNQ0oaAOy55EnnjUq4P SzUkFlcrZxXAjiVZ5icmBCU6p41cQE/iOkpZxWAzvwefqcwpwnAprMjp2IA6d/k5yE Sbz4thPPklfTLat4wFpycHZ7zi+df4IFaNDnQu/0= Date: Mon, 24 Apr 2023 06:16:35 +0300 From: Laurent Pinchart To: Adam Ford Cc: linux-arm-kernel@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Catalin Marinas , Will Deacon , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] arm64: dts: imx8mn: Enable CSI and ISI Nodes Message-ID: <20230424031635.GA4652@pendragon.ideasonboard.com> References: <20230423212656.1381002-1-aford173@gmail.com> <20230424004706.GL21943@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230423_201627_962620_A4B2296F X-CRM114-Status: GOOD ( 35.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQWRhbSwKCk9uIFN1biwgQXByIDIzLCAyMDIzIGF0IDA5OjU5OjExUE0gLTA1MDAsIEFkYW0g Rm9yZCB3cm90ZToKPiBPbiBTdW4sIEFwciAyMywgMjAyMyBhdCA5OjIy4oCvUE0gQWRhbSBGb3Jk IHdyb3RlOgo+ID4gT24gU3VuLCBBcHIgMjMsIDIwMjMgYXQgNzo0NuKAr1BNIExhdXJlbnQgUGlu Y2hhcnQgd3JvdGU6Cj4gPiA+IE9uIFN1biwgQXByIDIzLCAyMDIzIGF0IDA0OjI2OjU1UE0gLTA1 MDAsIEFkYW0gRm9yZCB3cm90ZToKPiA+ID4gPiBUaGUgQ1NJIGluIHRoZSBpbXg4bW4gaXMgdGhl IHNhbWUgYXMgd2hhdCBpcyB1c2VkIGluIHRoZSBpbXg4bW0sCj4gPiA+ID4gYnV0IGl0J3Mgcm91 dGVkIHRvIHRoZSBJU0kgb24gdGhlIE5hbm8uIEFkZCBib3RoIHRoZSBJU0kgYW5kIENTSQo+ID4g PiA+IG5vZGVzLCBhbmQgcG9pbnRpbmcgdGhlbSB0byBlYWNoIG90aGVyLiBTaW5jZSB0aGUgQ1NJ IGNhcHR1cmUgaXMKPiA+ID4gPiBkZXBlbmRlbnQgb24gYW4gYXR0YWNoZWQgY2FtZXJhLCBtYXJr IGJvdGggSVNJIGFuZCBDU0kgYXMKPiA+ID4gPiBkaXNhYmxlZCBieSBkZWZhdWx0Lgo+ID4gPgo+ ID4gPiBJJ2QgdGhlbiB3cml0ZSB0aGUgc3ViamVjdCBsaW5lIGFzICJBZGQgQ1NJIGFuZCBJU0kg bm9kZXMiLgo+ID4KPiA+IFRoYXQgbWFrZXMgc2Vuc2UsIGVzcGVjaWFsbHkgc2luY2UgSSBkaXNh YmxlZCB0aGVtIGJ5IGRlZmF1bHQuCj4gPiA+Cj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogQWRhbSBG b3JkIDxhZm9yZDE3M0BnbWFpbC5jb20+Cj4gPiA+ID4KPiA+ID4gPiBkaWZmIC0tZ2l0IGEvYXJj aC9hcm02NC9ib290L2R0cy9mcmVlc2NhbGUvaW14OG1uLmR0c2kgYi9hcmNoL2FybTY0L2Jvb3Qv ZHRzL2ZyZWVzY2FsZS9pbXg4bW4uZHRzaQo+ID4gPiA+IGluZGV4IDhiZThmMDkwZThiOC4uMTAy NTUwYjQxZjIyIDEwMDY0NAo+ID4gPiA+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvZnJlZXNj YWxlL2lteDhtbi5kdHNpCj4gPiA+ID4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9mcmVlc2Nh bGUvaW14OG1uLmR0c2kKPiA+ID4gPiBAQCAtMTEwNCw2ICsxMTA0LDI0IEBAIGRzaW1fZnJvbV9s Y2RpZjogZW5kcG9pbnQgewo+ID4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH07 Cj4gPiA+ID4gICAgICAgICAgICAgICAgICAgICAgIH07Cj4gPiA+ID4KPiA+ID4gPiArICAgICAg ICAgICAgICAgICAgICAgaXNpOiBpc2lAMzJlMjAwMDAgewo+ID4gPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAiZnNsLGlteDhtbi1pc2kiOwo+ID4gPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZyA9IDwweDMyZTIwMDAwIDB4MTAwPjsKPiA+ ID4KPiA+ID4gVGhlIGkuTVg4TU4gcmVmZXJlbmNlIG1hbnVhbCBkb2N1bWVudHMgdGhlIElTSSBy ZWdpc3RlcnMgYmxvY2sgc2l6ZSB0bwo+ID4gPiBiZSA2NGtCLiBTaG91bGQgd2UgdXNlIHRoZSBz YW1lIGhlcmUsIGV2ZW4gaWYgYWxsIHRoZSByZWdpc3RlcnMgd2UgbmVlZAo+ID4gPiBhcmUgd2l0 aGluIHRoZSBmaXJzdCAyNTYgYnl0ZXMgPwo+ID4KPiA+IEkgY2FuIGRvIHRoYXQuCj4gCj4gVGhl cmUgaXMgYSB0eXBvIGluIHRoZSBOYW5vIFJlZiBNYW51YWwuICBFdmVuIHRob3VnaCB0aGUgdGFi bGUgaW4KPiAiVGFibGUgMi02LiBBSVBTNCBNZW1vcnkgTWFwIiByZWFkcyA2NEssIHRoZSBESVNQ TEFZX0JMS19DVFJMIHN0YXJ0cwo+IGF0IDMyZTJfODAwMC4gIFRoZSBsYXJnZXN0IHNpemUgd2Ug Y2FuIGRvIGlzIDB4ODAwMCAoMzJrKQoKMzJrIGlzIGZpbmUuIElmIHlvdSBwcmVmZXIga2VlcGlu ZyAweDEwMCwgdGhhdCdzIGZpbmUgd2l0aCBtZSB0b28uCgo+ID4gPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGludGVycnVwdHMgPSA8R0lDX1NQSSAxNiBJUlFfVFlQRV9MRVZFTF9I SUdIPjsKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjbG9ja3MgPSA8JmNs ayBJTVg4TU5fQ0xLX0RJU1BfQVhJX1JPT1Q+LAo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIDwmY2xrIElNWDhNTl9DTEtfRElTUF9BUEJfUk9PVD47Cj4gPiA+ ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY2xvY2stbmFtZXMgPSAiYXhpIiwgImFw YiI7Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZnNsLGJsay1jdHJsID0g PCZkaXNwX2Jsa19jdHJsPjsKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBw b3dlci1kb21haW5zID0gPCZkaXNwX2Jsa19jdHJsIElNWDhNTl9ESVNQQkxLX1BEX0lTST47Cj4g PiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhdHVzID0gImRpc2FibGVkIjsK PiA+ID4gPiArCj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcG9ydCB7Cj4g PiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpc2lfaW46IGVuZHBv aW50IHsKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgcmVtb3RlLWVuZHBvaW50ID0gPCZtaXBpX2NzaV9vdXQ+Owo+ID4gPiA+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgfTsKPiA+ID4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB9Owo+ID4gPgo+ID4gPiBUaGlzIHdpbGwgZmFpbCB0byB2YWxpZGF0ZSBhZ2Fp bnN0IHRoZSBJU0kgRFQgYmluZGluZywgYXMgdGhleSByZXF1aXJlIGEKPiA+ID4gInBvcnRzIiBu b2RlLiBXaGVuIGEgc2luZ2xlIHBvcnQgaXMgcHJlc2VudCB1c2luZyBhICJwb3J0IiBub2RlIGRp cmVjdGx5Cj4gPiA+IGlzIGZpbmUgZnJvbSBhbiBPRiBncmFwaCBwb2ludCBvZiB2aWV3LCBidXQg dG8gYXZvaWQgdG9vIG11Y2ggY29tcGxleGl0eQo+ID4gPiBpbiB0aGUgSVNJIGJpbmRpbmcgdGhl IGNvbnNlbnN1cyB3YXMgdG8gYWx3YXlzIHJlcXVpcmUgYSAicG9ydHMiIG5vZGUKPiA+ID4gZm9y IHRoZSBJU0kuCj4gPgo+ID4KPiA+IEFyZ2ghICBJIHB1bGxlZCBmcm9tIHRoZSB3cm9uZyB0ZXN0 IHJlcG8uICBJIHJlbWVtYmVyIHRoZSBkaXNjdXNzaW9uCj4gPiBmcm9tIGEgZmV3IG1vbnRocyBi YWNrLiAgSSdsbCBmaXggaXQgYW5kIHRoZSBvdGhlcnMgd2hlbiBJIHN1Ym1pdCBWMi4KPiAKPiBJ dCBhcHBlYXJzIHRoYXQgdXNpbmcgcG9ydHMgc3RpbGwgdGhyb3dzIHdhcm5pbmdzOgo+IAo+IGFy Y2gvYXJtNjQvYm9vdC9kdHMvZnJlZXNjYWxlL2lteDhtbi5kdHNpOjExMTguMTEtMTEyOC43OiBX YXJuaW5nCj4gKGdyYXBoX2NoaWxkX2FkZHJlc3MpOiAvc29jQDAvYnVzQDMyYzAwMDAwL2lzaUAz MmUyMDAwMC9wb3J0czogZ3JhcGgKPiBub2RlIGhhcyBzaW5nbGUgY2hpbGQgbm9kZSAncG9ydEAw JywgI2FkZHJlc3MtY2VsbHMvI3NpemUtY2VsbHMgYXJlCj4gbm90IG5lY2Vzc2FyeQoKQWFyZ2ho aGggOi0pCgo+IEknbGwgbGVhdmUgaXQgbGlrZSB0aGlzIGJlY2F1c2Ugd2Ugd2VyZSB0b2xkIHRv IGRvIHNvLgoKTGV0J3Mgc2VlIGlmIFJvYiBvciBLcnp5c3p0b2YgaGF2ZSBhIHJlY29tbWVuZGF0 aW9uLgoKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgfTsKPiA+ID4gPiArCj4gPiA+ID4g ICAgICAgICAgICAgICAgICAgICAgIGRpc3BfYmxrX2N0cmw6IGJsay1jdHJsQDMyZTI4MDAwIHsK PiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gImZzbCxp bXg4bW4tZGlzcC1ibGstY3RybCIsICJzeXNjb24iOwo+ID4gPiA+ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHJlZyA9IDwweDMyZTI4MDAwIDB4MTAwPjsKPiA+ID4gPiBAQCAtMTE0Nyw2 ICsxMTY1LDQyIEBAIGRpc3BfYmxrX2N0cmw6IGJsay1jdHJsQDMyZTI4MDAwIHsKPiA+ID4gPiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAjcG93ZXItZG9tYWluLWNlbGxzID0gPDE+Owo+ ID4gPiA+ICAgICAgICAgICAgICAgICAgICAgICB9Owo+ID4gPiA+Cj4gPiA+ID4gKyAgICAgICAg ICAgICAgICAgICAgIG1pcGlfY3NpOiBtaXBpLWNzaUAzMmUzMDAwMCB7Cj4gPiA+ID4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJmc2wsaW14OG1tLW1pcGktY3Np MiI7Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDB4MzJlMzAw MDAgMHgxMDAwPjsKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnRlcnJ1 cHRzID0gPEdJQ19TUEkgMTcgSVJRX1RZUEVfTEVWRUxfSElHSD47Cj4gPiA+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgYXNzaWduZWQtY2xvY2tzID0gPCZjbGsgSU1YOE1OX0NMS19D QU1FUkFfUElYRUw+LAo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIDwmY2xrIElNWDhNTl9DTEtfQ1NJMV9QSFlfUkVGPjsKPiA+ID4gPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBhc3NpZ25lZC1jbG9jay1wYXJlbnRzID0gPCZjbGsg SU1YOE1OX1NZU19QTEwyXzEwMDBNPiwKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDwmY2xrIElNWDhNTl9TWVNfUExMMl8xMDAw TT47Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYXNzaWduZWQtY2xvY2st cmF0ZXMgPSA8MzMzMDAwMDAwPjsKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBjbG9jay1mcmVxdWVuY3kgPSA8MzMzMDAwMDAwPjsKPiA+ID4gPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBjbG9ja3MgPSA8JmNsayBJTVg4TU5fQ0xLX0RJU1BfQVBCX1JPT1Q+LAo+ ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDwmY2xrIElNWDhN Tl9DTEtfQ0FNRVJBX1BJWEVMPiwKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICA8JmNsayBJTVg4TU5fQ0xLX0NTSTFfUEhZX1JFRj4sCj4gPiA+ID4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPCZjbGsgSU1YOE1OX0NMS19ESVNQX0FY SV9ST09UPjsKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjbG9jay1uYW1l cyA9ICJwY2xrIiwgIndyYXAiLCAicGh5IiwgImF4aSI7Cj4gPiA+ID4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgcG93ZXItZG9tYWlucyA9IDwmZGlzcF9ibGtfY3RybCBJTVg4TU5fRElT UEJMS19QRF9NSVBJX0NTST47Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg c3RhdHVzID0gImRpc2FibGVkIjsKPiA+ID4gPiArCj4gPiA+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgcG9ydHMgewo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgI2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAjc2l6ZS1jZWxscyA9IDwwPjsKPiA+ID4gPiArCj4gPiA+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwb3J0QDAgewo+ID4gPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWcgPSA8MD47Cj4g PiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9Owo+ID4gPiA+ICsK PiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBvcnRAMSB7Cj4g PiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZyA9 IDwxPjsKPiA+ID4gPiArCj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIG1pcGlfY3NpX291dDogZW5kcG9pbnQgewo+ID4gPiA+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlbW90ZS1lbmRwb2lu dCA9IDwmaXNpX2luPjsKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgfTsKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIH07Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfTsKPiA+ID4gPiAr ICAgICAgICAgICAgICAgICAgICAgfTsKPiA+ID4gPiArCj4gPiA+ID4gICAgICAgICAgICAgICAg ICAgICAgIHVzYm90ZzE6IHVzYkAzMmU0MDAwMCB7Cj4gPiA+ID4gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJmc2wsaW14OG1uLXVzYiIsICJmc2wsaW14N2QtdXNi IiwgImZzbCxpbXgyNy11c2IiOwo+ID4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHJlZyA9IDwweDMyZTQwMDAwIDB4MjAwPjsKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFy dAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8912CC6FD18 for ; Mon, 24 Apr 2023 03:16:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230255AbjDXDQ2 (ORCPT ); Sun, 23 Apr 2023 23:16:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230219AbjDXDQ1 (ORCPT ); Sun, 23 Apr 2023 23:16:27 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3A72212D; Sun, 23 Apr 2023 20:16:25 -0700 (PDT) Received: from pendragon.ideasonboard.com (133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 366064AD; Mon, 24 Apr 2023 05:16:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1682306174; bh=NPDpujV+oOXwqE5M++R03f5yEhCC275fXEtdzF7RN4s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BSSNceogIo0YOP3CzBwaoB8kVtirtVOqkEu91cd83/k+zxhNQ0oaAOy55EnnjUq4P SzUkFlcrZxXAjiVZ5icmBCU6p41cQE/iOkpZxWAzvwefqcwpwnAprMjp2IA6d/k5yE Sbz4thPPklfTLat4wFpycHZ7zi+df4IFaNDnQu/0= Date: Mon, 24 Apr 2023 06:16:35 +0300 From: Laurent Pinchart To: Adam Ford Cc: linux-arm-kernel@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Catalin Marinas , Will Deacon , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] arm64: dts: imx8mn: Enable CSI and ISI Nodes Message-ID: <20230424031635.GA4652@pendragon.ideasonboard.com> References: <20230423212656.1381002-1-aford173@gmail.com> <20230424004706.GL21943@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Adam, On Sun, Apr 23, 2023 at 09:59:11PM -0500, Adam Ford wrote: > On Sun, Apr 23, 2023 at 9:22 PM Adam Ford wrote: > > On Sun, Apr 23, 2023 at 7:46 PM Laurent Pinchart wrote: > > > On Sun, Apr 23, 2023 at 04:26:55PM -0500, Adam Ford wrote: > > > > The CSI in the imx8mn is the same as what is used in the imx8mm, > > > > but it's routed to the ISI on the Nano. Add both the ISI and CSI > > > > nodes, and pointing them to each other. Since the CSI capture is > > > > dependent on an attached camera, mark both ISI and CSI as > > > > disabled by default. > > > > > > I'd then write the subject line as "Add CSI and ISI nodes". > > > > That makes sense, especially since I disabled them by default. > > > > > > > Signed-off-by: Adam Ford > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > > > index 8be8f090e8b8..102550b41f22 100644 > > > > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > > > @@ -1104,6 +1104,24 @@ dsim_from_lcdif: endpoint { > > > > }; > > > > }; > > > > > > > > + isi: isi@32e20000 { > > > > + compatible = "fsl,imx8mn-isi"; > > > > + reg = <0x32e20000 0x100>; > > > > > > The i.MX8MN reference manual documents the ISI registers block size to > > > be 64kB. Should we use the same here, even if all the registers we need > > > are within the first 256 bytes ? > > > > I can do that. > > There is a typo in the Nano Ref Manual. Even though the table in > "Table 2-6. AIPS4 Memory Map" reads 64K, the DISPLAY_BLK_CTRL starts > at 32e2_8000. The largest size we can do is 0x8000 (32k) 32k is fine. If you prefer keeping 0x100, that's fine with me too. > > > > + interrupts = ; > > > > + clocks = <&clk IMX8MN_CLK_DISP_AXI_ROOT>, > > > > + <&clk IMX8MN_CLK_DISP_APB_ROOT>; > > > > + clock-names = "axi", "apb"; > > > > + fsl,blk-ctrl = <&disp_blk_ctrl>; > > > > + power-domains = <&disp_blk_ctrl IMX8MN_DISPBLK_PD_ISI>; > > > > + status = "disabled"; > > > > + > > > > + port { > > > > + isi_in: endpoint { > > > > + remote-endpoint = <&mipi_csi_out>; > > > > + }; > > > > + }; > > > > > > This will fail to validate against the ISI DT binding, as they require a > > > "ports" node. When a single port is present using a "port" node directly > > > is fine from an OF graph point of view, but to avoid too much complexity > > > in the ISI binding the consensus was to always require a "ports" node > > > for the ISI. > > > > > > Argh! I pulled from the wrong test repo. I remember the discussion > > from a few months back. I'll fix it and the others when I submit V2. > > It appears that using ports still throws warnings: > > arch/arm64/boot/dts/freescale/imx8mn.dtsi:1118.11-1128.7: Warning > (graph_child_address): /soc@0/bus@32c00000/isi@32e20000/ports: graph > node has single child node 'port@0', #address-cells/#size-cells are > not necessary Aarghhhh :-) > I'll leave it like this because we were told to do so. Let's see if Rob or Krzysztof have a recommendation. > > > > + }; > > > > + > > > > disp_blk_ctrl: blk-ctrl@32e28000 { > > > > compatible = "fsl,imx8mn-disp-blk-ctrl", "syscon"; > > > > reg = <0x32e28000 0x100>; > > > > @@ -1147,6 +1165,42 @@ disp_blk_ctrl: blk-ctrl@32e28000 { > > > > #power-domain-cells = <1>; > > > > }; > > > > > > > > + mipi_csi: mipi-csi@32e30000 { > > > > + compatible = "fsl,imx8mm-mipi-csi2"; > > > > + reg = <0x32e30000 0x1000>; > > > > + interrupts = ; > > > > + assigned-clocks = <&clk IMX8MN_CLK_CAMERA_PIXEL>, > > > > + <&clk IMX8MN_CLK_CSI1_PHY_REF>; > > > > + assigned-clock-parents = <&clk IMX8MN_SYS_PLL2_1000M>, > > > > + <&clk IMX8MN_SYS_PLL2_1000M>; > > > > + assigned-clock-rates = <333000000>; > > > > + clock-frequency = <333000000>; > > > > + clocks = <&clk IMX8MN_CLK_DISP_APB_ROOT>, > > > > + <&clk IMX8MN_CLK_CAMERA_PIXEL>, > > > > + <&clk IMX8MN_CLK_CSI1_PHY_REF>, > > > > + <&clk IMX8MN_CLK_DISP_AXI_ROOT>; > > > > + clock-names = "pclk", "wrap", "phy", "axi"; > > > > + power-domains = <&disp_blk_ctrl IMX8MN_DISPBLK_PD_MIPI_CSI>; > > > > + status = "disabled"; > > > > + > > > > + ports { > > > > + #address-cells = <1>; > > > > + #size-cells = <0>; > > > > + > > > > + port@0 { > > > > + reg = <0>; > > > > + }; > > > > + > > > > + port@1 { > > > > + reg = <1>; > > > > + > > > > + mipi_csi_out: endpoint { > > > > + remote-endpoint = <&isi_in>; > > > > + }; > > > > + }; > > > > + }; > > > > + }; > > > > + > > > > usbotg1: usb@32e40000 { > > > > compatible = "fsl,imx8mn-usb", "fsl,imx7d-usb", "fsl,imx27-usb"; > > > > reg = <0x32e40000 0x200>; -- Regards, Laurent Pinchart