From: Lee Jones <lee@kernel.org>
To: Shengyu Qu <wiagn233@outlook.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
wens@csie.org, lgirdwood@gmail.com, broonie@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] mfd: axp20x: Add support for AXP15060 PMIC
Date: Mon, 24 Apr 2023 13:16:22 +0100 [thread overview]
Message-ID: <20230424121622.GB50521@google.com> (raw)
In-Reply-To: <TY3P286MB261126058D704A3CDE91CE6D989C9@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>
On Mon, 17 Apr 2023, Shengyu Qu wrote:
> The AXP15060 is a PMIC chip produced by X-Powers, and could be connected
> via an I2C bus.
>
> Describe the regmap and the MFD bits, along with the registers exposed
> via I2C. Eventually advertise the device using a new compatible string
> and add support for power off the system.
>
> The driver would disable PEK function if IRQ is not configured in device
> tree, since some boards (For example, Starfive Visionfive 2) didn't
> connect IRQ line of PMIC to SOC.
>
> GPIO function isn't enabled in this commit, since its configuration
> operation is different from any existing AXP PMICs and needs
> logic modification on existing driver. GPIO support might come in later
> patches.
>
> Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
> ---
> drivers/mfd/axp20x-i2c.c | 2 +
> drivers/mfd/axp20x.c | 90 ++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/axp20x.h | 85 +++++++++++++++++++++++++++++++++++
> 3 files changed, 177 insertions(+)
Doesn't apply. Please rebase and resend with this applied:
Reviewed-by: Lee Jones <lee@kernel.org>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-04-24 12:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230417090537.6052-1-wiagn233@outlook.com>
2023-04-17 9:05 ` [PATCH v2 1/4] dt-bindings: mfd: x-powers,axp152: Document the AXP15060 variant Shengyu Qu
2023-04-18 16:11 ` Krzysztof Kozlowski
2023-04-24 12:08 ` Lee Jones
2023-04-24 15:54 ` Shengyu Qu
2023-04-17 9:05 ` [PATCH v2 2/4] mfd: axp20x: Add support for AXP15060 PMIC Shengyu Qu
2023-04-24 12:16 ` Lee Jones [this message]
2023-04-17 9:05 ` [PATCH v2 3/4] regulator: axp20x: Add AXP15060 support Shengyu Qu
2023-04-17 9:05 ` [PATCH v2 4/4] regulator: axp20x: Set DCDC frequency only when property exists Shengyu Qu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230424121622.GB50521@google.com \
--to=lee@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=wiagn233@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.