From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5EF4C7618E for ; Mon, 24 Apr 2023 20:49:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AD3DC85EE5; Mon, 24 Apr 2023 22:49:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ClTdfwHM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1B7D285EE5; Mon, 24 Apr 2023 22:49:23 +0200 (CEST) Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 91EB485E92 for ; Mon, 24 Apr 2023 22:49:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-54f945a7bddso58654297b3.0 for ; Mon, 24 Apr 2023 13:49:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1682369358; x=1684961358; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JhV3UQoLaX+XflelIa5MnakmJzyhfIZvZOATndTMUPY=; b=ClTdfwHMjVbO+/Un+kakRJINruznFm4Fkk+3wt/TrMyJUSA7yEUsZOGcvFTOrmnBVi aEd4WPs2awd5oTudEZrP5z/Glc4mcbbNPqvPB65dTTxZ0q58oX9dX7BRro5qGeOtGgC/ dv/1wdtUYRmLEiEDEl1Pbl09NJfkZZL3DtetQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682369358; x=1684961358; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JhV3UQoLaX+XflelIa5MnakmJzyhfIZvZOATndTMUPY=; b=dDz3q920Tt4DIsS5UGILeRZSEU47k+wQ211SnbNHH9BArO/Haz7CqzcU4Vzljqaqtl agHnGZ5hHcSCnOVGmOz/bAqXPDtEOTTpiArsvr4CxlRKqaOiupKjvzeiV9vOj6GgAwLW oIcJ1QlJ25jxXNEvsA7jCFvcjCgXNDu4ri/Gg7Et3wvCrq+2dB4LeyA7AwIkTvH9uvAv oWflYsuSKGwiGnvOezLQaJLxJQ6DBkNC8XcubfMpp4XRwykcXjGEU+8zWDaSzc3HlbY0 KfgSURBFux2B7b79bBYG/EnCLfKBy28sXn30DwL9lUosKdEY5SOnvRlj75MUXHCR6y78 s/ww== X-Gm-Message-State: AAQBX9e+kRzqjGhKLUT4Ub8gl7SJJzOS9QgJnmmvP761tqwDOmzydGBu cYIlFC2G/OISXIGJWle/s04x6A== X-Google-Smtp-Source: AKy350b8hXbBh++J/36hgclVQysxB3Cq5KArw8ECqMCdxcEPTj9SA2Bw5BYqxMjKOYHIY6HZ7tNoQA== X-Received: by 2002:a81:a1d7:0:b0:54f:a211:dfd5 with SMTP id y206-20020a81a1d7000000b0054fa211dfd5mr8741400ywg.5.1682369358136; Mon, 24 Apr 2023 13:49:18 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-d6db-313f-1939-7d14.res6.spectrum.com. [2603:6081:7b00:6400:d6db:313f:1939:7d14]) by smtp.gmail.com with ESMTPSA id o193-20020a0dccca000000b00545cb6adc16sm3158795ywd.6.2023.04.24.13.49.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Apr 2023 13:49:17 -0700 (PDT) Date: Mon, 24 Apr 2023 16:49:15 -0400 From: Tom Rini To: Simon Glass , Heinrich Schuchardt Cc: Neha Malcom Francis , u-boot@lists.denx.de, afd@ti.com, vigneshr@ti.com, rogerq@kernel.org, alpernebiyasak@gmail.com, nm@ti.com, bb@ti.com, u-kumar1@ti.com Subject: Re: [PATCH v3 19/19] doc: board: ti: Update documentation for binman flow Message-ID: <20230424204915.GM1134230@bill-the-cat> References: <20230421123203.1315330-1-n-francis@ti.com> <20230421123203.1315330-20-n-francis@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eX6YewZ9uB5/vSJi" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --eX6YewZ9uB5/vSJi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 24, 2023 at 01:42:17PM -0600, Simon Glass wrote: > Hi Neha, >=20 > On Fri, 21 Apr 2023 at 06:33, Neha Malcom Francis wrot= e: > > > > Earlier documentation specified builds for generating bootloader images > > using an external TI repository k3-image-gen and core-secdev-k3. Modify > > this to using the binman flow so that user understands how to build the > > final boot images. > > > > Signed-off-by: Neha Malcom Francis > > --- > > doc/board/ti/am62x_sk.rst | 20 ++++-------- > > doc/board/ti/j721e_evm.rst | 37 ++++++++------------- > > doc/board/ti/k3.rst | 67 ++++++++++---------------------------- > > 3 files changed, 36 insertions(+), 88 deletions(-) >=20 > Reviewed-by: Simon Glass >=20 > > > > diff --git a/doc/board/ti/am62x_sk.rst b/doc/board/ti/am62x_sk.rst > > index b1b7d99bef..f5e0774899 100644 > > --- a/doc/board/ti/am62x_sk.rst > > +++ b/doc/board/ti/am62x_sk.rst > > @@ -115,23 +115,19 @@ Below is the pictorial representation of boot flo= w: > > > > Sources: > > -------- > > -1. SYSFW: > > - Tree: git://git.ti.com/k3-image-gen/k3-image-gen.git > > - Branch: master > > - > > -2. ATF: > > +1. ATF: > > Tree: https://github.com/ARM-software/arm-trusted-firmware.git > > Branch: master > > > > -3. OPTEE: > > +2. OPTEE: > > Tree: https://github.com/OP-TEE/optee_os.git > > Branch: master > > > > -4. U-Boot: > > +3. U-Boot: > > Tree: https://source.denx.de/u-boot/u-boot > > Branch: master > > > > -5. TI Linux Firmware: > > +4. TI Linux Firmware: > > Tree: git://git.ti.com/processor-firmware/ti-linux-firmware.git > > Branch: ti-linux-firmware > > > > @@ -156,18 +152,14 @@ Build procedure: > > .. code-block:: text > > > > $ make ARCH=3Darm CROSS_COMPILE=3Darm-none-linux-gnueabihf- am62x_evm= _r5_defconfig O=3D/tmp/r5 > > - $ make ARCH=3Darm CROSS_COMPILE=3Darm-none-linux-gnueabihf- O=3D/tmp/= r5 > > - $ cd > > - $ make ARCH=3Darm CROSS_COMPILE=3Darm-none-linux-gnueabihf- SOC=3Dam6= 2x SBL=3D/tmp/r5/spl/u-boot-spl.bin SYSFW_PATH=3D/ti-sysfw/ti-fs-firmware-am62x-gp.bin > > - > > -Use the tiboot3.bin generated from last command > > + $ make ARCH=3Darm CROSS_COMPILE=3Darm-none-linux-gnueabihf- O=3D/tmp/= r5 BINMAN_INDIRS=3D > > > > * 3.2 A53: > > > > .. code-block:: text > > > > $ make ARCH=3Darm CROSS_COMPILE=3Daarch64-none-linux-gnu- am62x_evm_a= 53_defconfig O=3D/tmp/a53 > > - $ make ARCH=3Darm CROSS_COMPILE=3Daarch64-none-linux-gnu- ATF=3D/build/k3/lite/release/bl31.bin TEE=3D/ou= t/arm-plat-k3/core/tee-pager_v2.bin DM=3D/ti-dm/= am62xx/ipc_echo_testb_mcu1_0_release_strip.xer5f O=3D/tmp/a53 > > + $ make ARCH=3Darm CROSS_COMPILE=3Daarch64-none-linux-gnu- BL31=3D/build/k3/lite/release/bl31.bin TEE=3D/o= ut/arm-plat-k3/core/tee-pager_v2.bin BINMAN_INDIRS=3D > > > > Target Images > > -------------- > > diff --git a/doc/board/ti/j721e_evm.rst b/doc/board/ti/j721e_evm.rst > > index e898601c41..c90e2b8279 100644 > > --- a/doc/board/ti/j721e_evm.rst > > +++ b/doc/board/ti/j721e_evm.rst > > @@ -130,67 +130,56 @@ support. Below is the pictorial representation of= boot flow: > > > > Sources: > > -------- > > -1. SYSFW: > > - Tree: git://git.ti.com/k3-image-gen/k3-image-gen.git > > - Branch: master > > - > > -2. ATF: > > +1. ATF: > > Tree: https://github.com/ARM-software/arm-trusted-firmware.git > > Branch: master > > > > -3. OPTEE: > > +2. OPTEE: > > Tree: https://github.com/OP-TEE/optee_os.git > > Branch: master > > > > -4. DM Firmware: > > - Tree: git://git.ti.com/processor-firmware/ti-linux-firmware.git > > - Branch: ti-linux-firmware > > - > > -5. U-Boot: > > +3. U-Boot: > > Tree: https://source.denx.de/u-boot/u-boot > > Branch: master > > > > +4. TI Linux Firmware: > > + Tree: git://git.ti.com/processor-firmware/ti-linux-firmware.git > > + Branch: ti-linux-firmware > > + > > Build procedure: > > ---------------- > > -1. SYSFW: > > - > > -.. code-block:: bash > > - > > - make CROSS_COMPILE=3Darm-linux-gnueabihf- SOC=3Dj721e > > - > > -2. ATF: > > +1. ATF: > > > > .. code-block:: bash > > > > make CROSS_COMPILE=3Daarch64-linux-gnu- ARCH=3Daarch64 PLAT=3Dk3 T= ARGET_BOARD=3Dgeneric SPD=3Dopteed > > > > -3. OPTEE: > > +2. OPTEE: > > > > .. code-block:: bash > > > > make PLATFORM=3Dk3-j721e CFG_ARM64_core=3Dy > > > > -4. U-Boot: > > +3. U-Boot: > > > > * 4.1 R5: > > > > .. code-block:: bash > > > > make CROSS_COMPILE=3Darm-linux-gnueabihf- j721e_evm_r5_defconfig O= =3Dbuild/r5 > > - make CROSS_COMPILE=3Darm-linux-gnueabihf- O=3Dbuild/r5 > > + make CROSS_COMPILE=3Darm-linux-gnueabihf- O=3Dbuild/r5 BINMAN_INDI= RS=3D > > > > * 4.2 A72: > > > > .. code-block:: bash > > > > make CROSS_COMPILE=3Daarch64-linux-gnu- j721e_evm_a72_defconfig O= =3Dbuild/a72 > > - make CROSS_COMPILE=3Daarch64-linux-gnu- ATF=3D/build/k3/g= eneric/release/bl31.bin TEE=3D/out/arm-plat-k3/core/tee-pager= _v2.bin DM=3D/ti-dm/j721e/ipc_echo_testb_mcu1_0_release_strip.= xer5f O=3Dbuild/a72 > > + make CROSS_COMPILE=3Daarch64-linux-gnu- BL31=3D/build/k3/= generic/release/bl31.bin TEE=3D/out/arm-plat-k3/core/tee-page= r_v2.bin BINMAN_INDIRS=3D >=20 > Is there an 'O=3Dbuild/a72' missing there? Not strictly missing, no. One of those style things for Heinrich is, we should be consistent in our examples both in terms of O=3D (when not strictly required, it is for the _r5 variant since you must keep some of that build for the Cortex-A part, so that you can get something that boots the physical machine, in the end). > You can combine these as well, by using 'j721e_evm_a72_defconfig all' > to both configure and build. >=20 > Also it might be nice to keep the line length shorter if you can. Other parts for Heinrich to chime in, to have consistent on all the board examples. --=20 Tom --eX6YewZ9uB5/vSJi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmRG60gACgkQFHw5/5Y0 tywGEAwAmrVq2hztp+SZt0rxwiJmVcBvx4J0uXS2TmzhOZ1+iFMyMBfdR/WDeP1s sV/wB0GcHYEDpLZ8tki9O4vST8mN8gXs8EJk0Hx6haiOtCC8vm/M0sG0Y0CYjzPE tlkpr31eIwUURn5JlDbil4DvURtaSi6+qpKNJOJLYULZMaCF46Tiia4gYh1IShxI RfQwuSTMJoM15h97AEnEMowbqs1YrXpATf51h0o5VwM4Qs5ED0wihsGIWbZpjZUm qjCDD6hU0EHqEG757j6rlPhZYo9qy7BIHrEFDgbZNRp/UOGNB0/4uNY/s1tJZ8ja 3WqY73HEp6Gpn3VvT0+pJU0Kjrnm9NRsvI4uw4rdBuWg31Yc+mrVThdp14ELz7to 2VA8WmFMnhDgO3QBDxcFT0pFoujmVQkH1Ut1c2PLTcJ8dMqdB0gv2XlkhPwbaabh hiS6inmVmvK+kEzVfagkLoDosGksvpCe36k2kMPQNd1tF3O2pypTLdo7rAoRUte4 DK3hHxbi =bKMo -----END PGP SIGNATURE----- --eX6YewZ9uB5/vSJi--