From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CA4CC77B61 for ; Tue, 25 Apr 2023 13:35:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234277AbjDYNft (ORCPT ); Tue, 25 Apr 2023 09:35:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234158AbjDYNf0 (ORCPT ); Tue, 25 Apr 2023 09:35:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B70EE14444; Tue, 25 Apr 2023 06:35:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 37DAB62E7B; Tue, 25 Apr 2023 13:35:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CC30C433EF; Tue, 25 Apr 2023 13:35:00 +0000 (UTC) Date: Tue, 25 Apr 2023 19:04:57 +0530 From: Manivannan Sadhasivam To: Nishanth Menon Cc: Manivannan Sadhasivam , Jacek Anaszewski , Krzysztof Kozlowski , Rob Herring , Lee Jones , Pavel Machek , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vignesh Raghavendra Subject: Re: [PATCH] dt-bindings: leds: Drop redundant cpus enum match Message-ID: <20230425133457.GA5640@thinkpad> References: <20230424151437.256073-1-nm@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230424151437.256073-1-nm@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Mon, Apr 24, 2023 at 10:14:37AM -0500, Nishanth Menon wrote: > Commit e91a4d5deb96 ("dt-bindings: leds: Document commonly used > LED triggers") introduced a enum match for cpu, while a pattern > '^cpu[0-9]*$' already exists. > > This causes linux,default-trigger = "cpu" to have more than one match > and generates the following dtbs_check warning: > > arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dtb: leds: led-2:linux,default-trigger: More than one condition true in oneOf schema: > {'$ref': '/schemas/types.yaml#/definitions/string', > 'oneOf': [{'items': [{'enum': ['backlight', > 'default-on', > 'heartbeat', > 'disk-activity', > 'disk-read', > 'disk-write', > 'timer', > 'pattern', > 'audio-micmute', > 'audio-mute', > 'bluetooth-power', > 'cpu', > 'flash', > 'kbd-capslock', > 'mtd', > 'nand-disk', > 'none', > 'torch', > 'usb-gadget', > 'usb-host', > 'usbport']}], > 'maxItems': 1, > 'minItems': 1, > 'type': 'array'}, > {'items': [{'pattern': '^cpu[0-9]*$'}], > 'maxItems': 1, > 'minItems': 1, > 'type': 'array'}, > {'items': [{'pattern': '^hci[0-9]+-power$'}], > 'maxItems': 1, > 'minItems': 1, > 'type': 'array'}, > {'items': [{'pattern': '^mmc[0-9]+$'}], > 'maxItems': 1, > 'minItems': 1, > 'type': 'array'}, > {'items': [{'pattern': '^phy[0-9]+tx$'}], > 'maxItems': 1, > 'minItems': 1, > 'type': 'array'}]} > > Drop the explicit match against cpu since the pattern match already > covers the same. > > Fixes: e91a4d5deb96 ("dt-bindings: leds: Document commonly used LED triggers") > Cc: Manivannan Sadhasivam > Signed-off-by: Nishanth Menon Acked-by: Manivannan Sadhasivam - Mani > --- > Documentation/devicetree/bindings/leds/common.yaml | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml > index 11aedf1650a1..58b492d00246 100644 > --- a/Documentation/devicetree/bindings/leds/common.yaml > +++ b/Documentation/devicetree/bindings/leds/common.yaml > @@ -105,8 +105,6 @@ properties: > - audio-mute > # LED indicates bluetooth power state > - bluetooth-power > - # LED indicates activity of all CPUs > - - cpu > # LED indicates camera flash state > - flash > # LED indicated keyboard capslock > -- > 2.40.0 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BC3AC77B61 for ; Tue, 25 Apr 2023 13:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yzL3V1QXVt58RgrYGNrv4EZ9bxOMSBbsB0JVYtGdDrw=; b=adujcQWFkJratc ZpFiR9LssKJSHDj71HVdJRPD0jSALb5GR2IwUP2CIdF6Y+6pZkQdDEnt7gfkDEdt+NSGZNkZJCdxl AqSs1hJrPyIiKNqHIkdi1bgmNCN4fPi8LrcKN0LfTUNXWq344/Ie1sOjxk9olJVhfb5+9L+kX5TDw F7Uo/eND7KIxhqJyUBxixaNalIChp1HiYUZ6+fhVCH34+8KDW5ml4ET8zzV5D/4rih6sWTzBhv9f2 s1Yz8BYBWsVL3bYRXLWE50teGAxqA80YE6I8yadmTzUJxPGqTRBxdtXFS11ZfzgI7mFvAM+0D4Vq6 5gDgx6ioyvTVQxaRo16w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1prIp3-001GLi-1X; Tue, 25 Apr 2023 13:35:09 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1prIoz-001GKG-0a for linux-arm-kernel@lists.infradead.org; Tue, 25 Apr 2023 13:35:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 34DEF62A1B; Tue, 25 Apr 2023 13:35:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CC30C433EF; Tue, 25 Apr 2023 13:35:00 +0000 (UTC) Date: Tue, 25 Apr 2023 19:04:57 +0530 From: Manivannan Sadhasivam To: Nishanth Menon Cc: Manivannan Sadhasivam , Jacek Anaszewski , Krzysztof Kozlowski , Rob Herring , Lee Jones , Pavel Machek , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vignesh Raghavendra Subject: Re: [PATCH] dt-bindings: leds: Drop redundant cpus enum match Message-ID: <20230425133457.GA5640@thinkpad> References: <20230424151437.256073-1-nm@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230424151437.256073-1-nm@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230425_063505_329883_2873D6C3 X-CRM114-Status: GOOD ( 17.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBcHIgMjQsIDIwMjMgYXQgMTA6MTQ6MzdBTSAtMDUwMCwgTmlzaGFudGggTWVub24g d3JvdGU6Cj4gQ29tbWl0IGU5MWE0ZDVkZWI5NiAoImR0LWJpbmRpbmdzOiBsZWRzOiBEb2N1bWVu dCBjb21tb25seSB1c2VkCj4gTEVEIHRyaWdnZXJzIikgaW50cm9kdWNlZCBhIGVudW0gbWF0Y2gg Zm9yIGNwdSwgd2hpbGUgYSBwYXR0ZXJuCj4gJ15jcHVbMC05XSokJyBhbHJlYWR5IGV4aXN0cy4K PiAKPiBUaGlzIGNhdXNlcyBsaW51eCxkZWZhdWx0LXRyaWdnZXIgPSAiY3B1IiB0byBoYXZlIG1v cmUgdGhhbiBvbmUgbWF0Y2gKPiBhbmQgZ2VuZXJhdGVzIHRoZSBmb2xsb3dpbmcgZHRic19jaGVj ayB3YXJuaW5nOgo+IAo+IGFyY2gvYXJtNjQvYm9vdC9kdHMvdGkvazMtajcyMWUtYmVhZ2xlYm9u ZWFpNjQuZHRiOiBsZWRzOiBsZWQtMjpsaW51eCxkZWZhdWx0LXRyaWdnZXI6IE1vcmUgdGhhbiBv bmUgY29uZGl0aW9uIHRydWUgaW4gb25lT2Ygc2NoZW1hOgo+IAl7JyRyZWYnOiAnL3NjaGVtYXMv dHlwZXMueWFtbCMvZGVmaW5pdGlvbnMvc3RyaW5nJywKPiAJICdvbmVPZic6IFt7J2l0ZW1zJzog W3snZW51bSc6IFsnYmFja2xpZ2h0JywKPiAJICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAnZGVmYXVsdC1vbicsCj4gCSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2hlYXJ0 YmVhdCcsCj4gCSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2Rpc2stYWN0aXZpdHkn LAo+IAkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdkaXNrLXJlYWQnLAo+IAkgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICdkaXNrLXdyaXRlJywKPiAJICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAndGltZXInLAo+IAkgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICdwYXR0ZXJuJywKPiAJICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnYXVk aW8tbWljbXV0ZScsCj4gCSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2F1ZGlvLW11 dGUnLAo+IAkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdibHVldG9vdGgtcG93ZXIn LAo+IAkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdjcHUnLAo+IAkgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICdmbGFzaCcsCj4gCSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgJ2tiZC1jYXBzbG9jaycsCj4gCSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgJ210ZCcsCj4gCSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ25hbmQtZGlzaycs Cj4gCSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ25vbmUnLAo+IAkgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICd0b3JjaCcsCj4gCSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgJ3VzYi1nYWRnZXQnLAo+IAkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICd1c2ItaG9zdCcsCj4gCSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ3VzYnBvcnQn XX1dLAo+IAkgICAgICAgICAgICAnbWF4SXRlbXMnOiAxLAo+IAkgICAgICAgICAgICAnbWluSXRl bXMnOiAxLAo+IAkgICAgICAgICAgICAndHlwZSc6ICdhcnJheSd9LAo+IAkgICAgICAgICAgIHsn aXRlbXMnOiBbeydwYXR0ZXJuJzogJ15jcHVbMC05XSokJ31dLAo+IAkgICAgICAgICAgICAnbWF4 SXRlbXMnOiAxLAo+IAkgICAgICAgICAgICAnbWluSXRlbXMnOiAxLAo+IAkgICAgICAgICAgICAn dHlwZSc6ICdhcnJheSd9LAo+IAkgICAgICAgICAgIHsnaXRlbXMnOiBbeydwYXR0ZXJuJzogJ15o Y2lbMC05XSstcG93ZXIkJ31dLAo+IAkgICAgICAgICAgICAnbWF4SXRlbXMnOiAxLAo+IAkgICAg ICAgICAgICAnbWluSXRlbXMnOiAxLAo+IAkgICAgICAgICAgICAndHlwZSc6ICdhcnJheSd9LAo+ IAkgICAgICAgICAgIHsnaXRlbXMnOiBbeydwYXR0ZXJuJzogJ15tbWNbMC05XSskJ31dLAo+IAkg ICAgICAgICAgICAnbWF4SXRlbXMnOiAxLAo+IAkgICAgICAgICAgICAnbWluSXRlbXMnOiAxLAo+ IAkgICAgICAgICAgICAndHlwZSc6ICdhcnJheSd9LAo+IAkgICAgICAgICAgIHsnaXRlbXMnOiBb eydwYXR0ZXJuJzogJ15waHlbMC05XSt0eCQnfV0sCj4gCSAgICAgICAgICAgICdtYXhJdGVtcyc6 IDEsCj4gCSAgICAgICAgICAgICdtaW5JdGVtcyc6IDEsCj4gCSAgICAgICAgICAgICd0eXBlJzog J2FycmF5J31dfQo+IAo+IERyb3AgdGhlIGV4cGxpY2l0IG1hdGNoIGFnYWluc3QgY3B1IHNpbmNl IHRoZSBwYXR0ZXJuIG1hdGNoIGFscmVhZHkKPiBjb3ZlcnMgdGhlIHNhbWUuCj4gCj4gRml4ZXM6 IGU5MWE0ZDVkZWI5NiAoImR0LWJpbmRpbmdzOiBsZWRzOiBEb2N1bWVudCBjb21tb25seSB1c2Vk IExFRCB0cmlnZ2VycyIpCj4gQ2M6IE1hbml2YW5uYW4gU2FkaGFzaXZhbSA8bWFuaXZhbm5hbi5z YWRoYXNpdmFtQGxpbmFyby5vcmc+Cj4gU2lnbmVkLW9mZi1ieTogTmlzaGFudGggTWVub24gPG5t QHRpLmNvbT4KCkFja2VkLWJ5OiBNYW5pdmFubmFuIFNhZGhhc2l2YW0gPG1hbml2YW5uYW4uc2Fk aGFzaXZhbUBsaW5hcm8ub3JnPgoKLSBNYW5pCgo+IC0tLQo+ICBEb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvbGVkcy9jb21tb24ueWFtbCB8IDIgLS0KPiAgMSBmaWxlIGNoYW5nZWQs IDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9sZWRzL2NvbW1vbi55YW1sIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL2xlZHMvY29tbW9uLnlhbWwKPiBpbmRleCAxMWFlZGYxNjUwYTEuLjU4YjQ5MmQwMDI0 NiAxMDA2NDQKPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbGVkcy9j b21tb24ueWFtbAo+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9sZWRz L2NvbW1vbi55YW1sCj4gQEAgLTEwNSw4ICsxMDUsNiBAQCBwcm9wZXJ0aWVzOgo+ICAgICAgICAg ICAgLSBhdWRpby1tdXRlCj4gICAgICAgICAgICAgICMgTEVEIGluZGljYXRlcyBibHVldG9vdGgg cG93ZXIgc3RhdGUKPiAgICAgICAgICAgIC0gYmx1ZXRvb3RoLXBvd2VyCj4gLSAgICAgICAgICAg ICMgTEVEIGluZGljYXRlcyBhY3Rpdml0eSBvZiBhbGwgQ1BVcwo+IC0gICAgICAgICAgLSBjcHUK PiAgICAgICAgICAgICAgIyBMRUQgaW5kaWNhdGVzIGNhbWVyYSBmbGFzaCBzdGF0ZQo+ICAgICAg ICAgICAgLSBmbGFzaAo+ICAgICAgICAgICAgICAjIExFRCBpbmRpY2F0ZWQga2V5Ym9hcmQgY2Fw c2xvY2sKPiAtLSAKPiAyLjQwLjAKPiAKCi0tIArgrq7grqPgrr/grrXgrqPgr43grqPgrqngr40g 4K6a4K6k4K6+4K6a4K6/4K614K6u4K+NCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==