From: Petr Vorel <pvorel@suse.cz>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] rpc/rpc-tirpc: Fix compile error on clang when using registerrpc
Date: Tue, 25 Apr 2023 16:05:10 +0200 [thread overview]
Message-ID: <20230425140510.GC3014439@pevik> (raw)
In-Reply-To: <1682413930-19764-2-git-send-email-xuyang2018.jy@fujitsu.com>
Hi Xu,
> +++ b/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/rpc/rpc_regunreg_registerrpc/rpc_registerrpc.c
> @@ -68,8 +68,8 @@ int main(int argn, char *argc[])
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> //call routine
> rslt =
> - registerrpc(progNum, VERSNUM, PROCNUM, simplePing, xdr_int,
> - xdr_int);
> + registerrpc(progNum, VERSNUM, PROCNUM, simplePing,
> + (xdrproc_t) xdr_int, (xdrproc_t) xdr_int);
Maybe just put rslt = on the same line (to fix often broken style a bit?)
rslt = registerrpc(progNum, VERSNUM, PROCNUM, simplePing,
(xdrproc_t) xdr_int, (xdrproc_t) xdr_int);
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-04-25 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 9:12 [LTP] [PATCH 1/2] rpc/rpc-tirpc: Fix compile error on clang when using clnt_broadcast Yang Xu
2023-04-25 9:12 ` [LTP] [PATCH 2/2] rpc/rpc-tirpc: Fix compile error on clang when using registerrpc Yang Xu
2023-04-25 14:05 ` Petr Vorel [this message]
2023-04-26 1:59 ` Yang Xu (Fujitsu)
2023-04-25 14:02 ` [LTP] [PATCH 1/2] rpc/rpc-tirpc: Fix compile error on clang when using clnt_broadcast Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425140510.GC3014439@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.