From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47F38C77B61 for ; Tue, 25 Apr 2023 21:57:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236224AbjDYV5X (ORCPT ); Tue, 25 Apr 2023 17:57:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236217AbjDYV5W (ORCPT ); Tue, 25 Apr 2023 17:57:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A020BBBE for ; Tue, 25 Apr 2023 14:57:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 258DA62A11 for ; Tue, 25 Apr 2023 21:57:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43853C433D2; Tue, 25 Apr 2023 21:57:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682459840; bh=PWMy0qhUC/zd0fyiOIWaW3RQPEIwLSEGlvMc92NtfWk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=K5oP3BGRJjsmVMpIdQE8wCYo6C4wokQ5pna1NG/MBTLANGFm6qBxUBuHuNMBxYow9 SrEYnZTV7H+qFi+FogrxQCq9KZTNf1M+F1j/pqN5v1gLshOtMFgRrasiVYIcfq8ATM pDVd03+x60gNXyv0eC6z4hwWRX0scHug8AgPSTIQWRRGoz0tr0UdFDgo6MYwJZPYEN Ftv8reanxc0b85G87QRsipAu+5Go+aCwb+dr6vMk2D4HVqNok5xJCu0BIIVtmYqIqy usXkRxF1H1ooxuIhZDB9Lj5MtHOLcBXBVuHLgts1jE9pvYjHZTivfTRR5bkSqUlqDC N+xQI5cyadZmA== Date: Tue, 25 Apr 2023 14:57:19 -0700 From: Jakub Kicinski To: "Arnd Bergmann" Cc: "Paolo Abeni" , Netdev , "Andrew Lunn" , "Heiner Kallweit" , "Russell King" , "David S . Miller" , "Eric Dumazet" Subject: Re: [PATCH net-next] net: phy: drop PHYLIB_LEDS knob Message-ID: <20230425145719.621d6568@kernel.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 25 Apr 2023 22:35:46 +0100 Arnd Bergmann wrote: > > @Andrew, @Arnd: the rationale here is to avoid the new config knob=y, > > which caused in the past a few complains from Linus. In this case I > > think the raised exception is not valid, for the reason mentioned above. > > > > If you have different preferences or better solutions to address that, > > please voice them :) > > I think using IS_REACHABLE() is generally much worse than having another > explicit option, because it makes it harder for users to figure out why > something does not work as they had expected it to. > > Note that I'm the one who introduced IS_REACHABLE() to start with, > but the intention at the time was really to replace open-coded > logic doing the same thing, not to have it as a generic way to > hide broken dependencies. Agreed :( But that kind of presupposed that user knows what they are looking for, right? My thinking was this: using "depends on" instead and preventing the bad configuration from occurring is a strongly preferred alternative to IS_REACHABLE(). But an extra third option which will be hidden from nconfig will not prevent user from doing LEDS=m PHYS=y.