From: Jakub Kicinski <kuba@kernel.org>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Andrew Lunn" <andrew@lunn.ch>, "Paolo Abeni" <pabeni@redhat.com>,
Netdev <netdev@vger.kernel.org>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>
Subject: Re: [PATCH net-next] net: phy: drop PHYLIB_LEDS knob
Date: Tue, 25 Apr 2023 15:01:11 -0700 [thread overview]
Message-ID: <20230425150111.1b17b17b@kernel.org> (raw)
In-Reply-To: <e1e1022a-da6e-4267-bca9-18cd76e0d218@app.fastmail.com>
On Tue, 25 Apr 2023 22:44:34 +0100 Arnd Bergmann wrote:
> On Tue, Apr 25, 2023, at 22:38, Andrew Lunn wrote:
> >>
> >> -config PHYLIB_LEDS
> >> - bool "Support probing LEDs from device tree"
> >
> > I don't know Kconfig to well, but i think you just need to remove the
> > text, just keep the bool.
> >
> > - bool "Support probing LEDs from device tree"
> > + bool
>
> Right, that should work, or it can become
>
> def_bool y
>
> or even
>
> def_bool OF
>
> for brevity.
Hm, I think Paolo was concerned that we'd get PHYLIB_LEDS=y if PHYLIB=n
and LEDS_CLASS=n. But that's not possible because the option is in the
"if PHYLIB" section.
Is that right?
next prev parent reply other threads:[~2023-04-25 22:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 21:19 [PATCH net-next] net: phy: drop PHYLIB_LEDS knob Paolo Abeni
2023-04-25 21:35 ` Arnd Bergmann
2023-04-25 21:57 ` Jakub Kicinski
2023-04-25 21:38 ` Andrew Lunn
2023-04-25 21:44 ` Arnd Bergmann
2023-04-25 22:01 ` Jakub Kicinski [this message]
2023-04-25 22:45 ` Andrew Lunn
2023-04-26 7:55 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425150111.1b17b17b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.