From: "Michael S. Tsirkin" <mst@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-devel@nongnu.org, marcel.apfelbaum@gmail.com,
philmd@linaro.org, david@redhat.com, peterx@redhat.com,
pbonzini@redhat.com, den-plotnikov@yandex-team.ru,
lersek@redhat.com, kraxel@redhat.com
Subject: Re: [PATCH v2 0/3] ROM migration
Date: Tue, 25 Apr 2023 16:06:02 -0400 [thread overview]
Message-ID: <20230425160524-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <17200eef-53c0-71c2-6b7b-0f16514b223d@yandex-team.ru>
On Tue, Apr 25, 2023 at 07:37:43PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 25.04.23 19:14, Vladimir Sementsov-Ogievskiy wrote:
> > Hi all!
> >
> > v2: simply ignore romfile on incoming migration when romsize is
> > specified.
> >
> > Here I suggest a way to solve a problem, when we have existing
> > running QEMU with old option ROM of small size and want to migrate to
> > new environment where we don't have this ROM file.
> >
> > All the details are in patch 03; 01-02 are simple code style
> > improvements.
> >
> > Vladimir Sementsov-Ogievskiy (3):
> > pci: pci_add_option_rom(): improve style
> > pci: pci_add_option_rom(): refactor: use g_autofree for path variable
> > pci: ROM preallocation for incoming migration
> >
> > hw/pci/pci.c | 101 ++++++++++++++++++++++++++++-----------------------
> > 1 file changed, 55 insertions(+), 46 deletions(-)
> >
>
> While being here, could I ask a question:
>
> As I understand, netcard ROM file is needed only for network boot. So, it's absolutely correct to use romfile="" option: network boot will not work, but everything else will work correctly. Is that right?
>
> --
> Best regards,
> Vladimir
That is correct.
--
MST
next prev parent reply other threads:[~2023-04-25 20:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 16:14 [PATCH v2 0/3] ROM migration Vladimir Sementsov-Ogievskiy
2023-04-25 16:14 ` [PATCH v2 1/3] pci: pci_add_option_rom(): improve style Vladimir Sementsov-Ogievskiy
2023-05-02 9:37 ` David Hildenbrand
2023-04-25 16:14 ` [PATCH v2 2/3] pci: pci_add_option_rom(): refactor: use g_autofree for path variable Vladimir Sementsov-Ogievskiy
2023-05-02 9:38 ` David Hildenbrand
2023-04-25 16:14 ` [PATCH v2 3/3] pci: ROM preallocation for incoming migration Vladimir Sementsov-Ogievskiy
2023-04-26 4:43 ` Michael S. Tsirkin
2023-04-26 20:00 ` Vladimir Sementsov-Ogievskiy
2023-05-02 9:48 ` Michael S. Tsirkin
2023-05-02 9:59 ` Vladimir Sementsov-Ogievskiy
2023-05-02 10:11 ` Juan Quintela
2023-05-02 10:13 ` Vladimir Sementsov-Ogievskiy
2023-05-02 11:26 ` Michael S. Tsirkin
2023-05-09 15:48 ` Juan Quintela
2023-04-28 8:30 ` Juan Quintela
2023-04-28 20:37 ` Vladimir Sementsov-Ogievskiy
2023-05-03 9:20 ` David Hildenbrand
2023-05-03 9:50 ` Vladimir Sementsov-Ogievskiy
2023-05-03 10:05 ` Michael S. Tsirkin
2023-05-03 11:39 ` Vladimir Sementsov-Ogievskiy
2023-05-09 15:54 ` Michael S. Tsirkin
2023-05-09 16:09 ` David Hildenbrand
2023-05-10 9:38 ` Vladimir Sementsov-Ogievskiy
2023-04-25 16:37 ` [PATCH v2 0/3] ROM migration Vladimir Sementsov-Ogievskiy
2023-04-25 20:06 ` Michael S. Tsirkin [this message]
2023-04-26 9:34 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425160524-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=david@redhat.com \
--cc=den-plotnikov@yandex-team.ru \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.