From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EFF4C6FD18 for ; Tue, 25 Apr 2023 17:32:05 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F365310E4; Tue, 25 Apr 2023 19:31:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F365310E4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1682443923; bh=MFHY/zMKVbuTlsy8wNydgg1+6cL9zuyXOy9Kbhl4KEs=; h=Date:From:To:Subject:References:In-Reply-To:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=SyEpGoMx4G8kQz4xx6DJQVVOjQF/71J8XhKKqLmf4+gubN4FJJnO6ReqCTWx+AJpm BniJHjlZjtcSgMthlTj00MlgVYi2BzSPlP0ogJRXmRiVgtcFQArcFn8l4AN6rjs/0+ sKZx3Db4KbsBAtA+fwPvZhgpTMAb8KvH7ldWRbCM= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id A698BF80236; Tue, 25 Apr 2023 19:30:48 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 76021F80236; Tue, 25 Apr 2023 19:30:43 +0200 (CEST) Received: from mail-oo1-f51.google.com (mail-oo1-f51.google.com [209.85.161.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 253C2F800F8 for ; Tue, 25 Apr 2023 19:30:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 253C2F800F8 Received: by mail-oo1-f51.google.com with SMTP id 006d021491bc7-549d9c295dfso1132540eaf.2 for ; Tue, 25 Apr 2023 10:30:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682443831; x=1685035831; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Kx2MBexI4IdwwU3HpEq9VlXt44gc2MaIIVYzDB9fIV4=; b=NQ6XdII7E4DTNT8e12HCcyBtRBSf2scgWeBRLADWmLSVQirjeY4sPFmH35+FENlf+0 ikFvszr/pBEJvwOsKSYVFR3kEq9dHrhuRsgR5gGVq0oAdZqOAftsSn6dJmaX0VCFN3bO mnwdfdxmvlmfE5m/k/7vv5uJbRLcCz7dAlvaNOgNdydm8cgaGFlg5G1wrDK+YnnFXk8V B+53cEEBPIYCIvh1jXrx2ky56Pk9tJGVdLxgNTLhLDGmbP2Zv9lrN3aPsfu2UccFlMAd 2BfkGizD06BrF3JembaC6IXhQ6wPJiyTPaqx+pONTHciECXR26GA+6WTxu1nynglEKxv OZDw== X-Gm-Message-State: AAQBX9c1NUfK4VwT135Au8eLtYYI+hqutXJ3L6N6qvxq48zOq59Ruv+y qj7OepdixHA53sX1v2UTkw== X-Google-Smtp-Source: AKy350YWtCrrLr3UM/3y9aq2ToOzHzoeNJ5TSClKRGZBXj25jO0yAiVnnnhvDs1DjJXnxt3FzDRMHw== X-Received: by 2002:a4a:e058:0:b0:545:62bf:fd6c with SMTP id v24-20020a4ae058000000b0054562bffd6cmr6727843oos.0.1682443831133; Tue, 25 Apr 2023 10:30:31 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id m41-20020a4a952c000000b005251e3f92ecsm6259455ooi.47.2023.04.25.10.30.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Apr 2023 10:30:30 -0700 (PDT) Received: (nullmailer pid 1984548 invoked by uid 1000); Tue, 25 Apr 2023 17:30:29 -0000 Date: Tue, 25 Apr 2023 12:30:29 -0500 From: Rob Herring To: Herve Codina Subject: Re: [PATCH 1/4] dt-bindings: sound: Add simple-iio-aux Message-ID: <20230425173029.GA1967523-robh@kernel.org> References: <20230421124122.324820-1-herve.codina@bootlin.com> <20230421124122.324820-2-herve.codina@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421124122.324820-2-herve.codina@bootlin.com> Message-ID-Hash: BBCMR24H4NMTPRAZ2MEFA5XOMLS62PAJ X-Message-ID-Hash: BBCMR24H4NMTPRAZ2MEFA5XOMLS62PAJ X-MailFrom: robherring2@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Jonathan Cameron , Lars-Peter Clausen , Takashi Iwai , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Christophe Leroy , Thomas Petazzoni X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, Apr 21, 2023 at 02:41:19PM +0200, Herve Codina wrote: > Industrial I/O devices can be present in the audio path. > These devices needs to be viewed as audio components in order to be > fully integrated in the audio path. > > simple-iio-aux allows to consider these Industrial I/O devices as > auxliary audio devices. What makes it simple? Any binding called simple or generic is a trigger for me. Best to avoid those terms. :) Examples of devices would be useful here. > > Signed-off-by: Herve Codina > --- > .../bindings/sound/simple-iio-aux.yaml | 65 +++++++++++++++++++ > 1 file changed, 65 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/simple-iio-aux.yaml > > diff --git a/Documentation/devicetree/bindings/sound/simple-iio-aux.yaml b/Documentation/devicetree/bindings/sound/simple-iio-aux.yaml > new file mode 100644 > index 000000000000..fab128fce4fc > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/simple-iio-aux.yaml > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/simple-iio-aux.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Simple IIO auxiliary > + > +maintainers: > + - Herve Codina > + > +description: | Don't need '|' > + Auxiliary device based on Industrial I/O device channels > + > +allOf: > + - $ref: /schemas/iio/iio-consumer.yaml You don't need to reference consumer schemas. > + - $ref: dai-common.yaml# > + > +properties: > + compatible: > + const: simple-iio-aux > + > + io-channels: > + description: > + Industrial I/O device channels used > + > + io-channel-names: > + description: > + Industrial I/O channel names related to io-channels. > + These names are used to provides sound controls, widgets and routes names. > + > + invert: Property names should globally only have 1 type definition. This is generic enough I'd be concerned that's not the case. > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: | > + A list of 0/1 flags defining whether or not the related channel is > + inverted > + items: > + enum: [0, 1] > + default: 0 > + description: | > + Invert the sound control value compared to the IIO channel raw value. > + - 1: The related sound control value is inverted meaning that the > + minimum sound control value correspond to the maximum IIO channel > + raw value and the maximum sound control value correspond to the > + minimum IIO channel raw value. > + - 0: The related sound control value is not inverted meaning that the > + minimum (resp maximum) sound control value correspond to the > + minimum (resp maximum) IIO channel raw value. > + > +required: > + - compatible > + - io-channels > + - io-channel-names > + > +unevaluatedProperties: false > + > +examples: > + - | > + aux { > + compatible = "simple-iio-aux"; > + io-channels = <&iio 0>, <&iio 1>, <&iio 2>, <&iio 3>; > + io-channel-names = "CH0", "CH1", "CH2", "CH3"; Not really useful names. Do you have a real example? > + /* Invert CH1 and CH2 */ > + invert = <0 1 1>; IMO, invert should be same length as io-channels. > + }; How do support multiple instances? Say you have 2 sound cards (or 1 sound card with multiple audio paths) each with different sets of IIO channels associated with it. You'd need a link to each 'aux' node. Why not just add io-channels to the sound card nodes directly? That's already just a virtual, top-level container node grouping all the components. I don't see why we need another virtual node grouping a subset of them. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A090C77B78 for ; Tue, 25 Apr 2023 17:30:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234649AbjDYRae (ORCPT ); Tue, 25 Apr 2023 13:30:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234084AbjDYRad (ORCPT ); Tue, 25 Apr 2023 13:30:33 -0400 Received: from mail-oo1-f47.google.com (mail-oo1-f47.google.com [209.85.161.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F9C75BBA; Tue, 25 Apr 2023 10:30:32 -0700 (PDT) Received: by mail-oo1-f47.google.com with SMTP id 006d021491bc7-549d9c295dfso1132541eaf.2; Tue, 25 Apr 2023 10:30:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682443831; x=1685035831; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Kx2MBexI4IdwwU3HpEq9VlXt44gc2MaIIVYzDB9fIV4=; b=AiliSyTg6nIo/kjAS7JyEfIFAxQx5OP69OvrF/lHoicVsFxHrJ3MTfNr6pNE6YaPib 6Qt3GL776p8K20uVJAPDosy4HYR/ZBKKNRG9mEYsdyraWurdZo4p2P3rktJl8RC09/0w qu/AAV2fFMje8Z3pDev8I5hSd7MSb3fC5fm6lt5cPS7VtJTVUFj+6Iq5MbR8VjyFe4PZ Jj3nkM6MghSZV/WWEW/hqFn5WJb1hn+A2aNX+xpM4w9CNZ2WOYLmPHeMzQ+g7scn1mXM IkBLo1rhxcWd2KrlGhkcEUdp5AgK8hAdSHgRE9uwIzXy+VRqdLSDman0/adrwUALisdu 1EPQ== X-Gm-Message-State: AAQBX9dZv60rKG+eziQgVTxZGYMNLxiy7nvCYrUiUW5LI0Y+v8de5BmM lcQM2zdgADFZ7wJHMAPEPtltYizOeQ== X-Google-Smtp-Source: AKy350YWtCrrLr3UM/3y9aq2ToOzHzoeNJ5TSClKRGZBXj25jO0yAiVnnnhvDs1DjJXnxt3FzDRMHw== X-Received: by 2002:a4a:e058:0:b0:545:62bf:fd6c with SMTP id v24-20020a4ae058000000b0054562bffd6cmr6727843oos.0.1682443831133; Tue, 25 Apr 2023 10:30:31 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id m41-20020a4a952c000000b005251e3f92ecsm6259455ooi.47.2023.04.25.10.30.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Apr 2023 10:30:30 -0700 (PDT) Received: (nullmailer pid 1984548 invoked by uid 1000); Tue, 25 Apr 2023 17:30:29 -0000 Date: Tue, 25 Apr 2023 12:30:29 -0500 From: Rob Herring To: Herve Codina Cc: Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Jonathan Cameron , Lars-Peter Clausen , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Christophe Leroy , Thomas Petazzoni Subject: Re: [PATCH 1/4] dt-bindings: sound: Add simple-iio-aux Message-ID: <20230425173029.GA1967523-robh@kernel.org> References: <20230421124122.324820-1-herve.codina@bootlin.com> <20230421124122.324820-2-herve.codina@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421124122.324820-2-herve.codina@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, Apr 21, 2023 at 02:41:19PM +0200, Herve Codina wrote: > Industrial I/O devices can be present in the audio path. > These devices needs to be viewed as audio components in order to be > fully integrated in the audio path. > > simple-iio-aux allows to consider these Industrial I/O devices as > auxliary audio devices. What makes it simple? Any binding called simple or generic is a trigger for me. Best to avoid those terms. :) Examples of devices would be useful here. > > Signed-off-by: Herve Codina > --- > .../bindings/sound/simple-iio-aux.yaml | 65 +++++++++++++++++++ > 1 file changed, 65 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/simple-iio-aux.yaml > > diff --git a/Documentation/devicetree/bindings/sound/simple-iio-aux.yaml b/Documentation/devicetree/bindings/sound/simple-iio-aux.yaml > new file mode 100644 > index 000000000000..fab128fce4fc > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/simple-iio-aux.yaml > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/simple-iio-aux.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Simple IIO auxiliary > + > +maintainers: > + - Herve Codina > + > +description: | Don't need '|' > + Auxiliary device based on Industrial I/O device channels > + > +allOf: > + - $ref: /schemas/iio/iio-consumer.yaml You don't need to reference consumer schemas. > + - $ref: dai-common.yaml# > + > +properties: > + compatible: > + const: simple-iio-aux > + > + io-channels: > + description: > + Industrial I/O device channels used > + > + io-channel-names: > + description: > + Industrial I/O channel names related to io-channels. > + These names are used to provides sound controls, widgets and routes names. > + > + invert: Property names should globally only have 1 type definition. This is generic enough I'd be concerned that's not the case. > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: | > + A list of 0/1 flags defining whether or not the related channel is > + inverted > + items: > + enum: [0, 1] > + default: 0 > + description: | > + Invert the sound control value compared to the IIO channel raw value. > + - 1: The related sound control value is inverted meaning that the > + minimum sound control value correspond to the maximum IIO channel > + raw value and the maximum sound control value correspond to the > + minimum IIO channel raw value. > + - 0: The related sound control value is not inverted meaning that the > + minimum (resp maximum) sound control value correspond to the > + minimum (resp maximum) IIO channel raw value. > + > +required: > + - compatible > + - io-channels > + - io-channel-names > + > +unevaluatedProperties: false > + > +examples: > + - | > + aux { > + compatible = "simple-iio-aux"; > + io-channels = <&iio 0>, <&iio 1>, <&iio 2>, <&iio 3>; > + io-channel-names = "CH0", "CH1", "CH2", "CH3"; Not really useful names. Do you have a real example? > + /* Invert CH1 and CH2 */ > + invert = <0 1 1>; IMO, invert should be same length as io-channels. > + }; How do support multiple instances? Say you have 2 sound cards (or 1 sound card with multiple audio paths) each with different sets of IIO channels associated with it. You'd need a link to each 'aux' node. Why not just add io-channels to the sound card nodes directly? That's already just a virtual, top-level container node grouping all the components. I don't see why we need another virtual node grouping a subset of them. Rob