From: "Kernel.org Bugbot" <bugbot@kernel.org>
To: bugs@lists.linux.dev, willy@infradead.org, brauner@kernel.org,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: large pause when opening file descriptor which is power of 2
Date: Wed, 26 Apr 2023 23:42:01 +0000 (UTC) [thread overview]
Message-ID: <20230426-b217366c6-4f880518247a@bugzilla.kernel.org> (raw)
In-Reply-To: <ZEl34WthS8UNJnNd@casper.infradead.org>
phemmer+kernel writes via Kernel.org Bugzilla:
(In reply to Bugbot from comment #1)
> Matthew Wilcox <willy@infradead.org> writes:
>
> On Wed, Apr 26, 2023 at 05:58:06PM +0000, Kernel.org Bugbot wrote:
> > When running a threaded program, and opening a file descriptor that
> > is a power of 2 (starting at 64), the call takes a very long time to
> > complete. Normally such a call takes less than 2us. However with this
> > issue, I've seen the call take up to around 50ms. Additionally this only
> > happens the first time, and not subsequent times that file descriptor is
> > used. I'm guessing there might be some expansion of some internal data
> > structures going on. But I cannot see why this process would take so long.
>
> Because we allocate a new block of memory and then memcpy() the old
> block of memory into it. This isn't surprising behaviour to me.
> I don't think there's much we can do to change it (Allocating a
> segmented array of file descriptors has previously been vetoed by
> people who have programs with a million file descriptors). Is it
> causing you problems?
Yes. I'm using using sockets for IPC. Specifically haproxy with its SPOE protocol. Low latency is important. Normally a call (including optional connect if a new connection is needed) will easily complete in under 100us. So I want to set a timeout of 1ms to avoid blocking traffic. However because this issue effectively randomly pops up, that 1ms timeout is too low, and the issue can actually impact multiple in-flight requests because haproxy tries to share that one IPC connection for them all. But if I raise the timeout (and I'd have to raise it to something like 100ms, as I've seen delays up to 47ms in just light testing), then I run the risk of significantly impacting traffic if there is a legitimate slowdown. While a low timeout and the occasional failure is probably the better of the two options, I'd prefer not to fail at all.
View: https://bugzilla.kernel.org/show_bug.cgi?id=217366#c6
You can reply to this message to join the discussion.
--
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)
next prev parent reply other threads:[~2023-04-26 23:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 17:58 large pause when opening file descriptor which is power of 2 Kernel.org Bugbot
2023-04-26 19:13 ` Matthew Wilcox
2023-04-26 19:46 ` Al Viro
2023-04-26 19:56 ` Matthew Wilcox
2023-04-26 20:33 ` Al Viro
2023-04-26 19:58 ` Al Viro
2023-04-26 23:42 ` Kernel.org Bugbot [this message]
2023-04-27 9:28 ` Christian Brauner
2023-04-27 18:18 ` Matthew Wilcox
2023-04-28 0:37 ` Kernel.org Bugbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230426-b217366c6-4f880518247a@bugzilla.kernel.org \
--to=bugbot@kernel.org \
--cc=brauner@kernel.org \
--cc=bugs@lists.linux.dev \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.