From: sai.gowtham.ch@intel.com
To: igt-dev@lists.freedesktop.org, zbigniew.kempczynski@intel.com,
sai.gowtham.ch@intel.com
Subject: [igt-dev] [PATCH i-g-t] lib/xe/xe_spin: Integrate igt_spin_new with Xe.
Date: Thu, 27 Apr 2023 01:46:26 +0530 [thread overview]
Message-ID: <20230426201626.5361-1-sai.gowtham.ch@intel.com> (raw)
From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
Extending the spin_create implementation and allocator handle support in xe,
where it submits dummy work loads to engine. This Implementation is wrapped
around vm_bind and unbind as we are supposed to do it manually for xe.
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
---
lib/xe/xe_spin.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++
lib/xe/xe_spin.h | 21 +++++++++++++--
2 files changed, 86 insertions(+), 2 deletions(-)
diff --git a/lib/xe/xe_spin.c b/lib/xe/xe_spin.c
index 856d0ba2..503d440e 100644
--- a/lib/xe/xe_spin.c
+++ b/lib/xe/xe_spin.c
@@ -82,6 +82,73 @@ void xe_spin_end(struct xe_spin *spin)
spin->end = 0;
}
+static xe_spin_t *
+xe_spin_create(int fd, struct xe_spin_factory *opt)
+{
+ struct drm_xe_engine_class_instance *eci;
+ size_t bo_size = xe_get_default_alignment(fd);
+ uint32_t vm, bo, engine, syncobj;
+ uint64_t ahnd = opt->ahnd, addr;
+ struct xe_spin *spin;
+ struct drm_xe_sync sync = {
+ .flags = DRM_XE_SYNC_SYNCOBJ | DRM_XE_SYNC_SIGNAL,
+ };
+ struct drm_xe_exec exec = {
+ .num_batch_buffer = 1,
+ .num_syncs = 1,
+ .syncs = to_user_pointer(&sync),
+ };
+
+ spin = calloc(1, sizeof(struct xe_spin));
+ igt_assert(spin);
+
+ vm = xe_vm_create(fd, 0, 0);
+ bo = xe_bo_create(fd, eci->gt_id, vm, bo_size);
+ spin = xe_bo_map(fd, bo, 0x1000);
+ engine = xe_engine_create(fd, vm, eci, 0);
+ syncobj = syncobj_create(fd, 0);
+
+ if (ahnd)
+ addr = intel_allocator_alloc_with_strategy(ahnd, bo, bo_size, 0, ALLOC_STRATEGY_LOW_TO_HIGH);
+
+ xe_vm_bind_sync(fd, vm, bo, 0, addr, bo_size);
+
+ xe_spin_init(spin, addr, true);
+ exec.engine_id = engine;
+ exec.address = addr;
+ sync.handle = syncobj;
+ igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_EXEC, &exec), 0);
+
+ opt->bo = bo;
+ opt->vm = vm;
+ opt->engine = engine;
+ opt->spin = spin;
+ opt->syncobj = syncobj;
+
+ return opt->spin;
+
+}
+
+xe_spin_t *
+__xe_spin_factory(int fd, struct xe_spin_factory *opt)
+{
+ return xe_spin_create(fd, opt);
+}
+
+void xe_spin_sync_wait(int fd, struct xe_spin_factory *opt)
+{
+ igt_assert(syncobj_wait(fd, &opt->syncobj, 1, INT64_MAX, 0,
+ NULL));
+}
+
+void xe_spin_free(int fd, struct xe_spin_factory *opt)
+{
+ xe_spin_end(opt->spin);
+ xe_engine_destroy(fd, opt->engine);
+ xe_vm_destroy(fd, opt->vm);
+ gem_close(fd, opt->bo);
+}
+
void xe_cork_init(int fd, struct drm_xe_engine_class_instance *hwe,
struct xe_cork *cork)
{
diff --git a/lib/xe/xe_spin.h b/lib/xe/xe_spin.h
index 73f9a026..124fdebe 100644
--- a/lib/xe/xe_spin.h
+++ b/lib/xe/xe_spin.h
@@ -15,17 +15,34 @@
#include "xe_query.h"
/* Mapped GPU object */
-struct xe_spin {
+struct xe_spin_factory {
+ uint64_t ahnd;
+ uint32_t vm;
+ uint32_t bo;
+ uint32_t engine;
+ uint32_t syncobj;
+ struct xe_spin *spin;
+};
+
+typedef struct xe_spin {
uint32_t batch[16];
uint64_t pad;
uint32_t start;
uint32_t end;
-};
+} xe_spin_t;
+
+xe_spin_t *
+__xe_spin_factory(int fd, struct xe_spin_factory *opt);
+
+#define xe_spin_new(fd, ...) \
+ __xe_spin_factory(fd, &((xe_spin_factory *opt){__VA__ARGS}))
void xe_spin_init(struct xe_spin *spin, uint64_t addr, bool preempt);
bool xe_spin_started(struct xe_spin *spin);
+void xe_spin_sync_wait(int fd, struct xe_spin_factory *opt);
void xe_spin_wait_started(struct xe_spin *spin);
void xe_spin_end(struct xe_spin *spin);
+void xe_spin_free(int fd, struct xe_spin_factory *opt);
struct xe_cork {
struct xe_spin *spin;
--
2.39.1
next reply other threads:[~2023-04-26 20:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 20:16 sai.gowtham.ch [this message]
2023-04-26 20:56 ` [igt-dev] ✗ Fi.CI.BAT: failure for lib/xe/xe_spin: Integrate igt_spin_new with Xe. (rev2) Patchwork
2023-04-27 5:40 ` [igt-dev] [PATCH i-g-t] lib/xe/xe_spin: Integrate igt_spin_new with Xe Modem, Bhanuprakash
2023-04-27 5:49 ` Ch, Sai Gowtham
2023-04-27 7:09 ` Zbigniew Kempczyński
-- strict thread matches above, loose matches on Subject: below --
2023-05-10 5:55 sai.gowtham.ch
2023-05-11 5:08 ` Zbigniew Kempczyński
2023-05-11 10:03 ` Ch, Sai Gowtham
2023-05-11 6:43 ` Hogander, Jouni
2023-05-11 10:02 ` Ch, Sai Gowtham
2023-05-11 10:04 ` Hogander, Jouni
2023-05-05 5:35 sai.gowtham.ch
2023-05-08 12:19 ` Hogander, Jouni
2023-05-08 12:22 ` Ch, Sai Gowtham
2023-05-08 19:55 ` Zbigniew Kempczyński
2023-05-09 6:36 ` Zbigniew Kempczyński
2023-06-08 14:10 ` Matthew Brost
2023-07-17 9:19 ` Zbigniew Kempczyński
2023-04-24 11:54 sai.gowtham.ch
2023-04-25 3:36 ` Zbigniew Kempczyński
2023-04-25 7:07 ` Ch, Sai Gowtham
2023-04-25 10:48 ` Zbigniew Kempczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230426201626.5361-1-sai.gowtham.ch@intel.com \
--to=sai.gowtham.ch@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.