From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Michal Hocko <mhocko@suse.com>
Cc: Yosry Ahmed <yosryahmed@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeelb@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Muchun Song <muchun.song@linux.dev>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Petr Mladek <pmladek@suse.com>, Chris Li <chrisl@kernel.org>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] memcg: use seq_buf_do_printk() with mem_cgroup_print_oom_meminfo()
Date: Thu, 27 Apr 2023 09:55:25 +0900 [thread overview]
Message-ID: <20230427005525.GF1496740@google.com> (raw)
In-Reply-To: <ZElCHJrkOVsy79KY@dhcp22.suse.cz>
On (23/04/26 17:24), Michal Hocko wrote:
> No objection from me but is it possible that more printk calls (one per
> line with this change correct?) would add a contention on the printk
> path?
It probably will have opposite effect: console->write of longer lines
keep local IRQs disabled longer and keep console_waiter printk spinning
(in console_trylock_spinning()) longer.
next prev parent reply other threads:[~2023-04-27 0:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 13:39 [PATCH 0/2] memcg: OOM log improvements Yosry Ahmed
2023-04-26 13:39 ` Yosry Ahmed
[not found] ` <20230426133919.1342942-1-yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2023-04-26 13:39 ` [PATCH 1/2] memcg: use seq_buf_do_printk() with mem_cgroup_print_oom_meminfo() Yosry Ahmed
2023-04-26 13:39 ` Yosry Ahmed
[not found] ` <20230426133919.1342942-2-yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2023-04-26 15:24 ` Michal Hocko
2023-04-26 15:24 ` Michal Hocko
2023-04-27 0:55 ` Sergey Senozhatsky [this message]
2023-04-27 0:45 ` Sergey Senozhatsky
2023-04-27 0:45 ` Sergey Senozhatsky
2023-04-26 14:19 ` [PATCH 0/2] memcg: OOM log improvements Steven Rostedt
2023-04-26 14:19 ` Steven Rostedt
2023-04-26 14:20 ` Yosry Ahmed
2023-04-26 14:20 ` Yosry Ahmed
2023-04-26 13:39 ` [PATCH 2/2] memcg: dump memory.stat during cgroup OOM for v1 Yosry Ahmed
[not found] ` <20230426133919.1342942-3-yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2023-04-26 15:27 ` Michal Hocko
2023-04-26 15:27 ` Michal Hocko
2023-04-27 9:21 ` Yosry Ahmed
2023-04-27 9:21 ` Yosry Ahmed
[not found] ` <CAJD7tkZ1cODXRuVQ3fWL0s=VsyKZqDPPNqFZec_COAXm0XfXWA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-04-27 14:06 ` Michal Hocko
2023-04-27 14:06 ` Michal Hocko
2023-04-27 22:12 ` Yosry Ahmed
2023-04-27 22:12 ` Yosry Ahmed
[not found] ` <CAJD7tkac7VKV6Ob8qQWzhm8Ayyk3xB0YCY6edL-TxpXV3aCzXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-04-28 9:44 ` Michal Hocko
2023-04-28 9:44 ` Michal Hocko
[not found] ` <ZEuVaxSUo7WxLn3K-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2023-04-28 13:05 ` Yosry Ahmed
2023-04-28 13:05 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427005525.GF1496740@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chrisl@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=pmladek@suse.com \
--cc=roman.gushchin@linux.dev \
--cc=rostedt@goodmis.org \
--cc=shakeelb@google.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.