From: Chaitanya Kulkarni <kch@nvidia.com>
To: <hare@suse.de>
Cc: <kbusch@kernel.org>, <hch@lst.de>, <sagi@grimberg.me>,
<linux-nvme@lists.infradead.org>,
Chaitanya Kulkarni <kch@nvidia.com>
Subject: [RFC COMPILE ONLY PATCH 0/2] nvme-core: dhchap_secret code cleanup
Date: Thu, 27 Apr 2023 01:02:05 -0700 [thread overview]
Message-ID: <20230427080207.17249-1-kch@nvidia.com> (raw)
Hi,
Marking it compile only RFC since blktests are failing on current
nvme-6.4 so I was not able to complete the testing.
Bunch of code is repeated all over when defining nvme_ctrl_dhchap_secret
and nvme_ctrl_dhchap_ctrl_secret. Factor out a common function for
nvme_ctrl_secret_dhchap_store() and nvme_ctrl_secret_dhchap_ctrl_store()
into common function nvme_dhchap_secret_store_common().
Add a macro to define device attr in order to remove code duplication
for above mentioned attributes.
No functional changes in this patch-series.
-ck
Chaitanya Kulkarni (2):
nvme-core: factor out common code into helper
nvme-core: use macro defination to define dev attr
drivers/nvme/host/core.c | 128 ++++++++++++++-------------------------
1 file changed, 44 insertions(+), 84 deletions(-)
--
2.40.0
next reply other threads:[~2023-04-27 8:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 8:02 Chaitanya Kulkarni [this message]
2023-04-27 8:02 ` [RFC PATCH 1/2] nvme-core: factor out common code into helper Chaitanya Kulkarni
2023-05-02 6:11 ` Hannes Reinecke
2023-05-02 6:48 ` Chaitanya Kulkarni
2023-04-27 8:02 ` [RFC PATCH 2/2] nvme-core: use macro defination to define dev attr Chaitanya Kulkarni
2023-05-02 6:12 ` Hannes Reinecke
2023-05-02 2:38 ` [RFC COMPILE ONLY PATCH 0/2] nvme-core: dhchap_secret code cleanup Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427080207.17249-1-kch@nvidia.com \
--to=kch@nvidia.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.