From: Stephen Hemminger <stephen@networkplumber.org>
To: Bilal Khan <bilalkhanrecovered@gmail.com>
Cc: majordomo@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Fix grammar in ip-rule(8) man page
Date: Thu, 27 Apr 2023 08:52:39 -0700 [thread overview]
Message-ID: <20230427085239.6f8906a6@hermes.local> (raw)
In-Reply-To: <CA++M5e+Edbq8qnYgGvG=oR_=Cecou_NTqxH2Z-Ld9=SdhQQLQg@mail.gmail.com>
On Thu, 27 Apr 2023 11:41:48 +0500
Bilal Khan <bilalkhanrecovered@gmail.com> wrote:
> Hey there,
>
> I have identified a small grammatical error in the ip-rule(8) man
> page, and have created a patch to fix it. The current first line of
> the DESCRIPTION section reads:
>
> > ip rule manipulates rules in the routing policy database control the route selection algorithm.
>
> This sentence contains a grammatical error, as "control" should either
> be changed to "that controls" (to apply to "database") or "to control"
> (to apply to "manipulates"). I have updated the sentence to read:
>
> > ip rule manipulates rules in the routing policy database that controls the route selection algorithm.
>
> This change improves the readability and clarity of the ip-rule(8) man
> page and makes it easier for users to understand how to use the ip
> rule command.
>
> I have attached the patch file
> "0001-Fix-grammar-in-ip-rule-8-man-page.patch" to this email and would
> appreciate any feedback or suggestions for improvement.
Patch is missing signed off by. For legal reasons patches are only accepted
with a valid signed-off-by which is Developers Certificate of Origin.
You can use kernel checkpatch to check iproute2 patches as well.
next prev parent reply other threads:[~2023-04-27 15:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 6:41 [PATCH] Fix grammar in ip-rule(8) man page Bilal Khan
2023-04-27 15:52 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-05-08 8:05 Bilal Khan
2023-05-11 9:15 ` Simon Horman
2023-05-11 15:50 ` Stephen Hemminger
2023-05-12 8:15 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427085239.6f8906a6@hermes.local \
--to=stephen@networkplumber.org \
--cc=bilalkhanrecovered@gmail.com \
--cc=majordomo@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.